Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispay restaurants, pubs etc. on z17 as small brown squares #2945

Conversation

matthijsmelissen
Copy link
Collaborator

This prevents overcrowding on z17.

Before:
screen shot 2017-11-12 at 00 54 26

After:
screen shot 2017-11-12 at 00 53 00

@matthijsmelissen
Copy link
Collaborator Author

Not sure myself if this is an improvement, what do others think?

@matkoniecz
Copy link
Contributor

Based on this single picture - I really like this solution for solving problem that I failed to notice.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 12, 2017

I'm not sure, but rather I don't think it's useful. For shops it made sense:

  • there's so many of them in many places
  • violet dot always mean just a "general shop" (more important ones are rendered earlier)

Eating places:

@SK53
Copy link

SK53 commented Nov 12, 2017

I simply cannot adequately resolve the two colours of dots in the new image, so whereas before I can identify areas which are broadly shopping streets and places with a good choice of restaurants (and the odd cafe / bar) now I can't. It makes the map far less informative and I suspect the perceived improvement is most obvious to those working with Carto most closely.

It is important to show how such rendering rule changes affect the appearance of other less dense areas of the map: at a minimum small towns, villages and hamlets as well as isolated restaurants/bars/cafes/pubs.

@matthijsmelissen
Copy link
Collaborator Author

matthijsmelissen commented Nov 12, 2017

I simply cannot adequately resolve the two colours of dots in the new image

Just to be clear: you find it difficult (or impossible) to tell apart the brown and pink dots/squares?

@systemed
Copy link
Contributor

This is another urban/rural issue (see #1957). Whether or not it makes sense in urban areas, it's a clear loss of utility in rural areas: http://www.openstreetmap.org/#map=17/51.81633/-1.70480

FWIW, cycle.travel renders pubs/cafe icons at z13 in rural areas, z16 in towns, z17 in cities (names come in later).

@imagico
Copy link
Collaborator

imagico commented Nov 13, 2017

FWIW, cycle.travel renders pubs/cafe icons at z13 in rural areas, z16 in towns, z17 in cities (names come in later).

@systemed - what data do you base this selection on?

@systemed
Copy link
Contributor

Urban area polygons from OS Open Data in the UK, CORINE in mainland Europe, TIGER in the US, and equivalents (which I can't remember off the top of my head) for Canada and Mexico. They're all of pretty good quality apart from CORINE. For openstreetmap-carto it would be more appropriate to generate any such polygons from OSM data, of course.

@SK53
Copy link

SK53 commented Nov 13, 2017

@math1985 I can just about discriminate them if I take my specs off and squint really closely at the screen; but this indoors with reasonable lighting etc. I would imagine the difference would be much harder on a mobile device in bright sunlight.

@systemed et al. I currently have draft urban areas on github for the following areas : Australasia & Oceana, Africa, South America, North America. I can generate them for Central America and Europe, but I had issues with my algorithm in Japan which complicated generating an Asia dataset. Everything is derived directly from OSM and is stored as Geojson files to allow visualisation of the data (and, perhaps more importantly, diffs between versions). Data are partitioned into either 5 or 10 degree squares to ensure no file is too large for github. The repository is : https://github.com/SK53/ua2/.

@kocio-pl
Copy link
Collaborator

Please move the discussions about urban areas to #1957, since it's an important problem on its own.

@dieterdreist
Copy link

dieterdreist commented Nov 14, 2017 via email

@matthijsmelissen
Copy link
Collaborator Author

I think the criticism makes sense, I'm going to close this PR.

@Klaus-Tockloth
Copy link

Use also dots instead of squares:

bildschirmfoto 2017-11-18 um 07 14 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants