-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispay restaurants, pubs etc. on z17 as small brown squares #2945
Dispay restaurants, pubs etc. on z17 as small brown squares #2945
Conversation
Not sure myself if this is an improvement, what do others think? |
Based on this single picture - I really like this solution for solving problem that I failed to notice. |
I'm not sure, but rather I don't think it's useful. For shops it made sense:
Eating places:
|
I simply cannot adequately resolve the two colours of dots in the new image, so whereas before I can identify areas which are broadly shopping streets and places with a good choice of restaurants (and the odd cafe / bar) now I can't. It makes the map far less informative and I suspect the perceived improvement is most obvious to those working with Carto most closely. It is important to show how such rendering rule changes affect the appearance of other less dense areas of the map: at a minimum small towns, villages and hamlets as well as isolated restaurants/bars/cafes/pubs. |
Just to be clear: you find it difficult (or impossible) to tell apart the brown and pink dots/squares? |
This is another urban/rural issue (see #1957). Whether or not it makes sense in urban areas, it's a clear loss of utility in rural areas: http://www.openstreetmap.org/#map=17/51.81633/-1.70480 FWIW, cycle.travel renders pubs/cafe icons at z13 in rural areas, z16 in towns, z17 in cities (names come in later). |
@systemed - what data do you base this selection on? |
Urban area polygons from OS Open Data in the UK, CORINE in mainland Europe, TIGER in the US, and equivalents (which I can't remember off the top of my head) for Canada and Mexico. They're all of pretty good quality apart from CORINE. For openstreetmap-carto it would be more appropriate to generate any such polygons from OSM data, of course. |
@math1985 I can just about discriminate them if I take my specs off and squint really closely at the screen; but this indoors with reasonable lighting etc. I would imagine the difference would be much harder on a mobile device in bright sunlight. @systemed et al. I currently have draft urban areas on github for the following areas : Australasia & Oceana, Africa, South America, North America. I can generate them for Central America and Europe, but I had issues with my algorithm in Japan which complicated generating an Asia dataset. Everything is derived directly from OSM and is stored as Geojson files to allow visualisation of the data (and, perhaps more importantly, diffs between versions). Data are partitioned into either 5 or 10 degree squares to ensure no file is too large for github. The repository is : https://github.com/SK53/ua2/. |
Please move the discussions about urban areas to #1957, since it's an important problem on its own. |
I am not in favor of this change, as it makes the map less useful, clearly
in less dense areas (outskirts, rural, etc.) but also in very dense central
areas. I agree that this place before was kind of cluttered and is less so
now, but while the icons gave me some idea before what to expect before,
the dots don't any more. I have no problem in distinguishing those 2 colors
if I concentrate on them, but the overall picture is less clear now, mostly
a sea of dots (where no color or structure eveloves).
It is important to know whether a place is a restaurant or a pub/café, and
by reducing this to a dot you loose this distinction until you zoom to
quite high levels.
|
I think the criticism makes sense, I'm going to close this PR. |
This prevents overcrowding on z17.
Before:
After: