Fix SQL problem with some PostGre versions #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm that it still works on my setup. |
pnorman
reviewed
Oct 9, 2017
| @@ -2180,7 +2180,7 @@ Layer: | |||
| tags->'addr:unit' AS addr_unit, | |||
| way_area/NULLIF(!pixel_width!::real*!pixel_height!::real,0) AS way_pixels | |||
| FROM planet_osm_polygon | |||
| WHERE (("addr:housenumber" IS NOT NULL) OR ("addr:housename" IS NOT NULL) OR (tags->'addr:unit' IS NOT NULL)) | |||
| WHERE (("addr:housenumber" IS NOT NULL) OR ("addr:housename" IS NOT NULL) OR ((tags->'addr:unit') IS NOT NULL)) | |||
There was a problem hiding this comment.
This should be OR NOT tags ? 'addr:unit'
There was a problem hiding this comment.
As I do not fully understand the syntax, I would prefer if someone else could do this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2886 and I suppose addition parenthesis won’t make any harm on other PostGre versions or setups.