Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Place names for place areas #2804

Closed
wants to merge 2 commits into from

Conversation

stevenLAD
Copy link

@stevenLAD stevenLAD commented Sep 3, 2017

Create place names for places that are defined as place areas

Replaces pull #2800

stevenLAD added 2 commits September 3, 2017 13:17
Create features and text-polys to use in shading and naming places that
are defined as areas.

Replaces Pull 2800 which did not create features.

Subsequent Pulls in new branches will implement these features
Create place names for places that are defined as place areas

Replaces pull 2800
@lukaszkruk
Copy link

Do I understand correctly this only does it for villages and hamlets? How about cities, towns, neighbourhoods and others?

Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to do what it says. This renders village and hamlet polygons like residential areas, and not like villages and hamlets.

@stevenLAD
Copy link
Author

You are correct. If this pull had been approved and merger, the rendering should have been then changed to comply with Place name rendering. This was an attempt to go in small steps so as not to be rejected "because too much at a time"

@stevenLAD
Copy link
Author

This request was a proof of concept - by doing only for villages and hamlets, it minimised potential conflicts with place node names. In these smaller areas, these conflicts would be easily identifiable and rectifiable by contributors. This was described in the pull that created the objects.

@lukaszkruk
Copy link

@pnorman by 'renders village and hamlet polygons like residential areas' do you mean it shades areas tagged as place but does not render labels from the name tag?

apologies, my understanding is not good enough yet to figure this out myself.

@pnorman
Copy link
Collaborator

pnorman commented Sep 9, 2017

@pnorman by 'renders village and hamlet polygons like residential areas' do you mean it shades areas tagged as place but does not render labels from the name tag?

There's nothing in the PR text about village and hamlet polygons like residential areas, yet that's what it does.

@matkoniecz
Copy link
Contributor

There's nothing in the PR text about village and hamlet polygons like residential areas, yet that's what it does.

And it is not explained why it would be a good idea, given that villages and hamlets include also nonresidential areas.

Also - what about cities, towns, neighbourhoods and others?

You are welcomed to open a PR with labels for places tagged on areas. Opening a PR similar to this one would require a really good and convincing explanation why places tagged as ares should be rendered as landuse=residential

@matkoniecz matkoniecz closed this Nov 2, 2017
@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 2, 2017

You are welcomed to open a PR with labels for places tagged on areas

Note that #2816 may be already implementing what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants