-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leaf type rendering with slightly bigger symbols and switch forest patterns to 256 px #2747
Conversation
Same pattern for all leaf types, only the symbols change. |
Should easily allow later for both, leaf cycle rendering by filling or half-filling the symbol, and also for leaf cycle rendering by changing the color of the symbol. But that’s not part of this PR… |
I like this solution. Could you also post some real live rendering? |
These are only unknown/needleleaved, but I'd like also to see mixed, broadleaved and leafless areas. Just one example per type would be enough. BTW - it would be interesting for me to see preliminary leaf cycle rendering with these symbols. |
I would keep leaf cycle rendering out of this PR, also because personally I do not plan to work on that. Anyway, there were basically two proposals for leaf cycle rendering: Either by changing the color of the symbol or by filling it. I think both options are compatible with this PR. |
Could leafless be weaker, to not stand out from the rest? With bigger size it could be probably possible without being hard to recognize. |
To compare: On the image:
|
Both |
That’s intentional. I wanted to provide all symbols that are not part of the standard jsdotpattern repository so that everybody has available all the necessary files to regenerate them. Also for broadleaved and needleleaved, the original symbol files are provided within this PR. |
Sorry, I missed that they are documented and reside in |
Good job in rendering |
This is basically the same as #2708. It resolves #822. Closes #2708.
The symbols for known leaf types are slightly bigger (2 px) than in #2708. That’s to make them more attractive (instead of more light) then the unknown-leaf-type-symbol).
The symbols are not simply scaled versions of the previous symbols, but are redesigned and pixel-aligned.