Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaf type rendering with slightly bigger symbols and switch forest patterns to 256 px #2747

Merged
merged 5 commits into from
Aug 18, 2017

Conversation

sommerluk
Copy link
Collaborator

@sommerluk sommerluk commented Aug 14, 2017

This is basically the same as #2708. It resolves #822. Closes #2708.

The symbols for known leaf types are slightly bigger (2 px) than in #2708. That’s to make them more attractive (instead of more light) then the unknown-leaf-type-symbol).

The symbols are not simply scaled versions of the previous symbols, but are redesigned and pixel-aligned.

@sommerluk sommerluk mentioned this pull request Aug 14, 2017
@sommerluk
Copy link
Collaborator Author

screenshot 1

@sommerluk
Copy link
Collaborator Author

Same pattern for all leaf types, only the symbols change.

@sommerluk
Copy link
Collaborator Author

Should easily allow later for both, leaf cycle rendering by filling or half-filling the symbol, and also for leaf cycle rendering by changing the color of the symbol. But that’s not part of this PR…

@kocio-pl
Copy link
Collaborator

I like this solution. Could you also post some real live rendering?

@sommerluk
Copy link
Collaborator Author

screenshot 2
screenshot 3
screenshot 4
screenshot 5
screenshot 6
screenshot 7

@kocio-pl
Copy link
Collaborator

These are only unknown/needleleaved, but I'd like also to see mixed, broadleaved and leafless areas. Just one example per type would be enough.

BTW - it would be interesting for me to see preliminary leaf cycle rendering with these symbols.

@sommerluk
Copy link
Collaborator Author

screenshot 1
screenshot 2
screenshot 3

@sommerluk
Copy link
Collaborator Author

BTW - it would be interesting for me to see preliminary leaf cycle rendering with these symbols.

I would keep leaf cycle rendering out of this PR, also because personally I do not plan to work on that. Anyway, there were basically two proposals for leaf cycle rendering: Either by changing the color of the symbol or by filling it. I think both options are compatible with this PR.

@kocio-pl
Copy link
Collaborator

Could leafless be weaker, to not stand out from the rest? With bigger size it could be probably possible without being hard to recognize.

@sommerluk
Copy link
Collaborator Author

screenshot 1

@sommerluk
Copy link
Collaborator Author

To compare: On the image:

  • right below: broadleaved
  • left below: unknown
  • top: leafless

@sommerluk
Copy link
Collaborator Author

Switching to 256 px:

screenshot 1

@sommerluk sommerluk changed the title leaf type rendering – work on symbols leaf type rendering with slightly bigger symbols and switch forest patterns to 256 px Aug 15, 2017
@kocio-pl
Copy link
Collaborator

Both leafless1.svg and leafless2.svg are probably leftovers which should be deleted.

@sommerluk
Copy link
Collaborator Author

Both leafless1.svg and leafless2.svg are probably leftovers which should be deleted.

That’s intentional. I wanted to provide all symbols that are not part of the standard jsdotpattern repository so that everybody has available all the necessary files to regenerate them. Also for broadleaved and needleleaved, the original symbol files are provided within this PR.

@kocio-pl
Copy link
Collaborator

Sorry, I missed that they are documented and reside in generating_patterns!

@kocio-pl kocio-pl merged commit 4bd350f into gravitystorm:master Aug 18, 2017
@sommerluk sommerluk deleted the leavetype02 branch August 19, 2017 06:42
@nebulon42
Copy link
Contributor

Good job in rendering leaf_type. Much needed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish deciduous and coniferous forests
3 participants