Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pattern for natural=sand #2746

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Conversation

kocio-pl
Copy link
Collaborator

Irregular wave pattern for natural=sand would make it visibly different from farmland (and also from beach). Initial pattern shape and color are just proof of concept.

Egypt
z10
kodjovdw
z13
wp6p8xfm

@matthijsmelissen
Copy link
Collaborator

To me the wave patten symbolizes water, I wouldn't be in favour.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 15, 2017

Any other ideas how could sand waves/dunes look like?

I have more general ideas to tinker with:

  1. Maybe natural sand should use a random pattern we use for beach now and beach could use regular one instead.
  2. Maybe both should look the same (including pattern or not).
  3. Maybe farmland should have some (regular) pattern.

There's not too many places where both landuses are next to each other, but they do exist:

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting for administration's sake only: wave pattern does not work for me.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 4, 2017

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 4, 2017

It would look like this (OsmAnd has more restrictive licence, so we could ask for relicencing or just create something similar):

x7nch5pb

@dieterdreist
Copy link

dieterdreist commented Sep 4, 2017 via email

@kocio-pl kocio-pl changed the title Adding wave pattern for natural=sand [WIP] Adding pattern for natural=sand [WIP] Sep 4, 2017
@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 4, 2017

I guess the easiest and the most coherent way would be to just use the same pattern as sandy beach. General beach and farmland would be plain, sandy beach and natural=sand would be covered with sand pattern then, so we have the system and we can recognize all of them. The only problem I see is if current sand pattern is not too light in general - it's hard to spot the dots for me:

natural=sand at z19:
Before
nhjirmpv
After
xoij65uq

natural=sand and landuse=farmland at z19:
Before
lfq3k0jn
After
gndxp_yj

natural=sand and landuse=farmland in Israel (midzoom - click to see the full size):
z9
Before
rogvh9yb
After
kvhrkeax

z10
Before
nwagh3fy
After
tjccvrvc

z11
Before
yi1jmiqi
After
khe4kpvq

z12
Before
msukwyke
After
2eqt_xab

Libya - landuse=farmland inside natural=sand

z11
Before
7e9p6xfa
After
y0k2styx

z12
Before
hhdoug r
After
tin20dlh

z13
Before
o9spj3t_
After
2bnfe_1m

@kocio-pl kocio-pl changed the title Adding pattern for natural=sand [WIP] Adding pattern for natural=sand Sep 4, 2017
@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Sep 9, 2017

Any comments or reviews? I think sand pattern may be improved later (like bigger or less grains), because it would also change how sandy beach looks like.

@Tomasz-W
Copy link

I like new rendering of sand areas, but why this change hasn't included beach areas too? Is it intentional?

@kocio-pl
Copy link
Collaborator Author

Yes, default beach has no overlay pattern, because the pattern depends on beach/shoal surface:

[natural = 'beach'],
[natural = 'shoal'] {
[surface = 'sand'] {
polygon-pattern-file: url('symbols/beach.png');
polygon-pattern-alignment: global;
}
[surface = 'gravel'],
[surface = 'fine_gravel'],
[surface = 'pebbles'],
[surface = 'pebblestone'],
[surface = 'shingle'],
[surface = 'stones'],
[surface = 'shells'] {
polygon-pattern-file: url('symbols/beach_coarse.png');
polygon-pattern-alignment: global;
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants