-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pattern for natural=sand #2746
Conversation
To me the wave patten symbolizes water, I wouldn't be in favour. |
Any other ideas how could sand waves/dunes look like? I have more general ideas to tinker with:
There's not too many places where both landuses are next to each other, but they do exist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting for administration's sake only: wave pattern does not work for me.
sent from a phone
On 4. Sep 2017, at 03:44, kocio-pl ***@***.***> wrote:
What about this pattern:
https://github.com/osmandapp/OsmAnd-resources/blob/master/icons/svg/shaders/h_sand_shader.svg
it's not completely bad, but a bit "heavy"/impactful. Could it become lighter somehow?
|
c25520d
to
9895af2
Compare
I guess the easiest and the most coherent way would be to just use the same pattern as sandy beach. General beach and farmland would be plain, sandy beach and natural=sand would be covered with sand pattern then, so we have the system and we can recognize all of them. The only problem I see is if current sand pattern is not too light in general - it's hard to spot the dots for me: natural=sand at z19: natural=sand and landuse=farmland at z19: natural=sand and landuse=farmland in Israel (midzoom - click to see the full size): |
Any comments or reviews? I think sand pattern may be improved later (like bigger or less grains), because it would also change how sandy beach looks like. |
I like new rendering of sand areas, but why this change hasn't included beach areas too? Is it intentional? |
Yes, default beach has no overlay pattern, because the pattern depends on beach/shoal surface: openstreetmap-carto/landcover.mss Lines 668 to 684 in 72f6c8d
|
Irregular wave pattern for natural=sand would make it visibly different from farmland (and also from beach). Initial pattern shape and color are just proof of concept.
Egypt


z10
z13