Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch scrub pattern to SVG #2684

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Conversation

kocio-pl
Copy link
Collaborator

Related to #2045.

Warsaw, z18
Before
srnso4r7
After
5ip vekk

@pnorman pnorman mentioned this pull request Jul 10, 2017
18 tasks
@imagico
Copy link
Collaborator

imagico commented Jul 10, 2017

What's with the offset in the samples?

@kocio-pl
Copy link
Collaborator Author

I don't know. It was just simple script operation, so it might be this (Inkscape including) or it's a Mapnik issue.

@kocio-pl
Copy link
Collaborator Author

I hope symbol shift is not an obstacle for you to merge it?

@imagico
Copy link
Collaborator

imagico commented Jul 14, 2017

I have not tested if a similar problem as with plant_nursery occurs here as well. In general i would assume that whatever mapnik does exactly, if it breaks periodicity in one case it likely also breaks it in other cases. But since the potential damage is not that big i don't think this is a big deal if it just happens for one pattern. I would however be against moving to SVG patterns at large without the ability to control how mapnik renders them at least on the same level as with PNGs.

@kocio-pl kocio-pl merged commit 4b2029e into gravitystorm:master Jul 16, 2017
@kocio-pl kocio-pl deleted the scrub-svg branch July 16, 2017 20:53
@kocio-pl
Copy link
Collaborator Author

I understand it as "OK, but let's think how to resolve general problem before we start with others". Sure, #2685 is waiting for the solution to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants