Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update (font usage and download) #2607

Merged
merged 2 commits into from
Apr 16, 2017

Conversation

sommerluk
Copy link
Collaborator

@sommerluk sommerluk commented Apr 9, 2017

Documentation update (font usage and download)

Resolves #2606

Copy link
Contributor

@nebulon42 nebulon42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition to the docs. Please also see my remarks.

INSTALL.md Outdated
DejaVu: http://dejavu-fonts.org/
Unifont: http://unifoundry.com/

### Download on Ubuntu/Debian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better "Installation"

INSTALL.md Outdated
Noto: http://www.google.com/get/noto/ and http://github.com/googlei18n?utf8=%E2%9C%93&q=noto
DejaVu: http://dejavu-fonts.org/
Unifont: http://unifoundry.com/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a sentence that you have to install those on your own.

INSTALL.md Outdated
@@ -43,11 +43,19 @@ The repeated www.naturalearthdata.com in the Natural Earth shapefiles is correct
Put these shapefiles at `path/to/openstreetmap-carto/data`.

## Fonts
The stylesheet uses Noto Sans, an openly licensed font from Google with support for multiple scripts. The "UI" version is used where available, with its vertical metrics which fit better with Latin text. Other fonts from the Noto family are used for some other languages.
The stylesheet uses Noto, an openly licensed font from Google with support for multiple scripts. The “UI” version is used where available, with its vertical metrics which fit better with Latin text. The stylesheet uses Noto’s “Sans” style where available. If not available, this stylesheet uses another appropriate style of the Noto family.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the changed quotation marks?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use straight quotes, not curly quotes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When referring to "Noto" instead of "Noto Sans" it should be called a "font family" instead of a "font". The information about Sans should come before the information about UI, as UI is a finer division than Sans.

INSTALL.md Outdated
@@ -43,11 +43,19 @@ The repeated www.naturalearthdata.com in the Natural Earth shapefiles is correct
Put these shapefiles at `path/to/openstreetmap-carto/data`.

## Fonts
The stylesheet uses Noto Sans, an openly licensed font from Google with support for multiple scripts. The "UI" version is used where available, with its vertical metrics which fit better with Latin text. Other fonts from the Noto family are used for some other languages.
The stylesheet uses Noto, an openly licensed font from Google with support for multiple scripts. The “UI” version is used where available, with its vertical metrics which fit better with Latin text. The stylesheet uses Noto’s “Sans” style where available. If not available, this stylesheet uses another appropriate style of the Noto family.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use straight quotes, not curly quotes.

INSTALL.md Outdated

DejaVu Sans is used as an optional fallback font for systems without Noto Sans. If all the Noto fonts are installed, it should never be used.

Unifont is used as a last resort fallback, with it's excellent coverage, common presence on machines, and ugly look.
Unifont is used as a last resort fallback, with it’s excellent coverage, common presence on machines, and ugly look.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes were changed here.

INSTALL.md Outdated
Unifont is used as a last resort fallback, with it's excellent coverage, common presence on machines, and ugly look.
Unifont is used as a last resort fallback, with it’s excellent coverage, common presence on machines, and ugly look.

### Download
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the manual download after information about installing from packages, which is a preferred installation method for most cases. Perhaps as "Download from source"

INSTALL.md Outdated

Noto: http://www.google.com/get/noto/ and http://github.com/googlei18n?utf8=%E2%9C%93&q=noto
DejaVu: http://dejavu-fonts.org/
Unifont: http://unifoundry.com/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be links with markdown, not a list of URLs.

INSTALL.md Outdated
@@ -43,11 +43,19 @@ The repeated www.naturalearthdata.com in the Natural Earth shapefiles is correct
Put these shapefiles at `path/to/openstreetmap-carto/data`.

## Fonts
The stylesheet uses Noto Sans, an openly licensed font from Google with support for multiple scripts. The "UI" version is used where available, with its vertical metrics which fit better with Latin text. Other fonts from the Noto family are used for some other languages.
The stylesheet uses Noto, an openly licensed font from Google with support for multiple scripts. The “UI” version is used where available, with its vertical metrics which fit better with Latin text. The stylesheet uses Noto’s “Sans” style where available. If not available, this stylesheet uses another appropriate style of the Noto family.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When referring to "Noto" instead of "Noto Sans" it should be called a "font family" instead of a "font". The information about Sans should come before the information about UI, as UI is a finer division than Sans.

@sommerluk
Copy link
Collaborator Author

Thanks for comments. All changes have been addressed.

@sommerluk
Copy link
Collaborator Author

Note however that the switch-back to the so-called “straight quotation marks” I’ve done rather reluctant. Switching to typographical quotation marks was not systematic; it’s just that I’m used to write this way. Both, U+0022 and U+0027 are the relicts of old typewriters, which were not able to have enough characters to represent all the typographically correct quotations marks and the apostrophe. In general, they should not be used as quotation marks or apostrophes. Unicode itself (in the character information for these two characters) says that the preferred characters for quotation marks and apostrophe are 201C, 201D and 2019.

All these three characters are part of Unicode since the very beginning, two and a half decades ago. After so much time, I don’t think it is necessary to stay ASCII-compatible anymore.

@pnorman pnorman merged commit 6f3c4b7 into gravitystorm:master Apr 16, 2017
@sommerluk sommerluk deleted the notodownloaddoc01 branch July 26, 2017 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants