Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing waterway=canal area rendering #2573

Merged

Conversation

imagico
Copy link
Collaborator

@imagico imagico commented Feb 19, 2017

fixes #2424.

Note this only removes the area rendering, correctly treating closed ways with waterway=canal as line features will depend on the database reload. Current lua branch already has this covered:

https://github.com/gravitystorm/openstreetmap-carto/blob/lua/openstreetmap-carto.lua#L40

@pnorman
Copy link
Collaborator

pnorman commented Feb 20, 2017

Current lua branch already has this covered:

https://github.com/gravitystorm/openstreetmap-carto/blob/lua/openstreetmap-carto.lua#L40

Not really. There's two different questions - when waterway=canal is an area, and rendering waterway=canal areas. Lua changes the first, this PR changes the second.

@imagico
Copy link
Collaborator Author

imagico commented Feb 20, 2017

This is exactly what i meant - right now this PR removes the incorrect rendering of closed way canals as areas and this will make sense also after the database changes but it does not make sure they are rendered correctly as line features since the geometries are still treated as polygons in the database.

@pnorman
Copy link
Collaborator

pnorman commented Feb 28, 2017

Looks good to me, but I haven't had a DB loaded to actually test.

@matthijsmelissen matthijsmelissen merged commit f9c77cf into gravitystorm:master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not render closed ways with waterway=canal as area
3 participants