Proper API version for CartoCSS #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnorman
requested changes
Dec 21, 2016
| * [Carto](https://github.com/mapbox/carto) >= 0.16.0 (we're using YAML) | ||
| * [Mapnik](https://github.com/mapnik/mapnik/wiki/Mapnik-Installation) 3.0 | ||
| * [CartoCSS](https://github.com/mapbox/carto) >= 0.16.0 (we're using YAML) | ||
| * [Mapnik](https://github.com/mapnik/mapnik/wiki/Mapnik-Installation) >= 3.0 |
There was a problem hiding this comment.
This should be kept at 3.0 because 3.1 can break backwards compatibility
There was a problem hiding this comment.
So can CartoCSS > 0.16.3 - you just never know.
There was a problem hiding this comment.
We could just mention "3.0.x" and "0.16.x", it would be pretty safe. ">=" statement is too general and pinning bugfix versions would be too strict, I guess.
| * [CartoCSS](https://github.com/mapbox/carto) >= 0.16.0 (we're using YAML) | ||
| * [Mapnik](https://github.com/mapnik/mapnik/wiki/Mapnik-Installation) >= 3.0 | ||
|
|
||
| Remember to run CartoCSS with proper API version to avoid errors (at least 3.0.0: `carto -a "3.0.0"`). |
There was a problem hiding this comment.
Should we specify an exact version, or at least 3.0.0?
There was a problem hiding this comment.
I'm not sure, but this should be stable for some time (should work with future CartoCSS versions), so we can specify exactly 3.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoletes #2521.
Enables #2470.
Instructions for compiling this style using CartoCSS.