remove text-min-distance - increase label density #2195

matkoniecz · 2016-06-23T21:51:20Z

This results in rendering more labels for placenames for renderers using Mapnik 2.

For renderers using Mapnik 3 this will have no effect (text-min-distance is applicable only to text placed on line).

This change is equivalent in effect to upgrading to Mapnik 3.

fixes #2189, related to #1935

According to my testing rendering more placenames results in much better/better map (in many cases), unchanged (most cases) or at least not worse (in rare cases).

Some examples with changes to lower zoom levels are at #2189 (comment)

Examples of changes to higher will be below.

Note that attached rendered examples were not generated with exactly the same code as submitted in PR (code included removal of text-line-spacing: 1; in for country names).

This results in rendering more labels for placenames for renderers using Mapnik 2. For renderers using Mapnik 3 this will have no effect (text-min-distance is applicable only to text placed on line). This change is equivalent in effect to upgrading to Mapnik 3. fixes #2189, related to #1935

matkoniecz · 2016-06-23T21:52:29Z

Note: above notes about Mapnik 2/3 may be untrue - see my confusion at #2189 and correction by @nebulon42.

pnorman · 2016-06-25T06:44:06Z

I'm not seeing many differences locally when comparing production and this branch - what types of areas would be good to review?

matkoniecz · 2016-06-25T09:06:24Z

I'm not seeing many differences locally when comparing production and this branch

What version of mapnik you are using? With mapnik 3.0 text-min-distance is anyway working only for lines. It is caused caused by redefining text-min-distance from mapnik 2.3 where it means

Minimum permitted distance to the next text symbolizer.

to

Minimum distance to the next label with the same text. Only works for line placement. Deprecated: replaced by text-repeat-distance and text-margin

In mapnik 3.0.

https://github.com/mapbox/carto/blob/master/docs/2.3.0.md#text-min-distance-float
https://github.com/mapbox/carto/blob/master/docs/3.0.0.md#text-min-distance-float

That is what I mean by "change is equivalent in effect to upgrading to Mapnik 3".

what types of areas would be good to review?

High density of placenames competing to be displayed with other labels. I see no obvious candidates in region where you edit. In USA effect should be most noticeable in regions like New York (many towns, cities). In Seattle effect is less pronounced as it is on higher latitude and density is lower.

matkoniecz mentioned this pull request Jun 24, 2016

larger labels for major cities on z7 #2197

Closed

matthijsmelissen merged commit 3b5ba78 into gravitystorm:master Jun 25, 2016

matkoniecz deleted the preempt_mapnik3 branch June 25, 2016 20:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove text-min-distance - increase label density #2195

remove text-min-distance - increase label density #2195

matkoniecz commented Jun 23, 2016

matkoniecz commented Jun 23, 2016 •

edited

Loading

pnorman commented Jun 25, 2016

matkoniecz commented Jun 25, 2016

remove text-min-distance - increase label density #2195

remove text-min-distance - increase label density #2195

Conversation

matkoniecz commented Jun 23, 2016

matkoniecz commented Jun 23, 2016 • edited Loading

pnorman commented Jun 25, 2016

matkoniecz commented Jun 25, 2016

matkoniecz commented Jun 23, 2016 •

edited

Loading