Make tertiary road yellowish #2078
Conversation
Maybe some of the places @Stalfur has been pointing out in his posts while discussing the new road colors?:
|
|
Looks good to me, at least in the screenshots. How does it look on/near school areas? I would also like to hear the opinion of @matkoniecz. |
|
Possible near school area to test http://www.openstreetmap.org/#map=17/64.10301/-21.89453 |
|
Changing the colours needs to include changing the scripts that generate highway colours |
|
Remember to click to see a real size of those pictures!
Lonely secondary for comparison (z13):
|
|
This is great. |
|
@pnorman I guess all our scripts need at least basic documentation - what is their purpose, who maintains them etc. For example it's completely not clear for me what generate_road_colours.py does (aside from printing some color numbers on the screen). It would be good to include simple comment inside the code and let the script print some informations when called without arguments. Nice README.md would be also useful here. Should we open separate issue for this? |
That would be a good idea. |
|
Tested this in Luxembourg, looks good as far as I'm concerned. @matkoniecz What do you think? |
|
With the current discussion in #2071 to use the campus-yellow more widely, it would be good to see a test of a tertiary road running across such a campus. |
|
Campuses have tertiary roads? |
|
Yes, for example here. Unfortunately there are too much other colours around to compare the colour contrast well enough. |
|
Thanks for the example! On a micro scale (where there are not too much other elements and the roads are probably wider) it looks good enough for me: If there are some not well micromapped examples I can test it too. |
|
Ok the hue is different enough, and the roads have their outlines, thus it works for me. |
|
Well, I see @math1985 merged this, and I think there will be quite some happy OSM'ers once it makes it into the rendering. |
|
Whoops, didn't intend to merge this yet! However everybody seems happy with it so I guess merging was fine. I will roll back the merge if somebody still comes with areas where this change is problematic. |
Yes, I think it will be fine, considering @kocio-pl's example renderings and responses here. This was already on a waiting list to be tackled anyway. Only question that remains is if @pnorman's remark below still needs attention?...:
and whether you also meant to merge?...: |
Because the changes will get done the next time someone repopulates the colours with the script, I think we need to roll it back |
|
I have no access to git right now, could somebody else roll it back? |
Done |
|
I've reopened the issue. I don't think there's a way to mark this as "unmerged". Unless there is some hidden option @kocio-pl can you please open a fresh PR? We can then discuss further the script changes that need to be made before merging again. |
|
I'd like to move road colours to their own file and have that entire file generated by the scripts - this would allow regeneration of the colours from the script without any copy/paste |
|
I can do a fresh PR, but it's a trivial one-liner and maybe we should wait until the script @pnorman is talking about is ready? |
The script already exists, what I was talking about would just make it easier to run. |
|
I meant "when it's done", but it can be also discussed and refined within the new PR scope, so I've opened it anyway. |
Resolves #1974.
Trivial patch with non-trivial consequences, please propose some testing places from different parts of the world to see. Some screenshot samples around Warsaw for the start (click to see the full resolution):
City with residential, secondary and parking areas:
City with school and hospital area around:
Outside the city with current (new) farmland color:
