Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing cave entry PNG icon with SVG version #2048

Merged
merged 1 commit into from
Feb 24, 2016

Conversation

kocio-pl
Copy link
Collaborator

Implements part of #1165.

Simple substitution of PNG, since I think it works good already:
95msry1s

@nebulon42
Copy link
Contributor

Is it? Looks more symmetrical, but good.

@nebulon42 nebulon42 mentioned this pull request Feb 16, 2016
66 tasks
@kocio-pl
Copy link
Collaborator Author

Well, I just recreated it with circles because from what I saw it was more or less circular, but didn't make any pixel peeping. =} I mean fast design copy, not exact shape.

@kocio-pl
Copy link
Collaborator Author

Looks like it's not about symmetry, but rather stretched up, so the other possible version could be something like this:
erdv96oi

@kocio-pl
Copy link
Collaborator Author

Oh, it's not that simple - under further inspection I think it is side-stretched, but at the same time overall "triangular" shape. I will try to recreate it later to see if it's better than shape based on a regular circle.

@HolgerJeromin
Copy link
Contributor

Is this no Sjjb icon where you can get the source?
But I am not sure if your current circle version is just as good as the original.

@kocio-pl
Copy link
Collaborator Author

I guess this is much better:
hbozgipz

and here is original SJJB icon reworked for comparison:
dmzukrsr

Which one do you prefer?

@daganzdaanda
Copy link

The second one tries to be naturalistic, but we usually have our icons clean and more abstract. So I favour the first one.

matkoniecz added a commit that referenced this pull request Feb 24, 2016
Replacing cave entry PNG icon with SVG version
@matkoniecz matkoniecz merged commit 342c55b into gravitystorm:master Feb 24, 2016
@kocio-pl kocio-pl deleted the cave-icon branch February 24, 2016 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants