-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing bus station PNG icon with SVG version #2047
Conversation
Nice, clear and lightweight. Just in comparison, the taxi icon appears much more massive, larger and darker. |
This is somewhat prone to be confused with two bus stops close to each other. Why not use the old concept, i.e. inverted color bus in a box? |
@imagico You're right, but since @nebulon42 didn't like it (see #1478 (comment)), I have tried something lighter, because mine and @daganzdaanda proposition was not ruled out (see #1478 (comment)). |
For me it works - we don't have to be such versatile as @nebulon42 tries with osmic. We could also make the bus station letters bigger than bus stop or just use bold. |
I like sloped roof and double bus - but it is based solely on this preview, without proper testing. |
I will definitely make more rendering tests - once we know what looks promising and what we don't like for some reasons. |
Cool idea. I like the double bus. Could you give a preview of Wilanowska with double bus? I'm not sure if it'd also work well if the individual bus stops in the bus station are tagged. |
I have to admit that the inverse version also doesn't look bad. For me at least the versions with the roof are possibly confused with bus garages or the like. Slightly OT: The main problem for me (really emphasised in the last preview) is still the absence of icon halos. I still can't really understand why they were rejected, this decision solely based on them taking up more space. If they are necessary for text readability, they should be also necessary for icons. |
I dislike the roof - these are bus stations, not bus garages, and many bus stations don't have roofs. |
+1 |
@pnorman Is it technically possible with osm-carto? I think it's not. At least when trying to make canvas white, it was treated like part of the icon and I got 14px blue square - but maybe I made some mistake: |
No roof please, and definitely no side walls (for the garage effect). Having seen the platform context I agree that the inverted is better than the double bus. If technically possible to avoid the transparency it would add clarity when the background is detailed. |
e974c46
to
086d85a
Compare
Of course you can just use a white shape over a blue rectangle. Then you would lose the ability to re-colour the icon in CartoCSS, though. But not a big deal. |
Yes, I think we're going to end up losing that for any multi-colour icon. |
Thanks, I totally forgot that we don't need to control colors with styling options! So which one bus shape we want to be used? This from a bus stop (a) or closer to the bus station from osmic (b)? I like b more, because it's more distinct and more consistent with osmic. I may rework them a bit, because inverted objects look a bit different (some details looks thicker, while the others start looking smaller), but the basic shape should be one of these (never mind the label on a): |
In b label seems to be more on the left than icon. Is it an optical illusion or real effect? |
I prefer a) because it is better recognizable as a bus, and it is more
consistent with the bus stops.
|
I think it is real, but it might be a manual placement in the mockup? Also in preference of the same symbol in bus stop and station, and a) looks more like a modern bus. |
I also see this label shift, but I don't know where is it coming from - for me it was just another Kosmtik export. But looks like all 3 bold+bigger font labels have this defect: |
The distance between icon and label also seems to be to small compared to the non-bold version. If all the letters would be capital, the icon would hit the label. |
I haven't touched the dy while looking for a general solution, but of course I will fine tune it now I know text labels for bus stations are better when enlarged. However there's another interesting problem I'd like to report: the icon uses transportation-icon color (#0092da), while text uses transportation-text color (#0066ff). We have it also for bus stops for example, but it's much less visible there. Do we really need two distinct colors for transportation related items? And what was the reason they were introduced, BTW? |
My guess is that the different colours are from a time where most of them were hardcoded and picked randomly in previous styles, while I have seen more hue analysis discussed here recently. #1624 had a comparison of some colour use. Since there is no area filled with the transportation colour, I think icon and label should be unified. |
I like the double bus in the very first version, the rounded inverted bus definately looks like a subway/tram/train to me. Thats also true for the other inverted icon suggestions. |
Unfortunately, it was already shown it's not working among bust stops: Inverted version seems to be good enough and is accepted by most participants. It also (especially c) version) resembles our current icon. |
086d85a
to
0b3eefb
Compare
I am not convinced that it is not working. This location makes clear what it is even without any bus station icon. How it looks at z16 where bus station icon is really important to make meaning clear? |
The shape of the inverted bus seems substantially different |
@matkoniecz It's better, since on z16 bus stops are rendered as squares, but still mix with them if they are too close (1) and are much less visible than metro or railway halt and stations (1 and 2, 3 is kind of special): Maybe we should start rendering bus station name earlier, like railway stations for example, but it should be on higher layer probably to be visible. |
After tests - I prefer current inverted icon over new SVG inverted icon. |
OK, so I will try to simply recreate it instead of using osmic icons as a base. |
Closing this for now as it's not mergeable in its current state. Feel free to update the PR (or create a new one) and I'll reopen it again! |
OK, I just got stuck a bit lately. |
No need to explain yourself, I was just in a mood for tidying up :) |
Implements part of #1165.
Design according to discussion in #1478 (some bus stops around to compare):