Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing bus station PNG icon with SVG version #2047

Closed
wants to merge 1 commit into from

Conversation

kocio-pl
Copy link
Collaborator

Implements part of #1165.

Design according to discussion in #1478 (some bus stops around to compare):
tpjsb51q

@polarbearing
Copy link
Contributor

Nice, clear and lightweight.

Just in comparison, the taxi icon appears much more massive, larger and darker.

@imagico
Copy link
Collaborator

imagico commented Feb 16, 2016

This is somewhat prone to be confused with two bus stops close to each other.

Why not use the old concept, i.e. inverted color bus in a box?

@kocio-pl
Copy link
Collaborator Author

@imagico You're right, but since @nebulon42 didn't like it (see #1478 (comment)), I have tried something lighter, because mine and @daganzdaanda proposition was not ruled out (see #1478 (comment)).

@kocio-pl
Copy link
Collaborator Author

We can also use some different designs with roof, as it was not tested yet (only proposed with rough sketch):
0xhupcf
oh6dreln
x3o41_ci

@kocio-pl
Copy link
Collaborator Author

Inversion test:
4rt_w0mq
ovstuyjp

For me it works - we don't have to be such versatile as @nebulon42 tries with osmic.

We could also make the bus station letters bigger than bus stop or just use bold.

@matkoniecz
Copy link
Contributor

I like sloped roof and double bus - but it is based solely on this preview, without proper testing.

@kocio-pl
Copy link
Collaborator Author

I will definitely make more rendering tests - once we know what looks promising and what we don't like for some reasons.

@matthijsmelissen
Copy link
Collaborator

Cool idea. I like the double bus.

Could you give a preview of Wilanowska with double bus? I'm not sure if it'd also work well if the individual bus stops in the bus station are tagged.

@nebulon42
Copy link
Contributor

I have to admit that the inverse version also doesn't look bad. For me at least the versions with the roof are possibly confused with bus garages or the like.

Slightly OT: The main problem for me (really emphasised in the last preview) is still the absence of icon halos. I still can't really understand why they were rejected, this decision solely based on them taking up more space. If they are necessary for text readability, they should be also necessary for icons.

@pnorman
Copy link
Collaborator

pnorman commented Feb 16, 2016

Of the options, I prefer image the most so far.

If we go for an inversion like image I think we should have the bus in solid white.

@gravitystorm
Copy link
Owner

I dislike the roof - these are bus stations, not bus garages, and many bus stations don't have roofs.

@matthijsmelissen
Copy link
Collaborator

I dislike the roof - these are bus stations, not bus garages, and many bus stations don't have roofs.

+1

@kocio-pl
Copy link
Collaborator Author

@math1985 For me the difference between both types is too small:
kprrqpd2
vqxx0oiq

@kocio-pl
Copy link
Collaborator Author

@pnorman Is it technically possible with osm-carto? I think it's not. At least when trying to make canvas white, it was treated like part of the icon and I got 14px blue square - but maybe I made some mistake:
owztqzwd

@kocio-pl
Copy link
Collaborator Author

So it looks like roofs are in defeat and inversion gains some approval by everybody. With font +1 and bold it looks OK for me, but still kind of light (!) on lower zoom levels:
z17:
acx9vno
z18:
nxbopy3l

Text visibility seems to be important to help bus station icon to be noticed among bus stops, even in micro scale (z18):
z17:
vaso58rl
z18:
_60atfjq

@nebulon42 nebulon42 mentioned this pull request Feb 16, 2016
66 tasks
@polarbearing
Copy link
Contributor

No roof please, and definitely no side walls (for the garage effect). Having seen the platform context I agree that the inverted is better than the double bus. If technically possible to avoid the transparency it would add clarity when the background is detailed.

@kocio-pl
Copy link
Collaborator Author

No roofs and walls and no double buses (sadly it didn't work as good as I expected) - that's for sure. =} Now we're trying to polish inverted version.

Here is design resembling more bus station icon from osmic, because now it has more solid blue and less opaque area, which causes problems on busy backgrounds:

Wilanowska, z17
dajjvhu6
Wilanowska, z18
rbsx4hni
Marymont, z17
kfb_vfmx
Marymont, z18
kv5kwjrj
Zachodni, z16
aa1xzof5
Zachodni, z17
oxjzdk9l

I think it works quite good, so I updated this PR.

If somebody know if we can change transparent area into white, let me know (I think we can't).

I'd also like to know if we should try to push bus station text label to be rendered on top of bus stop icons (and how)?

@nebulon42
Copy link
Contributor

Of course you can just use a white shape over a blue rectangle. Then you would lose the ability to re-colour the icon in CartoCSS, though. But not a big deal.

@pnorman
Copy link
Collaborator

pnorman commented Feb 17, 2016

Then you would lose the ability to re-colour the icon in CartoCSS, though.

Yes, I think we're going to end up losing that for any multi-colour icon.

@kocio-pl
Copy link
Collaborator Author

Thanks, I totally forgot that we don't need to control colors with styling options!

So which one bus shape we want to be used? This from a bus stop (a) or closer to the bus station from osmic (b)? I like b more, because it's more distinct and more consistent with osmic. I may rework them a bit, because inverted objects look a bit different (some details looks thicker, while the others start looking smaller), but the basic shape should be one of these (never mind the label on a):

a)
4rt_w0mq
b)
oxjzdk9l

@matkoniecz
Copy link
Contributor

In b label seems to be more on the left than icon. Is it an optical illusion or real effect?

@dieterdreist
Copy link

dieterdreist commented Feb 17, 2016 via email

@polarbearing
Copy link
Contributor

Is it an optical illusion or real effect?

I think it is real, but it might be a manual placement in the mockup?

Also in preference of the same symbol in bus stop and station, and a) looks more like a modern bus.

@kocio-pl
Copy link
Collaborator Author

I also see this label shift, but I don't know where is it coming from - for me it was just another Kosmtik export. But looks like all 3 bold+bigger font labels have this defect:

#2047 (comment)

@mboeringa
Copy link

The distance between icon and label also seems to be to small compared to the non-bold version. If all the letters would be capital, the icon would hit the label.

@kocio-pl
Copy link
Collaborator Author

I haven't touched the dy while looking for a general solution, but of course I will fine tune it now I know text labels for bus stations are better when enlarged.

However there's another interesting problem I'd like to report: the icon uses transportation-icon color (#0092da), while text uses transportation-text color (#0066ff). We have it also for bus stops for example, but it's much less visible there. Do we really need two distinct colors for transportation related items? And what was the reason they were introduced, BTW?

@polarbearing
Copy link
Contributor

My guess is that the different colours are from a time where most of them were hardcoded and picked randomly in previous styles, while I have seen more hue analysis discussed here recently. #1624 had a comparison of some colour use. Since there is no area filled with the transportation colour, I think icon and label should be unified.

@kocio-pl
Copy link
Collaborator Author

There can be also c) - directly rebuild from osmic version - and I like it the most, because it's easier to recognize, since the white shape is bold:
2qownp2k

Marymont
z17
gjpupl1v
z18
wlsplf8d
z19
8cxa4h h

Wilanowska
z17
ki6gwnnl
z18
ikbrvvh_
z19
ocnvwo9y

@gormo-osm
Copy link

I like the double bus in the very first version, the rounded inverted bus definately looks like a subway/tram/train to me. Thats also true for the other inverted icon suggestions.

@kocio-pl
Copy link
Collaborator Author

Unfortunately, it was already shown it's not working among bust stops:
#2047 (comment)

Inverted version seems to be good enough and is accepted by most participants.

It also (especially c) version) resembles our current icon.

@matkoniecz
Copy link
Contributor

Unfortunately, it was already shown it's not working among bust stops:

I am not convinced that it is not working. This location makes clear what it is even without any bus station icon. How it looks at z16 where bus station icon is really important to make meaning clear?

@pnorman
Copy link
Collaborator

pnorman commented Feb 24, 2016

The shape of the inverted bus seems substantially different

@kocio-pl
Copy link
Collaborator Author

@matkoniecz It's better, since on z16 bus stops are rendered as squares, but still mix with them if they are too close (1) and are much less visible than metro or railway halt and stations (1 and 2, 3 is kind of special):
1)
f3hbperl
2)
fxwtu2dg
3)
fqj8nqk7

Maybe we should start rendering bus station name earlier, like railway stations for example, but it should be on higher layer probably to be visible.

@matkoniecz
Copy link
Contributor

After tests - I prefer current inverted icon over new SVG inverted icon.

@kocio-pl
Copy link
Collaborator Author

OK, so I will try to simply recreate it instead of using osmic icons as a base.

@matthijsmelissen
Copy link
Collaborator

Closing this for now as it's not mergeable in its current state. Feel free to update the PR (or create a new one) and I'll reopen it again!

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Mar 7, 2016

OK, I just got stuck a bit lately.

@matthijsmelissen
Copy link
Collaborator

No need to explain yourself, I was just in a mood for tidying up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.