Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shelter icon to SVG #2042

Merged
merged 1 commit into from
Feb 24, 2016
Merged

Conversation

kocio-pl
Copy link
Collaborator

Implements part of #1165.

Simple vector replacement of a raster shelter icon:

pd1siftw

@pnorman
Copy link
Collaborator

pnorman commented Feb 11, 2016

We use name.size.ext more than name-size.ext, so let's move to that at the same time.

@kocio-pl
Copy link
Collaborator Author

IIRC all my icons was made like this - probably looking at some @nebulon42 files, I guess. I was never sure, because we have both formats mixed, but I had more serious problems, so never touched it. If we decide to make them all the same, it probably deserves its own cosmetic patch.

@kocio-pl
Copy link
Collaborator Author

Just a cosmetic change so the icon looks better when enlarged (probably not visible on osm-carto):
oixnkvog

@nebulon42
Copy link
Contributor

While you're at it, I would suggest removing the rain as it just adds unnecessary clutter IMO.

@imagico
Copy link
Collaborator

imagico commented Feb 11, 2016

I think the rain is important to indicate the function, otherwise it is just some kind of building.

@HolgerJeromin
Copy link
Contributor

I would keep the rain, too.

@kocio-pl
Copy link
Collaborator Author

I was thinking about it too and came to the conclusion that otherwise it's not clear what type of building/roof is this. I like it more with rain.

@pnorman
Copy link
Collaborator

pnorman commented Feb 12, 2016

I like the rain, even though the clarity isn't perfect, mis-interpreting it is still likely to get the idea of sheltering across.

@nebulon42 nebulon42 mentioned this pull request Feb 16, 2016
66 tasks
matkoniecz added a commit that referenced this pull request Feb 24, 2016
@matkoniecz matkoniecz merged commit 342a13b into gravitystorm:master Feb 24, 2016
@kocio-pl kocio-pl deleted the shelter-svg branch February 24, 2016 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants