Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render tracks as solid line on z13, z14 - fixes #1591 #1837

Closed
wants to merge 1 commit into from
Closed

render tracks as solid line on z13, z14 - fixes #1591 #1837

wants to merge 1 commit into from

Conversation

matkoniecz
Copy link
Contributor

idea by @imagico
start using @track-grade[12]-width-z15
@imagico
Copy link
Collaborator

imagico commented Sep 15, 2015

That is slightly thicker than in my example (which used line-width 0.25) which probably means it will appear stronger than highway=service on dark backgrounds at z13 - see example on #1591 (comment) at the bottom right. Maybe using a smaller width at z13 than at z14 would be a good idea - this would also weaken the abrupt change in appearance between z12 and z13.

In principle the same idea could also work on footway/cycleways - see #1748, but this will not really be feasible without solving the color issues first - see also #1765 (comment)

@matkoniecz matkoniecz self-assigned this Sep 15, 2015
@matthijsmelissen
Copy link
Collaborator

I like the way the new z13/z14 look, but I don't like the user experience when zooming from z14 to z15. What used to be a solid line (which gives a relatively important impression) suddenly becomes a dashed, much less important line. It gives the feeling that what looks to be a nice paved road from far away suddenly becomes a muddy track when having a closer look. I'd be inclined to reject this PR.

@imagico
Copy link
Collaborator

imagico commented Sep 17, 2015

I think this is an inevitable consequence of less differentiated rendering at lower zooms. We are very used to the primary measure of data reduction at low zooms being the omission of features but in principle unifying different renderings is a proven technique as well and this always leads to emphasizing some things and weakening others. IMO there is nothing wrong with that.

Two things could be considered though:

  • generally making the lines weaker/thinner (i already suggested that)
  • using slightly different colors depending on track grade. The idea is creating a kind of color mixture between the track line color and the casing color (which dominates the higher track grades at the higher zooms). Keeping the tracks well visible at z14 and avoiding a reduction in visual strength from z14 to z15 at the same time will hardly be possible though.

@matkoniecz
Copy link
Contributor Author

Also, not rendering grade5, grade4 tracktypes at z13, z14 would be weird with rendering footways at the same time.

@kocio-pl
Copy link
Collaborator

I think @imagico has a point: it's nice to be consistent, but not at all cost. Look at the airport: it's a plane icon on lower zoom, which disappears on higher zoom levels and instead there are some violet areas. Or the trees which are just a green points which become brown dots with green circle around. So we have examples of different rendering on different zoom levels and I think this is a valid solution.

@matkoniecz matkoniecz closed this Sep 20, 2015
@imagico
Copy link
Collaborator

imagico commented Sep 20, 2015

Does this mean the general idea of rendering tracks without dashing at the lower zooms is rejected?

@matkoniecz
Copy link
Contributor Author

No, though it would be necessary to address problems mentioned here (track vs service, probably less wide track for grade5, grade4).

I am not entirely sure whatever it will work.

@matkoniecz matkoniecz deleted the track branch March 7, 2016 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants