Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make railway=tram with service tags less visible, fixes #1531 #1676

Merged
merged 2 commits into from
Jul 28, 2015
Merged

make railway=tram with service tags less visible, fixes #1531 #1676

merged 2 commits into from
Jul 28, 2015

Conversation

@kocio-pl
Copy link
Collaborator

I think z14 is better to start show them than z16 (although not as strong as we have now, that's sure - your proposition of lighter color is good probably). At this zoom level it's interesting to know what type of industrial area is it exactly, because it's not competing for user's attention anymore. Even in big city typical "quarter" (between suburb and neighbourhood) doesn't have more important industrial structures, so it makes sense to show they are dominant here.

@matkoniecz
Copy link
Contributor Author

The problem with showing it earlier is formation of blob with merging tracks (even with really narrow lines).

Also, z14 is IMHO too early - at least structures that I found seem to not be important enough to be prominently displayed so early (and dark blob will be prominent, at least I have no good ideas how to avoid this).

z15 would make sense and that was planned zoom level of appearance but I failed to find display that would not be bad.

Overall, I think that z16 is reasonable.

@kocio-pl
Copy link
Collaborator

I think a lighter "blob" doesn't hurt, because one doesn't have to see the separate tracks, just the impression that there are a lot of them. Could you show one such example at z14 and z15 (probably one of those you have just rendered here)?

@kocio-pl
Copy link
Collaborator

At z14 Crich is too dark and Cracow is good, but maybe still too distracting for someone tracking the roads (clustering makes color stronger). At z15 both are really good for me and doesn't disturb me, so I prefer starting to show them from that level.

@kocio-pl
Copy link
Collaborator

I have no problems with this new batch of examples. You're quick, BTW! 😄

@ximex
Copy link

ximex commented Jul 23, 2015

z15 looks good. z14 is to early. gread job 👍

@matkoniecz
Copy link
Contributor Author

After looking at these examples again I am convinced that showing it at z15 is a good idea.

@matthijsmelissen
Copy link
Collaborator

Looks good!

The zoom level for the labels needs also to be adapted - see Crich z15.

@matkoniecz
Copy link
Contributor Author

@math1985

Crich at z15 is tricky (I had the same reaction) - this place has ways mapped as [railway=tram; service=yard; highway=pedestrian; name=foobar]. Pedestrian and its name is rendered at z15.

See for example http://www.openstreetmap.org/way/151290712#map=19/53.09051/-1.48585

Names of railway tracks are currently not rendered anywhere.

@ppawel
Copy link

ppawel commented Jul 27, 2015

I love these changes!

@matthijsmelissen
Copy link
Collaborator

this place has ways mapped as [railway=tram; service=yard; highway=pedestrian; name=foobar].

Sorry, I missed that it was also tagged as highway.

@matthijsmelissen matthijsmelissen merged commit f855648 into gravitystorm:master Jul 28, 2015
@matkoniecz matkoniecz deleted the tram-service branch July 28, 2015 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants