Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move emergency phone to SVG #1606

Merged
merged 1 commit into from
Jul 6, 2015

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.

before
sos_before

after
sos_after

@nebulon42 nebulon42 mentioned this pull request Jun 9, 2015
66 tasks
@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 9, 2015

Less visible (that may be what we want - to see such items but not eclipse more typical elements), but for me as good as current.

@daganzdaanda
Copy link

I like how clear the SOS reads. As with "phone", I think the gap isn't really necessary.
Should we define a common colour for all "emergency" icons?

@nebulon42
Copy link
Contributor Author

Should we define a common colour for all "emergency" icons?

That should be discussed seperately. But could be an idea to pursue.

@nebulon42 nebulon42 force-pushed the svg-emergency-phone branch from 618b0ec to 49949a1 Compare July 5, 2015 13:48
@nebulon42
Copy link
Contributor Author

Rebased and ready for review/merge I think.

matkoniecz added a commit that referenced this pull request Jul 6, 2015
@matkoniecz matkoniecz merged commit a0cb447 into gravitystorm:master Jul 6, 2015
@matkoniecz
Copy link
Contributor

Thanks for the new icon!

@nebulon42 nebulon42 deleted the svg-emergency-phone branch July 7, 2015 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants