Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move windmill to SVG #1574

Merged
merged 1 commit into from
Jun 23, 2015
Merged

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.

before
windmill_before

after
windmill

@nebulon42 nebulon42 mentioned this pull request May 23, 2015
66 tasks
@kocio-pl
Copy link
Collaborator

I would cut a triangle's corners on the bottom, so it has two vertical borders (that would be pentagon than, to be strict).

@matthijsmelissen
Copy link
Collaborator

I think it might look better without the small element between the top wings. Could you try how it looks like that?

@nebulon42
Copy link
Contributor Author

I'm not sure if it looks better, but it is definitely problematic at bigger sizes. Here is the preview:
windmill_2

I have cut the triangle at the bottom.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 1, 2015

I would make the cut more visible, like this:
windmill-16-1

@pnorman
Copy link
Collaborator

pnorman commented Jun 3, 2015

I'd prefer no triangle in the top, cut off the bottom corners

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 3, 2015

Very small element on top is acceptable? It would make SVG better and IMO doesn't spoil the shape:
windmill-16-2

@pnorman
Copy link
Collaborator

pnorman commented Jun 3, 2015

At the target size for the icons, I don't think it ever makes sense

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 3, 2015

I like it even with this size, because it suggests the building behind (so is less sketchy or abstract), but if it just doesn't hurt, it's better to keep SVG nice, because the icon might be rasterized one day for more pixels (for example on client's system, not on the server).

@nebulon42
Copy link
Contributor Author

I made the top part smaller and the lower part a bit less wide. I'm not able to remove the top part completely because that wouldn't look good at bigger sizes. I do not want to make it less wide at the bottom because the tower should become narrower at the top.

@daganzdaanda
Copy link

I would prefer the topless one from #1574 (comment) It's not bad that a symbol looks reduced, IMHO.
Just for reference: https://de.wikipedia.org/wiki/Datei:Map_symbol_windmill.svg

@matthijsmelissen matthijsmelissen merged commit bda113c into gravitystorm:master Jun 23, 2015
@nebulon42 nebulon42 deleted the svg-windmill branch June 24, 2015 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants