Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change symbol for railway=subway_entrance #1521

Merged
merged 1 commit into from
Jul 10, 2015

Conversation

nebulon42
Copy link
Contributor

Fixes #851, implements part of #1165.

before (click on images to see full preview)
subway_entrance_before

after
subway_entrance

issues:
subway entrances that are elevators are depicted with stairs (see http://www.openstreetmap.org/node/2703842678)

@nebulon42 nebulon42 mentioned this pull request May 4, 2015
66 tasks
@matkoniecz
Copy link
Contributor

Neither old nor new symbol works for me. Old one is clearly somebody walking what is not helpful and not representing anything. New one is not looking like stairs (also at full sized image) - it is rectangle with line.

Maybe just stairs would work? Or arrow pointed toward bottom (I am not really convinced that this is a good idea)?

@daganzdaanda
Copy link

Could you show the new symbol in train-blue?
I think the idea works, if it is connected visually to other public transport features.
Or maybe it needs a filled rectangle to be more visible, or a tunnel-shape instead of a rectangle?

Maybe just stairs would work?

I've seen street signs where "stairs" stand for a pedestrian underpass. We probably don't need an icon for these, since we are rendering stairs and tunnels. So maybe it could work for subway entrance, too.

@nebulon42
Copy link
Contributor Author

@daganzdaanda See #851 (comment).

@nebulon42
Copy link
Contributor Author

@matkoniecz Right, the stairs are barely visible, but visible. I still think the proposed icon is an improvement. Other opinions/ideas?

point-placement: interior;
marker-file: url('symbols/subway_entrance.10.svg');
marker-placement: interior;
marker-fill: #555;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be transit blue

@kocio-pl
Copy link
Collaborator

Could we see how it looks now in blue on the map?

@nebulon42
Copy link
Contributor Author

Some color variations:

grey
subway_entrance_after

station color
subway_entrance_station_color

station text color
subway_entrance_station_text_color

transportation color
subway_entrance_transport_color

@kocio-pl
Copy link
Collaborator

I see your examples in this order:

  1. transportation (lighter than current, but still visible enough for this object - good for me)
  2. grey
  3. station
  4. station text (map looks too much like a blue-red tonal rainbow =} )

@nebulon42
Copy link
Contributor Author

Any other opinions on different colours?

@pnorman
Copy link
Collaborator

pnorman commented May 28, 2015

transportation colour.

@nebulon42
Copy link
Contributor Author

Alternatively we could use a generic entrance icon:
subway_entrance

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jun 1, 2015

Nice idea.

@nebulon42
Copy link
Contributor Author

I presented two options that would work more or less and are clearly improvements over the current icon. A decision on this would be great.

@matthijsmelissen
Copy link
Collaborator

I will get back to this as soon as possible.

@kocio-pl
Copy link
Collaborator

I think general entrance version is even better, since it's more clean and readable (which is important given it's smaller than most icons) and if we decide to render plain building entrances, they'll be probably black, so the distinction will be clear.

BTW: I think we can make elevator icon to be in the same style, just with arrows up and down.

@daganzdaanda
Copy link

Yeah, the general entrance with arrow is the better idea. The stairs are hard to decipher at that size and with the busy backgrounds. You probably already tried this, but maybe the arrow could point down 45° to symbolize entrance to the underground?

@kocio-pl
Copy link
Collaborator

Nice idea.

@matkoniecz
Copy link
Contributor

Generic entrance works better for me.

@nebulon42 nebulon42 force-pushed the svg-subway-entrace branch from 09ad3cd to 83a35f7 Compare July 5, 2015 13:42
@nebulon42
Copy link
Contributor Author

The consensus seems to be the generic entrance icon. Updated.
For other PRs that might want to use a generic entrance icon, it is now available.

@matthijsmelissen matthijsmelissen merged commit 83a35f7 into gravitystorm:master Jul 10, 2015
@nebulon42 nebulon42 deleted the svg-subway-entrace branch July 10, 2015 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change icon for railway=subway_entrance
6 participants