Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move caravan parking icon to SVG #1468

Merged
merged 1 commit into from
Apr 26, 2015
Merged

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.
Symbol is now smaller.

before
caravan_before

after
caravan_after

@nebulon42 nebulon42 mentioned this pull request Apr 1, 2015
66 tasks
@kocio-pl
Copy link
Collaborator

kocio-pl commented Apr 1, 2015

The shape is now much harder to recognize - could it be longer and more rectangle?

@mboeringa
Copy link

I am OK with it considering the restrictions on icon size, although it may indeed take a little bit more time to figure out what it is. But it is still recognizable, especially when combined with labelling and possible context (normal camping nearby) or a legend. People can get used to it I think.

@lest69
Copy link

lest69 commented Apr 2, 2015

I agree with @mboeringa. The existing one is more recognizable, but the proposed one is probably the best we can do with the limited space and should be okay in context.

@matthijsmelissen
Copy link
Collaborator

I'm not fully convinced the icon is recognizable enough.

For comparison, this is a non-pixel perfect 16x16px version of the old icon:

caravan

caravan_park 16

@matthijsmelissen
Copy link
Collaborator

I'm not fully convinced the icon is recognizable enough.

For comparison, this is a non-pixel perfect 16x16px version of the old icon:

caravan

The two icons side by side:
caravan_park 16 caravan

@nebulon42
Copy link
Contributor Author

The oblong shape is probably more recognisable. Updated.

@kocio-pl
Copy link
Collaborator

That was what I suggested and I like the result - +1.

@mboeringa
Copy link

The oblong shape is probably more recognisable. Updated.

Great.

pnorman added a commit that referenced this pull request Apr 26, 2015
move caravan parking icon to SVG
@pnorman pnorman merged commit 4bc495a into gravitystorm:master Apr 26, 2015
@nebulon42 nebulon42 deleted the svg-caravan branch April 27, 2015 18:20
@gmbo
Copy link

gmbo commented Jul 5, 2015

I mean, this symbol is incorrect because caravan_site is a parking space for campers. There caravans are not or rarely allowed.
it should be used there a symbol for campers to avoid errors when tagging and the mapping use.

caravan_site

Likewise, the tent symbolizing camp_site is not correct. There likely this caravan icon should be used. These general campsites are mostly used by caravans, as well as tents and campers are welcome.

camp_site

DE:ich meine, dieses Symbol ist falsch, da caravan_site einen Stellplatz für Wohnmobile darstellt. Dort sind Wohnwagen nicht oder nur selten erlaubt.
es sollte dort ein Symbol für Wohnmobile verwendet werden um Irrtümer beim Taggen und der Landkartenbenutzung zu vermeiden.

Ebenso ist das Zeltsymbol für camp_site nicht richtig. Dort sollte eher dieses Caravan-Icon genutzt werden. Diese allgemeinen Campingplätze werden hauptsächlich von Wohnwagen genutzt, aber auch Zelte sowie Wohnmobile sind hier willkommen.

File:Caravan_site.svg

@pnorman
Copy link
Collaborator

pnorman commented Jul 5, 2015

I mean, this symbol is incorrect because caravan_site is a parking space for campers. There caravans are not or rarely allowed.

Quoting from the Wiki,

A caravan site, caravan park or RV park is a place where people with caravans / motorhomes / recreational vehicles can stay overnight, or longer, in allotted spaces known as "pitches" or "sites".

Your view disagrees with the plain language meaning of caravan_site and the wiki documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants