Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lighthouse icon to SVG #1385

Merged
merged 1 commit into from
Mar 21, 2015

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.
Please note that the symbol is now smaller.

before
lighthouse_before

after
lighthouse_after_2

@nebulon42 nebulon42 mentioned this pull request Mar 14, 2015
66 tasks
@imagico
Copy link
Collaborator

imagico commented Mar 14, 2015

To me the light cones appear to be part of the structure and there seems to be a gap between the top and bottom part. This makes the whole thing less recognizable IMO.

@kocio-pl
Copy link
Collaborator

Another "too square" icon for me - and I would recognize it probably only in the right context (that should be less of a problem, since lighthouses are always near water I guess).

@pnorman
Copy link
Collaborator

pnorman commented Mar 15, 2015

I think it's better with a taller aspect ratio.

@nebulon42
Copy link
Contributor Author

Making it appear taller is no problem but for the light cones I see only the possibility of leaving them out completely lighthouse-183 or replacing them with another (more ugly?) variant lighthouse-184 or yet another variant lighthouse-185.

Using transparency for them is no option in my view.

@kocio-pl
Copy link
Collaborator

I strongly prefer 2, but I'd like to see all of them on the real map to be sure.

@matthijsmelissen
Copy link
Collaborator

I like the second option.

@nebulon42
Copy link
Contributor Author

That's how it looks on the map
lighthouse_after_2

Unfortunately it looks a bit ugly for larger sizes
lighthouse-184

@matthijsmelissen
Copy link
Collaborator

Both large and small look fine to me.

@kocio-pl
Copy link
Collaborator

+1

@mboeringa
Copy link

I am OK with the version in the last post (I also kind of liked the original one, although I can understand the objections of it being to abstract), however, maybe putting back the "lamp" in the icon, like in the old version, could improve recognizability even more for the last version.

@nebulon42
Copy link
Contributor Author

I have updated the rays of light as I have no better idea. @mboeringa I do not want to add the lamp to avoid that the upper part looks like an eye. I have experimented a bit with it and it is better to leave it out.

@mboeringa
Copy link

I have updated the rays of light as I have no better idea. @mboeringa I do not want to add the lamp to avoid that the upper part looks like an eye. I have experimented a bit with it and it is better to leave it out.

Fair enough, the final version looks fine to me...

matthijsmelissen added a commit that referenced this pull request Mar 21, 2015
@matthijsmelissen matthijsmelissen merged commit 769c473 into gravitystorm:master Mar 21, 2015
@nebulon42 nebulon42 deleted the svg-lighthouse branch March 21, 2015 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants