Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move car sharing icon to SVG #1283

Closed
wants to merge 1 commit into from

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.
Icon: nebulon42/osmic/shared-car-16.svg

before
car_sharing_before

after
car_sharing_after

@nebulon42 nebulon42 mentioned this pull request Feb 1, 2015
66 tasks
@matthijsmelissen
Copy link
Collaborator

Tester prefers first icon, because it's not clear that there are people in the new icon.

@nebulon42
Copy link
Contributor Author

I can offer this as quick variant: shared-car-16

@mboeringa
Copy link

I think I also prefer the "old" version. As @math1985 pointed out, the symbols for people don't work as such. I get the feeling they are actually cars, in a kind of perspective drawing similar to road-signs warning for traffic jams.

@matthijsmelissen
Copy link
Collaborator

Is there a way to make the bodies of the people taller? Maybe add one or a half pixel to the top and bottom of the bodies?

@matthijsmelissen
Copy link
Collaborator

Is there a way to make the bodies of the people taller? Maybe add one or a half pixel to the top and bottom of the bodies?

@nebulon42 Did you have the time to look at this?

@nebulon42
Copy link
Contributor Author

Not yet, sorry.

@nebulon42
Copy link
Contributor Author

I don't see the possibility of making the bodies higher, only of making the car lower. But this would mean breaking consistency with other car related icons.

Another thing which occured to me: The distinction between car rental and car sharing is fuzzy IMO. What was the rationale for having a distinct icon for that?

For bike rental and bike sharing (e.g. public city bikes that can be rented and brought back at/to several locations) we use the same icon. I think the situation with cars re distinction of renting/sharing is not so much different.

@brycenesbitt
Copy link

@nebulon42 car sharing and car rental are highly distinct. Car sharing are unattended locations: if you show up unannounced you can't do anything other than look at the vehicles.

Car rental companies on the other hand, will gladly take your credit card and driver's licence, and let you hire a car.

@brycenesbitt
Copy link

I prefer the old icon. The people are the crucial graphic element, not the car, for the car sharing case.

@nebulon42
Copy link
Contributor Author

I can offer the two variants (original post and #1283 (comment)). I have updated the PR with a variant with bigger heads. Please tell me if you consider to merge either version this version, otherwise I will close this.

@mboeringa
Copy link

Here is another variation of @nebulon42's last version for comparison, with lengthened bodies. Actually quite some changes done here, so don't know if it can work in SVG, this is just bitmap editing...

car_sharing

@kocio-pl
Copy link
Collaborator

For me it would work.

@nebulon42
Copy link
Contributor Author

@mboeringa Thanks for trying this out. The compressed car is not really an option for me.

@brycenesbitt
Copy link

@mboeringa the compressed car looks much better, and helps get the "sharing" part across. Car sharing and car rental are very different.

@nebulon42 nebulon42 closed this Mar 28, 2015
@nebulon42 nebulon42 deleted the svg-car-sharing branch March 28, 2015 21:05
@matthijsmelissen
Copy link
Collaborator

What about @mboeringa 's version but with the car 1 or 2px more narrow? How would that look?

@nebulon42
Copy link
Contributor Author

That might help, but I have to aim for consistency. If I make the car less tall I will have to change five other icons too. Maybe somebody will come up with another more suitable SVG proposal. Mine is available in the Osmic repository if you want to use it.

@mboeringa
Copy link

If I make the car less tall I will have to change five other icons too.

Yes, this is something I realized recently too. My adjusted proposal conflicts with for example the recently accepted and merged move car repair icon to SVG #1377. As you say, for consistency, it is probably best to either stick with the original proposal and car icon, or change all other car related icons too that may already have been moved to SVG (I am neutral here on this, and leave it to others to judge what they want).

@brycenesbitt
Copy link

Consistency is getting in the way of function here. This is not a "facility for cars" needing the same look as other car facilities. It's a type of transportation that happens to use cars.

The new proposals look like a bad traffic symbol, and simply don't communicate the "community transportation resource/shared car" message.

@mboeringa
Copy link

Consistency is getting in the way of function here. This is not a "facility for cars" needing the same look as other car facilities. It's a type of transportation that happens to use cars.

Not necesarily. Personally, I can live with two icons, but I think it is up to others to decide or give their opinion. In addition, there is the option of adjusting all other icons for consistency, but that requires extra labour. I think we need to give credit to @nebulon42 for all the work in creating these icons and posting them here. I can understand he may be a bit reluctant to adjust all of these, if not for anything else, just because of the time involved. Maybe someone else can do it who has experience with the creation of these SVG icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants