Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bicycle rental icon to SVG #1282

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.
Icon: nebulon42/osmic/rental-bicycle-16.svg

before
bike_rental_before

after
bike_rental_after

@nebulon42 nebulon42 mentioned this pull request Feb 1, 2015
66 tasks
@matkoniecz
Copy link
Contributor

Unfortunately, with new icon it is not clear that it is bicycle. Probably because it is smaller.

@nebulon42
Copy link
Contributor Author

I guess you mean that it's not clear. With what do you think it is likely to be confused?

@matkoniecz
Copy link
Contributor

Sorry, I missed negation.

With old icon mi first impression is that it is key and bicycle. With new - key and some blob and I need to figure out what it is supposed to be. Note that it is heavily influenced by fact that I am looking at new icon for the first time and old is for me well known.

@matkoniecz
Copy link
Contributor

Test on pseudorandom person without exposure to the style: both are recognized as bicycle, old one is preferred as bicycle is larger.

@nebulon42
Copy link
Contributor Author

Thanks for testing. As there is no apparent reason (except legibility maybe) why some icons are 20px and some are 16px I suggest to stick to the 16px canvas size (as I so far already did for prison and theatre if I remember correctly).

@matthijsmelissen
Copy link
Collaborator

Test on pseudorandom person without exposure to the style: both are recognized as bicycle, old one is preferred as bicycle is larger.

Same results for second pseudorandom person.

I don't have a strong opinion on whether to favour legibility or consistency in size.

@nebulon42
Copy link
Contributor Author

I see no problem with legibility here, both tests confirmed it to be seen as bicycle. As far as my icons are concerned, they have all 16px canvas size. But if you want to keep the larger icon this is fine too.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 2, 2015

For me the new one is a bit too small, but if that way we can achieve better visual consistency, I can live with it.

@nebulon42 nebulon42 force-pushed the svg-bicycle-sharing branch from bcd2ace to 03bede1 Compare February 2, 2015 18:55
@nebulon42
Copy link
Contributor Author

Updated after update of #1281.

@matthijsmelissen
Copy link
Collaborator

@gravitystorm This needs a strategic decision: do we go for icons that are all the same size at the cost of legibility? If not, how do we decide which icons we give a large size?

@gravitystorm
Copy link
Owner

Icons certainly don't need to be the same size, especially when they have widely varying "weights" i.e. number of coloured pixels. There is, of course, benefit to having them of both similar size and weight.

Larger icons would be for things which are more important, or are more useful for self-orientation when looking at the map. Smaller icons would be good for things that are repeated many times in the one map view.

I don't have any particular comments on this proposal, but I hope the above guidance is useful in general.

@matthijsmelissen
Copy link
Collaborator

@gravitystorm Yes, such high-level guidance is very useful.

Because @gravitystorm didn't mention allowing finer detail as a reason to accept to use larger icons, and because bicycle rental is not more important than other POI, and also to prevent inflation in icon sizes, I'd be inclined to accept this proposal.

@daganzdaanda
Copy link

I'd like to have all icons more or less the same "optical" size. This might mean that a very dense (=lots of filled pixels) icon could be smaller in real pixels, but carry the same optical impact.

Vector icons are great in that they can get scaled better (in theory at least), so that we could one day decide to show some more important icons larger.
Scaling a 16px icon up will probably give better results than scaling something larger down. Of course, ideally we'd have pixel-aligned icons for many sizes...

About the bike rental icon, let's take it like that. I don't believe any of my versions in #1281 would look better at that size.

matkoniecz pushed a commit that referenced this pull request Feb 23, 2015
@matkoniecz matkoniecz merged commit fe4cd15 into gravitystorm:master Feb 23, 2015
@nebulon42 nebulon42 deleted the svg-bicycle-sharing branch February 23, 2015 16:49
@matkoniecz
Copy link
Contributor

And thanks for your work!

@matthijsmelissen
Copy link
Collaborator

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants