Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move theatre icon to SVG #1254

Merged
merged 1 commit into from
Jan 28, 2015
Merged

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165.
Icon: theatre-16.svg

before
theatre_before

after
theatre_after

@nebulon42 nebulon42 mentioned this pull request Jan 24, 2015
66 tasks
@kocio-pl
Copy link
Collaborator

I like the current icon we have - could this new one have one mask in "negative" color, to make them appear more distinct? The diagonal positioning would be also nice, I think.

@matthijsmelissen
Copy link
Collaborator

I like the current icon we have - could this new one have one mask in "negative" color, to make them appear more distinct? The diagonal positioning would be also nice, I think.

+1

@mboeringa
Copy link

I'm OK with both versions, the new one works just as well to me, and it is similar enough to the old one in terms of the way the "theatre" aspect is conveyed, to be easily recognizable / familiar.

@nebulon42
Copy link
Contributor Author

Agreed, the inverse mask looks better. But I'm not in favour of tilting the masks. I have updated the preview.

@mboeringa
Copy link

Looks good to me...

@matthijsmelissen matthijsmelissen merged commit 938510f into gravitystorm:master Jan 28, 2015
@dieterdreist
Copy link

2015-01-24 17:54 GMT+01:00 kocio-pl [email protected]:

I like the current icon we have - could this new one have one mask in
"negative" color, to make them appear more distinct? The diagonal
positioning would be also nice, I think.

+1
please note that "black and white" (similar to yin and yang) has additional
meaning (good vs. evil, the main topic in the ancient theatre) that now
gets almost completely lost in the current svg icon. (almost because
there's the tiny detail of smiling vs. bad mouth). Also the tilted masks
look a lot better (lighter, more vivid) than the rigid ones in the new
proposal.

@nebulon42 nebulon42 deleted the svg-theatre branch January 29, 2015 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants