-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust hue of landuse=residential #1202
Conversation
Looks fine to me, what does @pnorman think? |
We had decided to keep the lightness of residential, retail, commercial, industrial, and farmland the same. This would reverse that decision, which I don't think is a good idea. |
I could try to extend this PR to the other landuses you mentioned, it would be good to make them lighter anyway. I'm not sure if it is possible, consistency could be also achieved by not strictly adhering to the numbers. It is good to have some symmetry in colours though. But very practically speaking: We have here overlaying features with low contrast. How should we deal with them? |
We made them a lot lighter in #599. I'd rather not go even lighter.
We should make those features stand out more, either with decreased lightness, increased chroma, or suitable outlines for linear features. |
Of course, making the buildings slightly darker then they are now is also not out of the question as far as I'm concerned. |
I am perfectly OK with even the last variant: HSV(20°, .07, .84) (even more red). It is still far from pink, but seems to give the buildings a bit more "body", without making them significantly darker. |
I'm closing this as there is currently no approvement for adjusting landuse colours. I will open a new PR concerned with tweaking the building hue. |
This tries to make the new building colour look better on
landuse=residential
.Drawbacks: residential colour is now more similar to aerodrome colour, but they were not that different before. I propose to adjust aerodrome colour if they are too similar.
http://www.openstreetmap.org/#map=15/48.0804/16.6021
before z15
(aerodrome left, residential right)
http://www.openstreetmap.org/#map=17/48.17157/16.39569
before z17
after z15
(aerodrome left, residential right)
after z17