-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move eat & drink related icons to SVG #1188
Conversation
I'd suggest rounding the tines of the fork, and also for both pieces of cutlery making the handle longer relative to the end, more like before. |
Thanks for the PR. I'm not still sure whether I prefer the clearer icons over the old icons, but I can't quite tell why. I wonder what others think. Concrete suggestions:
|
In general - I like these new icons. As usually it is a bit strange to see map with a changed icons, butI am gettng used to these new ones. Handle for spoon and fork seem to be too short and/or wide. Biergarten icon is too geometrical - it is prettier than old but less obvious what it is representing (maybe changing foam shape would help?). |
Thanks for the feedback.
I agree with @mkoniecz that it might have to do with the unfamiliarity of the map, but I'm not sure. The biergarten icon was not made by me but came from Nori. I liked it quite a lot and I also think it works (maybe only for me). And since you recognised the foam part, this apparently works too. :-) For the restaurant icon, cutlery was intended to have incomplete handles as the important and recognisable parts are at the top. I see that main concerns are with biergarten and restaurant, so I will try to improve these. |
Well, to guess that I needed to know that it is representing biergarten. |
bar pub cafe biergarten fast_food restaurant |
6d0f21b
to
e98b887
Compare
What about an entirely different icon for biergartens? As far as I know, the type of beer served in biergardens is not different from the type of beer served in German pubs, so the icons currently make not very much sense. On the other hand, expressing both 'garden' and 'beer' in one picture is probably hard if not impossible. |
Maybe this icon plus a bit of sun/cloud/grass/bench/tree would be sufficient to express beer+outdoor (not necessary the garden itself). |
I have no idea why there even exists the Biergarten distinction. I would see a Biergarten simply as being an outdoor pub. Actually, the above depicted location is none. It is more a "Schanigarten", where you can sit outside a restaurant or pub. For me the use of different types of beer glasses makes sense. The types may not have an intrinsic meaning, but I more associate the Pint glass with (English) pubs and Steins/Humpen with Germany/Austria/Biergarten.
I would like to avoid complex combinations as they make it harder to create legible icons. |
Difference between bar and pub is unclear (but that might be a deeper OSM problem). Tester is confused about the fact that the glasses are half-empty. Biergarten is recognizable as beer but not as biergarten. Other icons are fine (n=1). |
Tester is confused about the fact that the glasses are half-empty. |
Thanks again for testing. I guess this leaves us with biergarten as being left open for decision. As I like the first proposed icon, I suggest to have it in as well. But I'm happy for other concrete biergarten proposals/sketches (apart from descriptions). |
e98b887
to
c8afb56
Compare
Would making the beer glass 1px fuller be an option? Cultural differences, I know... |
c8afb56
to
a21b701
Compare
I prefer the left one (but as I said, the optimal amount of foam on a glass of beer is heavily debated between countries...) |
a21b701
to
526a4f3
Compare
I have updated to the left pub version to get this merged. ;-) |
@nebulon42 Maybe you could also provide an icon for food courts (different from the restaurant icon)? Idea: something like http://osm-icons.org/wiki/File:12050.svg maybe? Was first discussed at #1040 |
@sommerluk I would rather not add anything to this PR at this stage, but we can discuss at #868. |
move eat & drink related icons to SVG
Thanks! |
Implements part of #1165 by moving bar, pub, cafe, biergarten, fast_food and restaurant icons to SVG.
For icons see nebulon42/osmic/eat-drink.
(mostly) http://www.openstreetmap.org/#map=19/48.21218/16.37415
before
after