Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move religion related icons to SVG #1185

Merged
merged 1 commit into from
Jan 2, 2015

Conversation

nebulon42
Copy link
Contributor

This implements part of #1165 by moving icons for amenity=place_of_worship to SVG.
Icons did not change much (see nebulon42/osmic/religious).

http://www.openstreetmap.org/#map=16/48.2153/16.3811

before
z16
religion_before_z16

z18
religion_before_z18

after
z16
religious_after_z16

z18
religious_after_z18

@nebulon42 nebulon42 mentioned this pull request Dec 31, 2014
66 tasks
@polarbearing
Copy link
Contributor

Good. There was discussion about adding an Orthodox cross here #1058

@nebulon42
Copy link
Contributor Author

An orthodox cross is easily added: christian-orthodox-16 (christian-orthodox-16.svg)

christian-orthodox-128

But I'd rather address this separately. Since an orthodox icon was not considered in #1058 you might want to request that this issue is reopened.

I'm not so sure for Jehova's Witness, maybe a Watchtower depiction would be good, but that could be confused with castles.

@lest69
Copy link

lest69 commented Dec 31, 2014

To me, it looks like the Star of David is compressed vertically. The points on the top and bottom seem smaller than the other four, making it look squished.

@nebulon42
Copy link
Contributor Author

Indeed, thanks, I have updated the aspect ratio.

gravitystorm added a commit that referenced this pull request Jan 2, 2015
move religion related icons to SVG
@gravitystorm gravitystorm merged commit 30b74f1 into gravitystorm:master Jan 2, 2015
@nebulon42 nebulon42 deleted the svg-religious branch January 2, 2015 14:07
@daganzdaanda
Copy link

Now that the change shows up on the map, I think the cross is a bit bigger / taller than before. This makes it overlap the church building more often than before. Maybe a pixel less would be more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants