Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

money related SVG icons #1171

Merged
merged 1 commit into from
Jan 6, 2015

Conversation

nebulon42
Copy link
Contributor

Implements part of #1165 and focuses on money related icons.

The original icons used stroke and fill so I had to change them. I also tried to reduce complexity a bit.
Following symbols are affected:

amenity=atm (atm-16.svg)
atm-16

amenity=bank (bank-16.svg)
bank-16

http://www.openstreetmap.org/#map=19/48.20196/16.39171
before:
money_before

after:
money_after

@nebulon42
Copy link
Contributor Author

I again noticed problems with ways (e.g. http://www.openstreetmap.org/way/162607424) and duplicated icons. I'm still not sure why this occurs. It's in the TileMill rendering, but not in the exported PNG image.

symbol_problem

@matthijsmelissen
Copy link
Collaborator

I would still be in favour of generating base-files that are white on black with rounded corners, and than generating the negatives from that, so that other projects such as Potlatch 2 can also use our improvements to the icons. Any opinions on that?

@nebulon42
Copy link
Contributor Author

Shields are perfectly fine for me, but I would approach it the other way round. Start with the versions we need for this style first, and then make (or generate) other versions like inverted, w/o shield, w/o rounded corners etc. Why? Because it might be helpful to keep in mind that there might be no solid background in the end after designing the icon.

But I don't know if it is more difficult to add or to remove something from a SVG file by scripting.

Here is the inverted version of ATM, this was done in less than a minute from the other version:
atm_inverted

@althio
Copy link

althio commented Dec 21, 2014

Hi, I find that the icons are quite 'dollar'-centric. What about this kind of drawing?
atm

@gravitystorm
Copy link
Owner

I'm still not sure why this occurs.

marker-clip: false is required.

What you're seeing is meta-tile boundary artifacts. By default the polygons are clipped to the meta-tile, so you get one marker for the part of the bank in one meta-tile, and a second marker for the other part of the bank in the other meta-tile. You don't see it on a png export since that just makes one big image.

@nebulon42
Copy link
Contributor Author

@gravitystorm That was the problem, thanks for explaining this.

@althio Unfortunately your proposed icon is too complex for small sizes. But I'm also not too happy with the dollar sign and also not fully convinced with the icons I proposed. Bank and ATM seem to be difficult to represent in a easy to recognize way. I'll think some more about it.

@althio
Copy link

althio commented Dec 22, 2014

Another suggestion with a card instead of a banknote? Something similar to http://megaicons.net/iconspack-60/1044/

@pnorman
Copy link
Collaborator

pnorman commented Dec 23, 2014

Another suggestion with a card instead of a banknote? Something similar to http://megaicons.net/iconspack-60/1044/

We need something for ATM and Bank - any thoughts for both?

@althio
Copy link

althio commented Dec 23, 2014

For bank? image or image? I like the coins more.
For ATM it was image or also image.

@nebulon42
Copy link
Contributor Author

I tried again for ATM by prettying up my proposal and replacing the dollar by a 1 (atm-16.svg). I'm not sure if it is recognizable enough.

atm_new

What do you think?
The coin stack also looks good though.

update: I also updated the bank icon bank-16.svg

@althio
Copy link

althio commented Dec 23, 2014

Replacing the dollar sign "$" by the figure "1" was a good move but IMO it does not render well in this case. Maybe too small, maybe disturbing to read it turned at 90°. A two-figure number like "10" could stand out more.

Also trying to stand back a little, I think the perspective on the banknote can be misleading. If I look at it with an fresh mind and look for a flat icon, I see something more like a tower or chimney.

@SomeoneElseOSM
Copy link
Contributor

@althio re the pig, I'm not sure how widespread the concept of a "piggy bank" is worldwide (or indeed whether using a pig at all would be problematic in some cultures, in that it wouldn't immediately make people think "money").

@althio
Copy link

althio commented Dec 24, 2014

I agree about the pig it is certainly a bad proposal. I had in mind the
cultural interpretation and misunderstanding that is why I stated I like
the coins more.

We are back to buildings, banknotes, credit/debit cards and coins.

@nebulon42
Copy link
Contributor Author

The debit card looks good graphically, but I'm afraid it could be confused with the ability to pay without cash (nowadays maybe not really noteworthy anymore). Personally I would prefer to reuse the core symbol for ATM and bank to see that they are related. So I'm sticking to the banknote for now and have updated my proposal.

@nebulon42 nebulon42 mentioned this pull request Dec 24, 2014
66 tasks
@pnorman
Copy link
Collaborator

pnorman commented Dec 25, 2014

I like the
image ATM.

I like the idea of the bank one - a stack of bills - but unfortunately the lower line with curves at the end just looks like a line shorter than the width of the stack at the low resolutions we're using.

The lack of perspective really helps cut back on fuzzy edges

@nebulon42
Copy link
Contributor Author

Thanks. I don't think that the additional line is so bad, but I also thought about simply leaving it out.

@HolgerJeromin
Copy link
Contributor

I really liked the roof of the old one. But money with a roof probably does not work...

@pnorman
Copy link
Collaborator

pnorman commented Dec 25, 2014

I liked the roof too, but I'm not sure a bill would fit within it

@matthijsmelissen
Copy link
Collaborator

Very nice. I'm happy that you succeeded in creating a clear icon without currency symbol.

Perhaps it would look better if it's rendered slightly lighter / more grayish?

@nebulon42
Copy link
Contributor Author

Different gray versions:

333333 (current)
bank_333

555555
bank_555

777777
bank_777

Maybe 555555 is the best?

@matthijsmelissen
Copy link
Collaborator

Yes, I also like 555555 the best.

@polarbearing
Copy link
Contributor

The ATM is excellent now. For the bank it is not so intuitive - would it help to give the banknote a gabled roof? Also it is good that your example has a post office next to it, we might use the same outer symbol for the post office and the bank, with different content.

@nebulon42
Copy link
Contributor Author

Updated the colour. Will look into the roof thing, but I doubt that it looks good.

@polarbearing
Copy link
Contributor

Does not have to be a roof, but something that can be made common for all such institutional building.

@nebulon42
Copy link
Contributor Author

Here a first try of the roof: bank-16 kopie

bank-16 kopie 128

I think the bill is too wide for the roof to work.

@imagico
Copy link
Collaborator

imagico commented Dec 31, 2014

I originally wanted to make this comment on the toilet icon PR but it is actually a general remark on icon design and that was closed so i am mentioning it here.

The problem is that creating a sharp and geometrically clear icon for low resolution rendering and creating one that is intuitively understandable are in most cases contradicting goals. In my opinion the second goal should have priority over the first, it seems to me however the recent attempts in creating new icons often put the first before the second.

Specifically here i think the current icon proposal could also indicate something like a carpet shop (as well as probably many other things for people with different cultural background and socialization). The dollar sign - as biased as it might be - is quite universally understandable on the other hand.

Also there is a risk of making the icons too sharp - you should be careful of not having too many pixel aligned vertical and horizontal edges - since those never occur in the map otherwise this can be quite irritating. Currently i think this is an issue here, in the museum and in the religion icon PR.

@matkoniecz
Copy link
Contributor

ATM icon is not recognisable as an ATM, according to my small scale hallway testing. They also claimed that old icon is better.

@nebulon42
Copy link
Contributor Author

In my opinion the second goal should have priority over the first, it seems to me however the recent attempts in creating new icons often put the first before the second.

I try my best in producing sharp AND recognisable icons. You are assuming that the old icon was intuitively and universally recognisable, which can be the case but I seriously doubt it. You should not assume that the status quo is the best available option so far, even when leaving out the shortcomings of graphical display due to downsizing the icon.

Also there is a risk of making the icons too sharp ...

I don't see this risk. IMO the sharpness is a big improvement.

ATM icon is not recognisable as an ATM, according to my small scale hallway testing.

Was the old icon recognizable as such and did you test that? Did you do a A/B testing?

I neither have the resources nor time to approach this scientifically. If you want that you should contract a professional design agency and a market research company. I'm not saying that I provided the best available design so far, but what I'm getting very often (apart from lots of good feedback, thank you!) is 15 (contradicting) opinions from 10 persons. You cannot satisfy everyone. I'm also not implying that there shouldn't be serious consideration and discussion, but I guess we really need accepted features for icon design (which I tried to establish in #1165) and concrete suggestions for improvement.

@imagico
Copy link
Collaborator

imagico commented Dec 31, 2014

I try my best in producing sharp AND recognisable icons. You are assuming that the old icon was intuitively and universally recognisable, which can be the case but I seriously doubt it. You should not assume that the status quo is the best available option so far, even when leaving out the shortcomings of graphical display due to downsizing the icon.

I am not saying anything about the quality of the current icons here - there are certainly a lot of things that can be improved about them - i saw this myself when creating new air transport icons.

It is quite clear to me that a blurry icon can in some cases be better intuitively understandable than a sharp one. It is a good idea to keep that in mind i think.

I don't see this risk. IMO the sharpness is a big improvement.

You can best see this in the currently deployed style with the new wetland pattern (see #1158). This is perfectly pixel aligned meaning there are no partially covered pixels. This makes it stand out very strongly compared to other features in the map. I am not saying this should be avoided at all costs, i am just saying again you should be aware this can be an issue.

Note i am making these general remarks not out of a general dislike of your work but because i am well aware that in design questions like this it is of very limited use to just mention an opinion on a specific proposal since there will always be diverging opinions. There is little use in design to just try to please others. Instead just try to do what you think is best and be reflective about your underlying thoughts and priorities.

@nebulon42
Copy link
Contributor Author

@imagico Thanks, I think I do now better understand what you meant. I didn't imply that you were attacking this work in general, I was just expressing the difficulty of dealing with a lot of diverging opinions.

I also understand that changing established icons is not easy to do, of course you want to be sure that you don't make it worse. It would be best to have an A/B testing round with OSM users (thanks @mkoniecz for collecting opinions), but that is a lot of work and IMO out of scope. In design you sometimes have to be brave and step beyond the status quo. Of course, improvements are always possible later on.

I personally like the use of icons in the HOT style, it works quite well IMO. These icons are very similar to those I'm proposing here.

@polarbearing
Copy link
Contributor

Good approach with the roof. Could you do the same with a letter for a post office?
@mkoniecz - some things will be recognised in context. Thus when you have the bank building with a note, and then see an ATM, and than the same "symbologic" for the post office and a letter box, the map will be understood.

@matthijsmelissen
Copy link
Collaborator

I also tested this with someone unfamiliar to the icons - I can confirm that bank is recognisable, but ATM is not.

Creating recognizable icons is hard, so I don't mind accepting icons of which users need to learn the meaning, but icons that are recognizable immediately are better of course.

@nebulon42
Copy link
Contributor Author

@math1985 for bank, did you test the stacked bills or the roof variant?
Maybe we should re-introduce the dollar sign? @imagico might be quite right that it is biased but recognisable.

@matthijsmelissen
Copy link
Collaborator

For bank I tested the stacked bills.

@pnorman
Copy link
Collaborator

pnorman commented Jan 3, 2015

Maybe we should re-introduce the dollar sign? @imagico might be quite right that it is biased but recognisable

Another problem with the dollar sign is that at the sizes we need it's close to a blob anyways. Even fonts with hinting have problems.

@nebulon42
Copy link
Contributor Author

Another problem with the dollar sign is that at the sizes we need it's close to a blob anyways. Even fonts with hinting have problems.

Yes, also true. So maybe leave it like it is and change accordingly if there are problems?!
I have updated the PR to reflect the fact that symbols shouldn't be grouped in subdirectories.

@Vort
Copy link

Vort commented Jan 3, 2015

Banknotes have different design in different countries.
Someone may not know how dollar looks like, but I'm sure everyone knows the dollar sign.
For the same reason I like coins better than dollar's stack.
Maybe coins under the roof is a good idea for bank?

@matthijsmelissen
Copy link
Collaborator

Is this ready to be merged?

@nebulon42
Copy link
Contributor Author

A little sum up from me: I'm not convinced of the roof approach. Coins are not bad, but I would like to reuse core symbology for bank and ATM, coins won't work for ATM. I don't really like the dollar sign, but I acknowledge that it is familiar. To be legible it has to be big, so simply adding it inside the center of the bill wouldn't work so well.

There was the feedback that ATM isn't recognisable, but I don't have any better ideas at the moment. So I'd suggest to merge and to risk that ATM isn't that recognisable at the start.

@matthijsmelissen matthijsmelissen merged commit 93be349 into gravitystorm:master Jan 6, 2015
@matthijsmelissen
Copy link
Collaborator

Thanks. If anyone has a better suggestion, we can consider, but this seems to be the best we can come up with for now.

@matthijsmelissen
Copy link
Collaborator

@mkoniecz I suspect the text-dy might need to be adapted (decreased, fortunately) to the new icons, could you check that?

@nebulon42 nebulon42 deleted the svg-icons-money branch January 6, 2015 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.