Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change boundary nature reserve / national park areas #1147

Merged

Conversation

matthijsmelissen
Copy link
Collaborator

This changes the rendering of national parks in the following way:

Changes with respect to #1077:

  • Restore transparent fill for zoomlevels 7-9.
  • Make line slightly narrower on zoomlevels 10-12 and wider on zoomlevel 10-13.

This changes the rendering of national parks in the following way:
* Render border with a double uninterrupted line (line marinas).
* Require 100px minimum size for rendering.
* For zoom levels 10-12, drop transparent fill.

* Resolves gravitystorm#69
* Resolves gravitystorm#563
* Supersedes gravitystorm#1077

Changes with respect to gravitystorm#1077:
* Restore transparent fill for zoomlevels 7-9.
* Make line slightly narrower on zoomlevels 10-12 and wider on zoomlevel 10-13.
@imagico
Copy link
Collaborator

imagico commented Dec 8, 2014

Still think an upper limit in terms of way_pixels for the fill would be better. Just for reference - the largest currently mapped nature reserves in terms of web mercator real estate are probably

http://www.openstreetmap.org/way/231394343
http://www.openstreetmap.org/way/257722804
http://www.openstreetmap.org/relation/2098390
http://www.openstreetmap.org/relation/3960826

Currently unmapped but equally too large to be shown with a fill at z=10 are

http://en.wikipedia.org/wiki/Quttinirpaaq_National_Park
http://en.wikipedia.org/wiki/Wrangell%E2%80%93St._Elias_National_Park_and_Preserve
http://en.wikipedia.org/wiki/Gates_of_the_Arctic_National_Park_and_Preserve
http://en.wikipedia.org/wiki/Northeast_Greenland_National_Park

the last is already too large even at z=7 of course.

@matthijsmelissen
Copy link
Collaborator Author

I agree with the problem, but I don't think an upper limit in pixels is a good idea. It would lead to some areas being transparent while others aren't within the same view. I think that would be very confusing. I'd propose to merge this change first, and possible consider a change that goes further than this after it is merged.

@gravitystorm gravitystorm merged commit df28261 into gravitystorm:master Dec 10, 2014
@gravitystorm
Copy link
Owner

Merged. I do think there's room for improvement here, I find the edge of the park boundaries hard to spot when the fill disappears. Perhaps we can have wider boundaries since (unlike marinas and theme parks) they cover much bigger areas, and are more likely to have a complex amount of data underneath.

@matthijsmelissen
Copy link
Collaborator Author

I suppose you're referring to zoom 10-13? Not all nature reserves are big, so I am not sure if a bigger outline will always work. After this is rolled out I will have a new look if it makes sense to widen the outline on these zoom levels.

@daganzdaanda
Copy link

Just wanted to thank you for this change, it works well in the areas that I looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nature reserve extents are unclear national_park on top of a road looks like an access restriction
4 participants