Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve marsh/wetland/mud rendering #1042

Merged

Conversation

matthijsmelissen
Copy link
Collaborator

* Render marsh and wetland from z10 (resolves gravitystorm#899)
* Render labels on marsh, wetland and mud (resolves gravitystorm#935)
@matkoniecz
Copy link
Contributor

Render marsh and wetland from z10

Is it working properly for small areas? I expected that symbols/marsh.png is unsuitable for rendering in this cases.

@imagico
Copy link
Collaborator

imagico commented Oct 11, 2014

@matkoniecz
Copy link
Contributor

natural=marsh is deprecated

You may want to comment in existing ticket about this or create a new ticket for this (but with 11 797 instances it is likely this proposed change will be rejected).

This PR is about improving currently rendered feature.

@matthijsmelissen
Copy link
Collaborator Author

Is it working properly for small areas? I expected that symbols/marsh.png is unsuitable for rendering in this cases.

There are sufficient huge wetland areas, see for example http://www.openstreetmap.org/#map=13/53.4123/5.6895.

@matkoniecz
Copy link
Contributor

I know, but some wetland areas are tiny at z13.

@imagico
Copy link
Collaborator

imagico commented Oct 11, 2014

You may want to comment in existing ticket about this or create a new ticket for this (but with 11 797 instances it is likely this proposed change will be rejected).

I am just pointing this out since it is not widely known (which is also proven by the fact that >9000 of the uses have been added by import after it has been deprecated).

And i concur that the wetland pattern is not well suited for rendering at low zooms - and neither is the beach pattern by the way - which is now also used from z=10 on - like on http://www.openstreetmap.org/#map=10/53.3764/5.5495.

@matthijsmelissen
Copy link
Collaborator Author

And i concur that the wetland pattern is not well suited for rendering at low zooms

Isn't this not so much an zoom level problem as an area size problem? There are tiny wetlands on high zoom as well as huge wetlands on low zoom. What solution do you suggest?

@imagico
Copy link
Collaborator

imagico commented Oct 12, 2014

Using a more fine grained pattern would help. Try this one:

randomized generic wetland pattern

would also solve #936 and does not imply vegetation as the current one does.

@matkoniecz
Copy link
Contributor

There are tiny wetlands on high zoom as well as huge wetlands on low zoom.

Good point, it may be better to fix it as a separate issue. I also thought about something like imagico presented.

@dieterdreist
Copy link

is there any usecase for the malformed natural=mud which isn't better
represented with natural=wetland?

@imagico
Copy link
Collaborator

imagico commented Oct 18, 2014

I would consider natural=mud as a synonym for natural=wetland + wetland=mud, there is no mud that is not also wetland since mud is wet by definition. Tidal mud flats should probably better be tagged natural=wetland + wetland=tidalflat.

And of course there are also self contradicting cases like

http://www.openstreetmap.org/way/41065883

@dieterdreist
Copy link

2014-10-18 16:38 GMT+02:00 imagico [email protected]:

natural=wetland + wetland=mud, there is no mud that is not also wetland
since mud is wet by definition.

"what kind of wetland is it? A mud" --- really??

I think this sound very bogus. Currently most used values for (i.e.
subtypes of) wetland are:

bog
marsh
swamp
tidalflat
reedbed
wet_meadow
saltmarsh
mangrove
string_bog
saltern

accounting for more than 99,9% of all subtypes (for roughly 216.000
occurences).
Luckily there are only 23 occurences of "mud" because this really doesn't
fit at all into the list. "mud" is not a type of wetland, it is a (generic)
description of a material (wet soil, clay and silt).

@imagico
Copy link
Collaborator

imagico commented Oct 21, 2014

I didn't say this is a particularly good tagging. On the other hand the commonly used values for wetland contain nothing suited for stretches of mud that are not tidal.

Current use of natural=mud can to a large part be divided into three categories:

  • tidal mud flats which should be tagged natural=wetland + wetland=tidalflat
  • wetlands with no, sparse or patchy vegetation like here
  • intermittent water areas/dry lakes like here

Most of this is essentially tagging for the renderer due to the fact that wetlands are rendered in a uniform style implying vegetation and intermittency of water areas is not rendered.

@dieterdreist
Copy link

2014-10-21 13:17 GMT+02:00 imagico [email protected]:

I didn't say this is a particularly good tagging.

happy we agree on this.

On the other hand the commonly used values for wetland contain nothing
suited for stretches of mud that are not tidal.

what type of wetland is it? If you can tell what you want to tag, we can
find a value for it ;-)
Maybe it is a marsh? A wet_meadow? A bog or a swamp? Mud can occur in
various circumstances as it is just a generic term for "water + ground /
soil / ...", wetland=mud really doesn't add anything that isn't already
contained in natural=wetland.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this pull request Dec 9, 2014
@matthijsmelissen
Copy link
Collaborator Author

Thanks @imagico, that icon is an improvement.

Assigned to @gravitystorm for review.

@gravitystorm gravitystorm merged commit edc751d into gravitystorm:master Dec 10, 2014
@matthijsmelissen matthijsmelissen deleted the mud-marsh-wetland-names branch January 7, 2015 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wetland name not rendered marsh/wetland rendered only for zl>=13
5 participants