Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase zoomlevel for private amenity=recycling #847

Closed
matthijsmelissen opened this issue Aug 5, 2014 · 14 comments
Closed

Increase zoomlevel for private amenity=recycling #847

matthijsmelissen opened this issue Aug 5, 2014 · 14 comments

Comments

@matthijsmelissen
Copy link
Collaborator

In the German speaking countries every apartment building has it's own containers for recycling plastic, paper,but only people living in those apartments are allowed to use them. They are mapped according to the description on the wiki page with access=private added to them.

problem is, mapnik still renders them even at zoom level 16, which totaly clutters the map. example: http://osm.org/go/0JhJfqRx

Suggestions for fine tuning the rendering of this tag: 1) amenity=recyling + access+private should only be rendered at zoom level 18 and higher and transparency of the symbol should be set to 50% (like it is done with amenity=parking if set to private). at zoom level 17 or lower, it shouldn't be rendered at all. 2) amenity=recyling + access+permissive should only be rendered at zoom level 17 and higher and transparency of the symbol should be set to 50% (like it is done with amenity=parking if set to permissive ). at zoom level 16 or lower, it shouldn't be rendered at all. 3) amenity=recyling + access+public (or no restriction) should be rendered without transparency and at zoom level 16. (basically as it is now)

See also https://trac.openstreetmap.org/ticket/3575.

@sb12
Copy link
Contributor

sb12 commented Aug 11, 2014

This also applies to other objects, which are not open/accessible to the public. Some examples: shops / restaurants / other amenities in army bases and in big research institutes and companies, private fuel stations, bus and train stations for employees only (e.g. BASF Ludwigshafen, KIT Campus Nord), private playgrounds.
They don't clutter the map, but it would be nice anyway to see on the map that they are not accessible.

@matkoniecz
Copy link
Contributor

For private playgrounds see #683

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 4, 2015

I think rendering them lighter may be better.

EDIT: Seems like this issue may be closed now, because they already are rendered lighter and zoom level is increased. =}

@matkoniecz
Copy link
Contributor

Zoom was increased also for public, maybe increasing it even more for private ones is still a good idea.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 4, 2015

I think about something different: amenity=recycling can be large/important (recycling_type=centre) or small/less important (recycling_type=container), which is IMO exact analogy to amenity=waste_disposal (it's just that some trashes are segregated and some other aren't). I realize we need a database reload, but it makes sense for me to:

  • Have recycling_type=centre earlier (z>=17 as of now or maybe even z>=16).
  • Push recycling_type=container later (lack of recycling_type=* should be treated the same by default), probably to z>=18 or even z>=19, no matter if they are public or private.
  • For amenity=waste_disposal use the same rules as for recycling container (the icon could be just bigger than for amenity=waste_basket).

I wanted to open new issue for that, but maybe there's no need for it and we can continue here?

@HolgerJeromin
Copy link
Contributor

I hope many centres are mapped as an area, so probably we do not need the new tag in the db, but could use way_area aka size.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 4, 2015

I also thought about it, but both can be mapped as an area (containers can be under roof or in a kind of shed) or node (center area border could be not known), so this would not work.

@dieterdreist
Copy link

sent from a phone

Am 05.08.2015 um 01:16 schrieb kocio-pl [email protected]:

I also thought about it, but both can be mapped as an area (containers can be under roof or in a kind of shed), so this would not work.

or they could be in a country. Would it be good mapping to attach the container tag to the country polygon?

@HolgerJeromin
Copy link
Contributor

But even a shed or something like that would be smaller than a typical (or at least important) centre. So IMO your suggestions from #847 (comment) would still work.

@matkoniecz
Copy link
Contributor

or node (center area border could be not known)

Rendering them as not prominent as they deserve encourages more detailed rendering (as an area) so it is OK.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 5, 2015

I don't like those workarounds, but I also don't want to loose the energy to get into details too deep, especially before we have interesting database entries available and we can test different approach. The most important things for me are:

  • there are bigger and smaller/local recycling points and we should reflect their importance (by choosing proper zoom level)
  • small/local recycling points are in fact the same as waste disposals and we should reflect it (by using the same rendering rules)
  • private/public difference is better reflected by using opacity than by tuning zoom level (just like we don't do it for private highways or private buildings)

@kocio-pl
Copy link
Collaborator

The current numbers for amenity=recycling are:

  • recycling_type=centre - 11 419
  • recycling_type=container - 106 157

I guess it's now ready to finally deploy #847 (comment). This will make z17 less cluttered and soon we can have also amenity=waste_disposal on z18+ (see #419).

@kocio-pl kocio-pl self-assigned this Nov 23, 2017
@HolgerJeromin
Copy link
Contributor

More important than the number itself: 60.49% of all recycling objects have added type.

@kocio-pl
Copy link
Collaborator

I think it's even easier: only "centre" should be visible on z17 (as currently), we don't have to check any other type - they all will fall into z18/19 by default, so lack of type doesn't bother us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants