Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing arrows when oneway construction overlaps oneway highway #597

Closed
matthijsmelissen opened this issue Jun 2, 2014 · 8 comments · Fixed by #1840
Closed

Confusing arrows when oneway construction overlaps oneway highway #597

matthijsmelissen opened this issue Jun 2, 2014 · 8 comments · Fixed by #1840

Comments

@matthijsmelissen
Copy link
Collaborator

The following issue has been moved over from trac. It needs more discussion as it is not clear how this should be implemented.

If a road overlaps with a construction road, and both roads are oneway but in opposite direction, it is not clear which arrows refer to which roads.
Example: https://trac.openstreetmap.org/raw-attachment/ticket/5085/oneway_arrows%20of%20construction%20highways.png

The original bug report suggests the following layering stack

construction highway
construction oneway arrows
normal highway
normal oneway arrows 

However, that would create a lot of overhead in the code.

We could also decide to drop rendering arrows on construction roads altogether, or to do nothing at all.

@Rovastar
Copy link
Contributor

Rovastar commented Jun 3, 2014

Drop one way arrows on under construction roads they are not even built yet.

@matkoniecz
Copy link
Contributor

Drop one way arrows on under construction roads they are not even built yet.

I think that it would be a good idea.

@matkoniecz matkoniecz self-assigned this Jul 21, 2015
@matkoniecz matkoniecz removed their assignment Sep 2, 2015
@nebulon42
Copy link
Contributor

When we are talking about not rendering oneway arrows on certain road types like construction it would be beneficial to discuss on which types arrows should be omitted. Oneway arrows are also rendered on e.g. footways and possibly on steps although none are tagged that way currently.

Do we want that? I initially thought about omitting construction, footway, path, pedestrian, platform, steps although I see some issues with e.g. bike designated access. So maybe still include footway, path?

@matkoniecz
Copy link
Contributor

path - oneway bicycle routes are nothing weird.

true footways - in my city there is a bizarre case of sidewalk with allowed bicycle traffic (highway=footway, bicycle=yes), oneway on each side of the road. I am not entirely sure is it worth showing oneway arrows in cases like that. There are also extremely limited cases of truly oneway footways (entrance only, exit only footways) like at http://www.openstreetmap.org/?mlat=50.05516&mlon=19.85401#map=19/50.05516/19.85401 There are also some oneway mountain routes like http://www.openstreetmap.org/#map=19/49.21884/20.02714

pedestrian - many highway=pedestrian allow limited traffic (for example delivery during limited hours) that is oneway. Though given that significant majority of traffic there is not oneway...

@nebulon42
Copy link
Contributor

Thanks for clarifying, I will only omit construction, platform and steps for now.

@matkoniecz
Copy link
Contributor

platform - I am unsure whatever we are rendering arrows there. Anyway, oneway footway through platform would be rendered anyway.

steps - there are about 800 cases of oneway=yes on steps - see http://taginfo.openstreetmap.org/tags/highway=steps#combinations and http://overpass-turbo.eu/s/bxk

It s not much, but I would prefer to keep this rendering (to keep it consistent with highway=footway, to make debugging of routing problems easier. it is also nice to cover also this rare cases)

Among known to me real cases - oneway trail in Slovenský raj - http://www.openstreetmap.org/way/273254101#map=18/48.93684/20.36541

@matkoniecz
Copy link
Contributor

So I would propose to omit oneways solely for construction and platform.

@nebulon42
Copy link
Contributor

I've tested with platform and oneway arrows were not rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants