Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum number of oneway arrows #595

Open
matthijsmelissen opened this issue Jun 2, 2014 · 9 comments · Fixed by #1840
Open

Minimum number of oneway arrows #595

matthijsmelissen opened this issue Jun 2, 2014 · 9 comments · Fixed by #1840

Comments

@matthijsmelissen
Copy link
Collaborator

The following issue has been moved over from trac. It needs more discussion as it is not clear how this should be implemented.

Please make sure there is a minimum number of oneway arrows visible (on high zoom levels).

E.g. here on the oneway street "Vom-Rath-Straße" there is only one arrow at the north end that can be overlooked easily. In high zoom levels (17,18) there is enough space for a(n) additional arrows(s) e.g. at the south end.
Alternatively you may consider drawing a more transparent arrow under the street name - but only if there is not enough space for the previous solution.

@matthijsmelissen
Copy link
Collaborator Author

I'm actually not sure why no southern arrow renders on z18?

@mrwojo
Copy link
Contributor

mrwojo commented Jun 2, 2014

I'm actually not sure why no southern arrow renders on z18?

A few blue pixels are visible under the "Vom" (mostly hidden by the text's halo), which is about 160px from the other arrow. Note also that the road is oneway=-1 (the beginning of the way, where the first arrow is placed, is at the north end).

@matthijsmelissen
Copy link
Collaborator Author

Reopening (false closed by commit message).

@matthijsmelissen
Copy link
Collaborator Author

Unless @matkoniecz can perhaps confirm this is indeed solved?

@matkoniecz
Copy link
Contributor

According to my tests it is not solved.

@nebulon42
Copy link
Contributor

Sorry, did not know that Github could misinterpret the "might fix ...".

@matkoniecz
Copy link
Contributor

Github probably detected "fix ..." and ignored "might".

@jeisenbe
Copy link
Collaborator

In #3890 @dieterdreist again notes that short roads do not get oneway arrows placed.

This is because since #1840 in September 2015 they are rendered from svg icons with:

        marker-placement: line;
        marker-spacing: 180;

The arrows for paths are rendered as a text symbol, but with the same line placement and spacing.

This means that if the total length of the line is less than 90 pixels (half the spacing), no arrow will be placed. If marker-spacing is reduced, arrows would be placed on shorter ways, but also there would be more of them.

In the past, before #1840, oneway arrows were rendered as a raster line pattern, and we had the issue of them appearing too soon, near the beginning of a way. See #284

It might be possible to remove the marker-spacing for ways that are shorter than 100 pixels, but longer than 20 or so, and place just one arrow at the center of the way.

Any ideas on how to achieve that technically? Is the length of way recorded already, similar to way_area?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants