-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
River label renders on top of bridge #478
Comments
How should we solve this? What would be the desired behaviour? |
Not sure about the how, but I don't think I've ever seen it before (or rather noticed it). In this special case it's a bit awkward because the bridge is very wide (more like a place). |
Should the waterway be tagged with tunnel? Then it will be same as all other waterways under features. |
I'm still not sure what the desired behaviour would be, and if there is actually a problem. |
River labels should be displaced to be rendered only over river, not over objects on river. |
It is not easy to specify that an object cannot be rendered over another object, as far as I know. The main tool to accomplish that is render order, but I'm not sure how that can help us here. We also don't want half labels if a river is partially covered. |
This happens in my local area at certain zoom levels |
In the case of the screenshot, it might make sense to add a tunnel=yes to the river because it's a big area (would a covered=yes do anything?) How does displacement work? |
The way to fix this is to create "labelling features" by taking the water lines/polygons, and 'subtracting' areas that overlap them (and subtracting areas created by adding buffers around linear features like roads). The same approach can be taken to solve e.g. street labels where lots of railway lines passing over the top, e.g. http://www.openstreetmap.org/#map=18/51.49871/-0.11458 But this is all far too complex a solution, given the size of the problem. Perhaps there is an easier way? |
FYI, it happens even for single-way bridges. Just need to be unlucky enough. And it's noticed by users : http://www.openstreetmap.org/note/191799 |
As we currently have no simple way to solve this, I will close this issue. |
One easy fix would be to render river labels after rivers but before bridges. It's not great as we'd be obscuring the label (maybe even partially), but it's arguably better than the current situation. There was an inspiring talk about intelligent label placement at SOTM-EU 2014. Can any of it be applied to osm-carto ? |
A partial humble solution to this issue could be to have a phantom label for bridges that displaced river labels. In particular, it could be achieved by giving a label style with opacity 0 to the bridges whenever their own label it is not displayed. |
Example:
Bridge: http://www.openstreetmap.org/way/8147286
Waterway: http://www.openstreetmap.org/way/27600092
The text was updated successfully, but these errors were encountered: