Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render labels for man_made=pier #474

Closed
Krillle opened this issue Apr 14, 2014 · 6 comments · Fixed by #991
Closed

Render labels for man_made=pier #474

Krillle opened this issue Apr 14, 2014 · 6 comments · Fixed by #991
Labels
water-features
Milestone
Bugs and improvem...

Comments

@Krillle
Copy link

Krillle commented Apr 14, 2014

Piers in big marinas are like streets in towns. They have names (numbers or letters)
It's important to know their names to find the right pier. These names of piers had been rendered before, but have been removed lately.

Please render the names of piers again.

See her for examples: http://www.openstreetmap.org/#map=17/44.05425/15.29923&layers=N
http://www.openstreetmap.org/#map=17/43.71978/15.89723&layers=N
@matthijsmelissen
Copy link
Collaborator

This is indeed a regression with repect to the old Mapnik style:
http://bl.ocks.org/tyrasd/raw/6164696/#17.00/44.05331/15.29944

@gravitystorm
Copy link
Owner

It's not a 'regression', it is, of course, a side effect of removing the catchalls.

There are thousands of features that used to have catch-all name rendering. Now we need to decide on a case-by-case basis what's worth labelling, and just as importantly, how it should be rendered. For example, the labelling of admin boundaries is many times more effective now that the labels are offset from the lines.

@matthijsmelissen
Copy link
Collaborator

Didn't the catch-all only apply to areas? The piers seem to be linear features. Is there some osm2pgsql magic going on?

@gravitystorm
Copy link
Owner

There were multiple catchalls - see 286d098 for the linear one.

@matthijsmelissen
Copy link
Collaborator

Alright, thanks!

@Krillle
Copy link
Author

Krillle commented Apr 14, 2014

Here is another one with the same request:

https://help.openstreetmap.org/questions/32297/pier-labels-no-longer-displayed

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Sep 27, 2014
@matthijsmelissen
Refactor water-features
c4d42d2 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
@matthijsmelissen matthijsmelissen mentioned this issue Sep 27, 2014
Merged
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Dec 23, 2014
@matthijsmelissen
Refactor water-features
0e36fb1 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
@matkoniecz matkoniecz changed the title Please restore rendering of pier names Render labels for man_made=pier Jan 14, 2015
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jan 30, 2015
@matthijsmelissen
Refactor water-features
a22e958 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Feb 4, 2015
@matthijsmelissen
Refactor water-features
d6c08fb 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Feb 28, 2015
@matthijsmelissen
Refactor water-features
5f98fd6 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 2, 2015
@matthijsmelissen
Refactor water-features
5e14c14 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 9, 2015
@matthijsmelissen
Refactor water-features
3d39b8a 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 14, 2015
@matthijsmelissen
Refactor water-features
dee07be 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 14, 2015
@matthijsmelissen
Refactor water-features
876f4df 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, weir, and lock_gate
* Improve labels for dam lines and lock lines
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 16, 2015
@matthijsmelissen
Refactor water-features
0532e06 
Dam, weir, lock:
* Add rendering for dam areas (supercedes and closes gravitystorm#227, based on code by
  @chrisfleming), dam and weir nodes, and lock_gate line
* Render weir in right layer (resolves gravitystorm#403)
* Change rendering of weir so it renders with small dashes
* Use marker instead of image for lock_gate node
* Add labels for dam nodes, dam areas, and weir
* Improve labels for dam lines and lock lines
* Don't render label for lock=yes
* Remove labels for undocumented and less common waterway=lock

Groyne, breakwater:
* Render groyne/breakwater area the same color as groyne/breakwater way
  (resolves gravitystorm#893)
* Add label for groyne, breakwater, and pier (resolves gravitystorm#474)

Other:
* In general rewrite and clean up code
@jbelien jbelien mentioned this issue Apr 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
water-features
Projects
None yet
Milestone
Bugs and improvements
Development

Successfully merging a pull request may close this issue.

Refactor water-features matthijsmelissen/openstreetmap-carto
3 participants
@gravitystorm @Krillle @matthijsmelissen