-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for tourism=apartment #401
Comments
I think that it would be overkill. Such features are not too important and in some areas it would result in a really bad rendering - there are towns where nearly every house rent apartments. airbnb and similar are making situation significantly worse for such rendering. I propose closing this request. |
Usage is also fairly low |
tourism=apartment are particularly popular and important in Austria, Germany, Switzerland and parts of northern Italy, but are widely distributed throughout Europe and the world. https://taginfo.openstreetmap.org/tags/tourism=apartment#map The current usage of tourism=apartment is relatively low, because mappers are massively inclined to use descriptive names and misuse tourism=chalet instead to get holiday apartments rendered. Examples from Austria and Italy/South Tyrol http://www.openstreetmap.org/#map=18/46.68174/11.07463&layers=N The number of the actually existing tourism=apartment are significantly higher than the low usage might imply on first sight. And to my experience they are almost always visible on spot due to outdoor advertising. I would suggest to render tourism=apartment with the same symbol as tourism=chalet, but starting at a lower zoom-level. Thanks |
Yes, this type of accommodation are also popular e.g. in Croatian places along the seashore, where every other house may rent some apartments (even most of a house may be designated for apartment rentals). They often have names (of the house/villa) and outdoor advertising, so they are visible on the spot. Rendering them would be useful. |
I like this suggestion - what about z18 for example? |
@kocio-pl z18 would be fine! |
I stayed at a tourism=apartment this SOTM, and I still believe it is something we shouldn't render. The visibility on the ground is very limited, so it doesn't help you with orientation. A specific apartment is unlikely to be a feature you are going to in an area because they have limited size. |
sent from a phone
yes, it depends;-) |
After reviewing the additional discussion I think the original decision to decline remains the right one. |
@pnorman could you please reiterate what the original decision was actually based on? In my opinion, I think that most (or all?) of the early arguments against rendering these objects have been falsified: For example the low usage numbers (see updated graph in #401 (comment)). Also, I haven't seen any example of where:
As far as I can see, the I find the current situation very annoying where people continue to actively misuse other tags such as |
sent from a phone
On 5 Mar 2017, at 18:26, Martin Raifer ***@***.***> wrote:
Actually, I think that it would not even make sense to map unsigned (even inside the building) apartments-for-rent, because that would simply be against OSM's on-the-ground rule!?
I'm not sure if it makes sense to map them, but it wouldn't be against the on the ground rule, as long as there are tourist apartments, signed or not.
|
…but if it's not signed, you cannot find out if there actually is a tourism apartment or not (except for checking on the airbnb website which is of course no viable source for OSM). One mapper might have stayed at such an "invisible" apartment, but others cannot verify it on the ground -> ergo it should not be mapped. Isn't that one of the basic working rules for mapping? edit: See http://wiki.openstreetmap.org/wiki/How_We_Map:
|
+1 According to taginfo by today there are 5.4 k occurrences in the db. Both of the main editors (iD and JOSM) provide presets for tourism=apartment.
+1 Another misused tag to get it rendered is tourism=chalet, like here So I would deeply like to ask for rendering! Thanks for considering |
sent from a phone
On 5 Mar 2017, at 19:05, Martin Raifer ***@***.***> wrote:
…but if it's not signed, you cannot find out if there is actually a tourism apartment or not (except for checking on the airbnb website which is of course no viable source for OSM). One mapper might have stayed at such an "invisible" apartment, but others cannot verify it on the ground -> ergo it should not be mapped. Isn't that one of the basic working rules for mapping?
we should continue this discussion on talk or tagging, but there are other means of finding it out, e.g. you see new tourists arriving every 3 days, you ask one of them, or they ask you for the way, you ask someone who is living there, ...
|
Thanks, didn't know this! You're right, JOSM was used just as a proof that somebody else thought about using part of the building too. If window in the background won't work, rendering guest house would be still preferable for me (with z18+ instead of z17+), because this would give us a benefit of "similar but smaller" association. BTW: your design reminds me that we could make hospital to be more neutral - mirrored red bed in the circle might work. |
Sorry, it's not meant sarcastic or arrogant, but there is a serious point. Apparently the participants in this thread are not graphic designers. My intention was to suggest that we seek some assistance from outside. |
Sure, it's my second choice exactly because they are not the same. However they are similar and if we have no better idea, making a difference by zoom level is still enough for me.
Yes, that sounds good to me! We would still have house vs room (house vs key) analogy plus we already have a small key element tested and used (bicycle station for example - "renting a bed" also sounds like plausible analogy 😄), so designing this icon should be easy. |
AFAIK we asked some time ago on mailing list and nobody was interested. If somebody has a good how to encourage people to contribute icons it can be done (or discussed in a separate issue if it involves some changes to a project). |
Added the bicycle key to the drafts above (4) - my favourite so far. The SVGs are in my gist. |
Thanks, 4 is exactly what I have envisioned for z18+! Could you prepare a PR with it? |
If you agree I would like to submit the topic for the next weeklyOSM. |
Good idea, it is better than posting to mailing list (that feels spammy for me to keep doing it again and again) and there is chance that somebody relevant will read it. In general any feedback is useful (except "why it is not yet implemented" comments or people posting "+1" instead of using reaction feature). |
I guess we need both icon designers and code newbies (osm-carto is specific project, so even if one knows SQL and git, there's still CartoCSS, cartographic POV and local conventions). There are tons of issues that can be fixed with a little guidance from maintainers mainly by extending/fixing current code, but even small feature takes some time and focus usually and I can't handle more than few of them at once, for example. Unfortunately there was no response from new people when I asked lately on Talk list if anyone is willing to join us and learn the basics. So we're still looking. |
Should do, probably, so the skills don't get rusty. |
I guess tidying should be separate (and simple) ticket. |
sent from a phone
On 12. Jan 2018, at 04:01, polarbearing ***@***.***> wrote:
What about my proposal with the two grey lines ? Not fully self-explanatory, but neither are chalet nor guest house.
+1, icon works for me
|
Got feedback, it's scheduled for the next edition (391). |
@dieterdreist - which one works better for you, the two grey lines or I spent last night setting up docker/kosmtik, was expecting this a bit more lightweight than it comes. |
For me the key in 4 is too vague/unspecific as most forms of accommodation provide you a key. I like the "bed with two grey lines" for its simplicity, resembling a room or flat. |
sent from a phone
On 13. Jan 2018, at 12:42, polarbearing ***@***.***> wrote:
two grey lines or
4, hotel bed with key from rental_bicycle (mirrored) ?
for me both are ok, but I’d prefer the grey lines “box”
|
Key version is more readable for me. |
Any more votes? Looks like a draw currently: |
Box +1 |
+1 for Light box (right). the dark box is too heavy |
+1 for light box right |
Thanks all for following up this ticket, for new fresh ideas and for nice preview picture. +1 for all three proposals (bed with light box, bed with dark box and bed with key icon) If I should tell my preferred order of these 3 options, it looks like:
|
Yes the reasons you name for the key version were what I thought as well. Anyway there were more votes for the box version, which also symbolises the situation well, thus why I made the PR with that icon. |
Since PR is ready, somebody needs to look at the code and test it, so now it's work for repo maintainers. |
For potential visitors from WeeklyOSM: rendering is added in #3024 - but if anybody has idea for a new, better icon of this object or any other - please open a new issue ( https://github.com/gravitystorm/openstreetmap-carto/issues/new ) |
Hello,
there is a new key tourism=apartment. Which is similar to tourism=chalet, but likely to be in more crowded areas. I suggest to render it with the same symbol as tourism=chalet, but starting at lower zoom-level.
thanks, nounours77
The text was updated successfully, but these errors were encountered: