-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing comma in fonts.mss may hide Armenian font #3986
Comments
Thank you for catching this bug, @Sjord - would you have time to submit a pull request to fix this bug? Here is a screenshot of Armenia at the moment: Compare with this sample of https://fontinfo.opensuse.org/fonts/NotoSansArmenianRegular.html I believe the style has been falling back to Unifont for rendering Armenian characters, but it would be good to fix this bug so that the Armenian characters match the usual style of the Noto font family which is normally used. |
Yes, I can make a pull request somewhere this week. |
Specifically, add a comma between "Noto Sans Adlam Unjoined Regular" and "Noto Sans Armenian Regular". The missing comma resulted in the Armenian font being missing from the generated Mapnik XML. Fixes gravitystorm#3986.
Add a comma between "Noto Sans Adlam Unjoined Regular" and "Noto Sans Armenian Regular". The missing comma resulted in the Armenian font being missing from the generated Mapnik XML. Fixes #3986.
Add a comma between "Noto Sans Adlam Unjoined Regular" and "Noto Sans Armenian Regular". The missing comma resulted in the Armenian font being missing from the generated Mapnik XML. Fixes gravitystorm#3986.
fonts.mss contains this:
There is no comma between Noto Sans Adlam Unjoined Regular and Noto Sans Armenian Regular. The result seems to be that Noto Sans Armenian Regular disappears from the created mapnik.xml:
After adding a comma after "Noto Sans Adlam Unjoined Regular", the Armenian fonts appear in the mapnik XML again.
I am not affected by this issue, and I am not familiar with Armenian mapping fonts. It was just something I noticed while working with these MSS files.
The text was updated successfully, but these errors were encountered: