Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing comma in fonts.mss may hide Armenian font #3986

Closed
Sjord opened this issue Dec 8, 2019 · 2 comments · Fixed by #3989
Closed

Missing comma in fonts.mss may hide Armenian font #3986

Sjord opened this issue Dec 8, 2019 · 2 comments · Fixed by #3989

Comments

@Sjord
Copy link
Contributor

Sjord commented Dec 8, 2019

fonts.mss contains this:

@book-fonts:    "Noto Sans Regular",
                "Noto Sans CJK JP Regular",
                "Noto Sans Adlam Regular", "Noto Sans Adlam Unjoined Regular"
                "Noto Sans Armenian Regular",
                "Noto Sans Balinese Regular",

There is no comma between Noto Sans Adlam Unjoined Regular and Noto Sans Armenian Regular. The result seems to be that Noto Sans Armenian Regular disappears from the created mapnik.xml:

  <FontSet name="fontset-0">
    <Font face-name="Noto Sans Regular" />
    <Font face-name="Noto Sans CJK JP Regular" />
    <Font face-name="Noto Sans Adlam Regular" />
    <Font face-name="Noto Sans Adlam Unjoined Regular" />
    <Font face-name="Noto Sans Balinese Regular" />

After adding a comma after "Noto Sans Adlam Unjoined Regular", the Armenian fonts appear in the mapnik XML again.

I am not affected by this issue, and I am not familiar with Armenian mapping fonts. It was just something I noticed while working with these MSS files.

@jeisenbe jeisenbe added the bug label Dec 8, 2019
@jeisenbe jeisenbe added this to the Bugs and improvements milestone Dec 8, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 8, 2019

Thank you for catching this bug, @Sjord - would you have time to submit a pull request to fix this bug?

Here is a screenshot of Armenia at the moment:

z7
z7-armenia-currrent

z8
z8-armenia-current

Compare with this sample of https://fontinfo.opensuse.org/fonts/NotoSansArmenianRegular.html
NotoSansArmenianRegular Armenian s

I believe the style has been falling back to Unifont for rendering Armenian characters, but it would be good to fix this bug so that the Armenian characters match the usual style of the Noto font family which is normally used.

@Sjord
Copy link
Contributor Author

Sjord commented Dec 9, 2019

would you have time to submit a pull request to fix this bug?

Yes, I can make a pull request somewhere this week.

Sjord added a commit to Sjord/openstreetmap-carto that referenced this issue Dec 10, 2019
Specifically, add a comma between "Noto Sans Adlam Unjoined Regular" and
"Noto Sans Armenian Regular". The missing comma resulted in the Armenian
font being missing from the generated Mapnik XML.

Fixes gravitystorm#3986.
jeisenbe pushed a commit that referenced this issue Dec 18, 2019
Add a comma between "Noto Sans Adlam Unjoined Regular" and
"Noto Sans Armenian Regular". The missing comma resulted in the Armenian
font being missing from the generated Mapnik XML. Fixes #3986.
Mortvola pushed a commit to Mortvola/openstreetmap-carto that referenced this issue Feb 14, 2020
Add a comma between "Noto Sans Adlam Unjoined Regular" and
"Noto Sans Armenian Regular". The missing comma resulted in the Armenian
font being missing from the generated Mapnik XML. Fixes gravitystorm#3986.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants