-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different rendering for barrier=kerb #3714
Comments
I very much agree. Barriers like walls and fences are physical impediments to passage for everyone (you must usually find a gate or stile), whereas kerbs hinder passage for some vehicles, but probably don't affect foot travel. I have sometimes hesitated adding kerb lines because they look like walls on OSM Carto, but they're also important for accessibility mapping. |
I would suggest removing the rendering of barrier=kerb, since it is not a significant barrier in the same sense as a wall, fence or hedge. |
Another option would be to render it later, say only on z18 or z19 and above, and with a slightly thinner line |
I agree with everything you've posted here. My only thought is that even with a lighter, thinner line, the kerb isn't significantly different than another barrier. If you were to see only a kerb on a map, you wouldn't have anything to compare to, so it would still be tough to differentiate. I don't have a better solution, though. I've seen versions of fences with a dash-dot-dash style, which made them very obvious, but that doesn't match the current barrier style of a solid line... By the way, if you want some more areas to play around with, here's my local park: https://www.openstreetmap.org/#map=18/38.40746/-82.43625 There are kerbs around the grass/highways, fences around the tennis courts, and walls by the fountain. |
This is true for many of our rendered features, unfortunately.
Dashed lines are problematic with computer-generated maps, because the dashes do not always behave well around corners or where objects meet or on curvy lines. But for fences I could imagine a few things that would work. We could add a wider square every 10 to 16 pixels, to symbolically represent a fence post, but this would only work at high zoom levels. In Europe it will look fine at z19, but at the equator the dots could look rather wide. It would be safe to something like this at z20. Retaining walls could have ticks on the low side of the barrier; this would also help remind mappers to draw the way in the correct direction. However, I'm not sure what to do for barrier=wall, the second most common type after barrier=fence. Many walls are just solid, but they are not necessarily wider than 10 or 20 cm. At z20 they could be rendered slightly wider than a pixel, but it might be too wide at z19 at the equator to go wider than 1 pixel. @imagico, how wide do you think walls could be rendered on z19? Do you know of any other standard ways of showing these features? |
I think that simply not rendering Note that we render |
Unfortunately this is still not clear. I worry that wall is so far away from kerb that it may be not doable to make both visible and properly different. |
How it works on other landuses, especially on area without landuse? |
I agree that rendering this - if at all - would only make sense at the highest zoom levels. The following order of doing things seems appropriate:
|
I tried a number of different renderings for If there is a reasonable way to render these features at z19 or even z20, I would be happy to see a PR or a rendering sample showing how it could work. However, currently kerbs are rendered the same as retaining walls, walls and fences, which are mostly tall barriers that prevent entry by pedestrians. Since barrier=wall and barrier=fence are used millions of times, the |
This can be seen at higher zoom levels by the fact that only one of the side of the dual-carriageway is connected to the other road. But rendering a kerb the same as a fence or wall suggests that pedestrians are physically prevented from crossing there, which is usually not the case. |
When you duplicate your arguments in different threads you force other to duplicate the answers, too. |
Even small fences are often either legal or social barrier for pedestrians. But I think that dropping rendering for extremely small fences is something worth considering. |
What do you mean by "extremely small fences"? |
Probably like some of the smaller side fences here, or even the short ones in the front yards. I actually had that idea myself, because sometimes when I look at the area the fences make it seem over mapped or they are just distracting. Although, getting rid of might make the then free standing gates look weird. |
Oh, I see. They define the space and the only problem would be only if they are seen too early, but they're not and I have no problem with them currently. |
Maybe you could do something where fence ways of a certain pixel number don't render or render at a different zoom level. It seems like it would lead to a massive amount of inconsistency though. |
The context is the comments above:
So we are talking about a "fence" that is so short that you can walk over it, rather than having to jump or climb. I agree that a (But this is just in theory: it does not appear that there are enough fences tagged with such small values of |
I say keep rendering of curbs in the code as they are , but push them to z20 for now. Then revisit the issue later when z20 is implemented. They aren't ultimately that important and I think its only useful to display them really zoomed in, but z19 doesn't seem like zoomed close enough. I also think it will help justify z20 rendering later on if we are like "here's specific things that we want to render at this zoom level" and having them ready ahead of time (if I remember correctly there's already something else that only renders at z20. So its not a stretch). |
I find that a very odd approach, like "I don't like your items in the living room, but you can push them to the attic". As one important purpose of this style is to give mappers feedback, "pushing" something into invisibility of a not-yet-implemented z level does not work for me. |
I find the defense of the status quo without any arguments a bit problematic here and not suited to achieve consensus. Without any arguments means that the clearly argued point that rendering a kerb the same way as a hard barrier like a wall or fence or hedge (these are the three barrier values with more than a million uses and the cases the current barrier rendering is designed for) is clearly confusing and counterproductive for map legibility and mapper feedback has not received any rebuttal (beyond the whataboutism regarding fences you can step over). In other words: Everyone who is in defense of the status quo in rendering of barrier=kerb should IMO provide substantial arguments why the current rendering is positive in your eyes. If the consideration is merely that maintaining the status quo is the only way to keep rendering kerbs since there is no chance of rendering kerbs in any way would achieve consensus that would essentially be a declaration of bankruptcy of productive cartographic development here. Side note: By rendering barriers with a catch-all until #1986 we are largely responsible for the invention of barrier=kerb as a textbook tagging for the renderer. We failed to correct this in #1986 unfortunately. |
Not sure who you mean - I don't defend the status quo, I said before I'd be happy with a lighter/thinner rendering of kerb at later z level, as long as it remains visible in the current installation. There were examples of such thinning in this thread previously. |
But you have not yet address the problems mentioned with that. Several comments above have given good reasons why a slightly thinner rendering of kerbs, but otherwise similar to fences/walls, will not work: "even with a lighter, thinner line, the kerb isn't significantly different than another barrier. If you were to see only a kerb on a map, you wouldn't have anything to compare to, so it would still be tough to differentiate." #3714 (comment) #3714 (comment) #3714 (comment) #3969 (comment) #3969 (comment) "It also interferes with map Legibility and clarity when very different features are rendered [similarly]. "The map should be intuitively readable by users with some general experience using maps without a map key, preferrably with relatively little effort" - Line 34, CARTOGRAPH.md" |
I'm not sure what's odd about that considering there's already other things that only render at Z20. At least I thought there was. I could be wrong though. Even if not, there must be other styles out there based on this that have z20 implemented and would benefit from kerbs being rendered at that point even though we might not, for now. Really I'm just trying to find a good compromise. As @jeisenbe says thinner rendering probably isn't an option, nothing else so far has worked, and there doesn't seem to be other ideas at the moment. I don't find @imagico's whole thing about completely removing features from the code just because there isn't currently a viable way to improve them, when there could possibly be one in the future, a compelling option either. There's a lot more chance of someone with a new idea coming along if the code is still there and they are still visible in some maps, if not this one for now. Even with this style it's highly possible a solution would come along between now and z20 being implemented that would be easier to test with kerbs being rendered at z20 where Kosmtik still goes to. But as @imagico say's sticking to the stat quo isn't good either. So, it's a good middle ground in my opinion between something drastic (full removal), and doing nothing (leaving as is). Neither of which are good options IMHO. |
Yes, the approach of @Adamant36 is the right one here - making concrete suggestions of what to do. I don't like the idea either but bringing forward and arguing about concrete ideas is what brings us forward in cases like this. |
Your comment here suggests that this is quite new approach, if I understand your opinion right, but concrete suggestions on the changes (here or in the PR) were given already. I plan to write more about them soon. |
Suggestion from #4230:
I’ve already attempted test renderings with this feature as "a light gray line” but this did not work even at z19. Adding hatching or arrows on one side would be similar to a retaining wall or embankment or cliff. This might be feasible at very high zoom levels like z21 (as shown in the example from JOSM) but not at z19, currently the highest level available in many deployements of this style (including on openstreetmap.org) |
barrier=kerb has the same rendering as barrier=wall so there is no difference between a kerb and a wall on the map.
It could be rendered as a dashed line. Here is a example of the french cadastre were the dashed lines are kerbs.
The text was updated successfully, but these errors were encountered: