-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for roller_coaster #3596
Comments
I guess for this rare type of objects it's enough for rendering with 920 uses: https://wiki.openstreetmap.org/wiki/Tag%3Aroller_coaster%3Dtrack |
I think this is quite specialized, and I'm not sure about rendering it on a general purpose map. |
@matthijsmelissen, personally id disagree. They aren't any specialized then other similar things like racing tracks or water slides that are already rendered. Also, they can take up fairly large areas, where you can't go under or around them safety reasons. So without rendering them your essentially advocating for large blank spots, that look like places people can go when they aren't. Not to mention as the issue states anyway, they are already being rendered through wrong tagging anyway. So its just fixing miss-tagging if nothing else. |
The https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dtheme_park#Related_tags page lists railway=narrow_gauge as what is to be used until railway=roller_coaster is a thing. So I guess one of those pages should change (probably this one?). |
They are quiet big and good for orientation. |
I would consider rendering track with one of railway styles. In the ideal world it would not be shown on general purpose map but unfortunately tagging for renderer is extremely popular here. Unfortunately, it seems that choice is between "render roller coaster track" and "render roller coaster track mistagged as railway". |
We already render |
it seems that choice is between "render roller coaster track" and "render roller coaster track mistagged as railway".
True. And roller coasters should not be rendered so early as railways. The mistagged examples look very strange at mid-zoom levels.
|
As you said, a roller coaster track pretty much is a miniature railway. So you could just render |
I've looked into the use of attraction=roller_coaster and roller_coaster=track in the context of deciding what tags to import as polygons during the next database reload. Both tags are frequently used to tag the tracks of roller coasters. Attraction=roller_coaster is mapped as an unclosed way 1,572 times (8-April-2019) and roller_coaster=track has 1483 uses on unclosed ways, so the two methods of tagging are about equally popular. For rendering the track there is no problem about the database, because ways are imported as linestrings by default. If we want to render the label of the attraction based on polygons, this would require a change, however. I would recommend that @geozeisig reopen the proposal process for roller_coaster=track with a RFC (request for comments) on the tagging mailing list, and then get it voted on. Then we might need to wait till roller_coaster=track is clearly the more popular choice (assuming that this is accepted by the community) One issue to consider is how the routes of other types of attractions should be tagged and rendered. Currently, "attraction=dark_ride", "=river_rafting", "=summer_toboggan", "=train", "=water_slide" and "=slide" are usually mapped as open ways and the ID editor supports this for all except slide (and roller_coaster). River_rafting and water_slide are often mis-tagged as waterway=canal for rendering, and it would be good to develop a rendering that would discourage this practice. In particular, attraction=train might need to be considered along with roller coasters, but it's unclear what this tag means. |
I'd support using the same rendering at However, as I mentioned above, we should clarify if |
Now 2/3rds of ways are double-tagged with roller_coaster=track + |
I can not explain it either. The wiki is clear. Now I asked a couple of people why they do it that way. |
I support the rendering of this feature. They are contained within specific areas so no overlapping with other 'general purpose' features. Miniature railways & waterslides, of similar size & locations are already rendered. Using the same render as railway=miniature way seems appropriate, but with a 'bridge' style edging to indicate it is elevated. |
@geozeisig And that's only the correctly tagged ones. There are many falsely tagged as railway=* to force the rendering. |
There's 87 instances of |
Bump, proposal to render the same way as railway=miniature. |
I'd be interested to know what the tagging numbers for the various options are now. Maybe someone can create a graph or something? |
|
Hhhmmm, thanks. Roller_coaster=track is the clear favorite there and 5,166 uses should be enough to justify rendering it. |
I just noticed that a rollercoaster I added is not getting rendered, and that brought me here. Looks like the consensus is that it should be rendered, but doesn't look like it got any further (please correct me if either of these are not the case). I'm a bit of a dev (but have never looked into osm code), so I might consider figuring out how to create a PR for this if I get time |
Apologies if I'm misunderstanding what you said but there are situations where a rollercoaster is not an exclusive feature at a given location. I know of rollercoasters that have food vendors and other attractions and features below the tracks. Additionally I know of a location that's building a rollercoaster intertwined with a log flume ride. |
"'general purpose'" |
Still not included? Why does the change to render roller coasters takes so long? For now there are multiple ways coasters get mapped in OSM, because there is no useable Line-Typ for the tracks that gets rendered. |
There is no change that has been proposed - this is a feature request that no one has submitted a PR for. |
Hi Friends. What is the status of roller_coaster=track. Don't see it on the OSM map yet. Thanks. |
#4666 has been merged but we have not made a release since then so the change is not yet visible in the map. |
The track should be mapped with roller_coaster=track. An example is this and there are even more next door. A narrow black line should be drawn on the map. At the moment, unfortunately, many use railway=* to get the track rendered. On the Key:attraction-page this is expressly disapproved (Do not tag them as any railway!). Since the track is meandering the name should not be placed here.
For the attraction, another node or area should be drawn on which the name stands. The name should be added in black. You could also add tourism=attraction, but that would be too much importance to the roller coaster.
The text was updated successfully, but these errors were encountered: