-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighten gray color for man-made icons #3500
Comments
Three lighter gray options. I like option 3 best (#777777) Honolulu, z14 - 4 towers
Ala-Wai Park - stadium lights Diamond Head Lighthouse* Mauna Kea Telescopes Hunting Shelters https://www.openstreetmap.org/#map=16/47.8931/16.1289 Here's a hunting shelter in a patch of forest (from the same area as above): |
I like 777 the most. |
I am not convinced that any of given examples really needs fixing. |
Are you sure you can recognize this color from black? |
I am not sure why it would be necessary. |
I guess man made color is not black to avoid being too heavy. If it looks like black, it's probably too strong. |
I don't have a problem with current man-mage-grey shade, so I wouldn't change anything. But if you need to, I wouln't go any lighter than a |
I like #666666. Its better then the current color. Also, I agree with @Tomasz-W about not going any lighter than that. Maybe #777777 which looks good on the telescopes but not other things. #888888 is going to light though. |
thanks, jeisenbe, for showing the different examples. For me it's not a matter of having problems rather than wanting to see a map where color saturation fits together and results in a harmonic style. |
Roof top towers (with |
I noticed that wayside crosses and man_made=cross are rendered as #000000
(black) instead of man-made icon gray.
Also wind power generator icons are black
Should these be fixed? Do I need to open a new issue?
…On Thu, Nov 8, 2018 at 7:14 PM Adamant36 ***@***.***> wrote:
Btw, there is an issue which I plan to do a PR for eventually that would
make smaller items like benches be rendered in man made grey. So if its to
light of a grey color it might make smaller poi's like those harder to see.
Especially in residential areas. I suggest either making two different man
made grey colors based on size of thing being rendered, or test benches etc
in the new grey color to make sure they arent harder to see. That being
said, it might be worth waiting for that issue to get done before this one
is dealt with.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3500 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshMTUj2-P57mx1de2krxwJf0kFAexks5utAPygaJpZM4YSlx7>
.
|
I'm sure we would left black icons for religion map elements, but the thing to consider is to:
Actually black power generators and cranes fits for me. What about including all default-tall |
I think the cranes looked too dark with the black renderings (those I
showed with the png), so I would move wind turbines to man-made-gray.
I can understand about using black for place_of_worship and wayside
shrines/crosses.
…On Fri, Nov 9, 2018 at 10:01 PM Tomasz Wójcik ***@***.***> wrote:
I noticed that wayside crosses and man_made=cross are rendered as #000000
(black) instead of man-made icon gray.
Also wind power generator icons are black
I'm sure we would left black icons for religion map elements, but the
thing to consider is to:
- use black also for other things, but then we shoud describe which
groups should it include (to have a clear rule for the future)
or
- move all black non-religious icons to man-made-grey
Actually black power generators and cranes fits for me. What about
including all naturally tall man-made objects in black category? It would
include towers, power generators and cranes. I think it would be reasonable
as we moved/ added many new things to man-made-grey recently. What do you
think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3500 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshLohethrjndX-tmrtO19t3MiTCc3ks5utXzCgaJpZM4YSlx7>
.
|
In general it's a good idea to try to categorize different types of POIs depending on their tagging as man-made, place of worship (...) with one same colour. Category colors shouldn't depend on the tagging but the function of the item. etc. Yes, wind turbines, cranes and hunting stands to man-made-gray would be a |
As sometimes some man-made-grey feature looks black (like religious), I think that going down with |
I vote for #666666 for the reason @Tomasz-W stated. |
I will try #666666 in the open PR #3516
…On Fri, Nov 16, 2018 at 4:53 PM Adamant36 ***@***.***> wrote:
I vote for #666666.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3500 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshNgADvGk0GmMPUKhk7iwq81cH8Hyks5uvm8BgaJpZM4YSlx7>
.
|
why not add halo ? or specific color contrast on grey element same as railway??? This problem exist for all points and we need change color regulary in case of contrast with sub elements lines or polygones |
Resolved by #3516. |
Related to #1587
Some have complained that hunting stands are too prominent with the current man-made icon color, #555555. Tall towers and cranes in cities can also appear rather too prominent at zoom level 14, where they are one of the only icons shown. It is suggested to change to a slightly lighter gray.
Hunting Shelter, z19
Honolulu, z14 - 4 towers
https://www.openstreetmap.org/#map=14/21.3049/202.1434
Hunting Shelters https://www.openstreetmap.org/#map=16/47.8931/16.1289
Ala-Wai Park - stadium lights
https://www.openstreetmap.org/#map=18/21.28711/202.17081
Diamond Head Lighthouse*
https://www.openstreetmap.org/#map=15/21.2574/202.1878
Mauna Kea Telescopes
The text was updated successfully, but these errors were encountered: