Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighten gray color for man-made icons #3500

Closed
jeisenbe opened this issue Nov 7, 2018 · 20 comments
Closed

Lighten gray color for man-made icons #3500

jeisenbe opened this issue Nov 7, 2018 · 20 comments

Comments

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 7, 2018

Related to #1587

Some have complained that hunting stands are too prominent with the current man-made icon color, #555555. Tall towers and cranes in cities can also appear rather too prominent at zoom level 14, where they are one of the only icons shown. It is suggested to change to a slightly lighter gray.

Hunting Shelter, z19
shelter-z19-555

Honolulu, z14 - 4 towers
https://www.openstreetmap.org/#map=14/21.3049/202.1434
honolulu-z14-555

Hunting Shelters https://www.openstreetmap.org/#map=16/47.8931/16.1289
shelters-z16-555

Ala-Wai Park - stadium lights
https://www.openstreetmap.org/#map=18/21.28711/202.17081
alawai-z18-555

Diamond Head Lighthouse*
https://www.openstreetmap.org/#map=15/21.2574/202.1878
diamond-z15-555

Mauna Kea Telescopes
maunakea-z16

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Nov 7, 2018

Three lighter gray options. I like option 3 best (#777777)

Honolulu, z14 - 4 towers
https://www.openstreetmap.org/#map=14/21.3049/202.1434

  1. Original, Resolve wrong layering of low-zoom layers #555=555555
    honolulu-z14-555

  2. Slightly lighter #666666
    honolulu-z14-666666

  3. Lighter gray, lucky #777777
    honolulu-z14-777

  4. Even lighter #888888
    honolulu-z14-888

Ala-Wai Park - stadium lights
https://www.openstreetmap.org/#map=18/21.28711/202.17081

  1. #555555
    alawai-z18-555

  2. #666666
    alawai-z18-666666

  3. #777777
    alawai-z18-777

  4. #888888
    alawai-z18-888

Diamond Head Lighthouse*
https://www.openstreetmap.org/#map=15/21.2574/202.1878

  1. #555555
    diamond-z15-555

  2. #666666
    diamond-z15-666666

  3. #777777
    diamond-z15-777

  4. #888888
    diamond-z15-888

Mauna Kea Telescopes

  1. #555555
    Stop me if you've seen this one before...
    maunakea-z16

  2. #666666
    maunakea-z16-666666

  3. #777777
    maunakea-z16-777

  4. #888888
    maunakea-z16-888

Hunting Shelters https://www.openstreetmap.org/#map=16/47.8931/16.1289

  1. #555555
    shelters-z16-555

  2. #666666
    shelters-z16-666

  3. #777777
    shelters-z16-777

  4. #888888
    shelters-z16-888

Here's a hunting shelter in a patch of forest (from the same area as above):

  1. 555
    shelter-z19-555

  2. 666
    shelter-z19-666666

  3. 777
    shelter-z19-777

  4. 888
    shelter-z19-888

@kocio-pl kocio-pl added the new features Requests to render new features label Nov 7, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Nov 7, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 7, 2018

I like 777 the most.

@matkoniecz
Copy link
Contributor

I am not convinced that any of given examples really needs fixing.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 7, 2018

Are you sure you can recognize this color from black?

@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 7, 2018

Are you sure you can recognize this color from black?

I am not sure why it would be necessary.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 7, 2018

I guess man made color is not black to avoid being too heavy. If it looks like black, it's probably too strong.

@Tomasz-W
Copy link

Tomasz-W commented Nov 7, 2018

I don't have a problem with current man-mage-grey shade, so I wouldn't change anything. But if you need to, I wouln't go any lighter than a #666666

@Adamant36
Copy link
Contributor

I like #666666. Its better then the current color. Also, I agree with @Tomasz-W about not going any lighter than that. Maybe #777777 which looks good on the telescopes but not other things. #888888 is going to light though.

@cepesko
Copy link

cepesko commented Nov 8, 2018

thanks, jeisenbe, for showing the different examples. For me it's not a matter of having problems rather than wanting to see a map where color saturation fits together and results in a harmonic style.
POIs with little relevance (and height) like hunting_stands should blend in with the other features. and not be overly outstanding. Therefore #666666 or even #777777 would be my favourite for these.
Towers and antennas could keep a stronger gray, maybe in the future depending on their height-tag if too many inner-city roof communication antennas show up.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 8, 2018

Roof top towers (with location=roof or location=rooftop), including broadcasting towers are not rendered at all.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Nov 8, 2018

I agree that 888888 is too light. 777777 is fine in most places, but it may be too light over train tracks and other very dark areas. For example, this crane in Milan is right over main line tracks, which have a very dark gray outline.

Would 666666 work?

Train station with crane over tracks in Milan
Current z14, #555555
z14milano
Current z15
z15milano
Current z16
z16milano

z14 666666
z14milano-666
z15 666666
z15milano-666
z16 666666
z16milano-666

z14 777777
z14milano-777
z15 777777
z15milano-777

Port of Venice z17
Current 555
z17venice
666666
z16venice-666
777777
z16venice-777

Singapore z14
Current 555
z14singapore-future
666666
z14singapore-666
777777
z14signapore-777

Blauer Kran, Germany, z16
Current 555
z16blauer
666666
z16blauer-666
777777
z16blauer-777

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Nov 9, 2018 via email

@Tomasz-W
Copy link

Tomasz-W commented Nov 9, 2018

I noticed that wayside crosses and man_made=cross are rendered as #000000
(black) instead of man-made icon gray.

Also wind power generator icons are black

I'm sure we would left black icons for religion map elements, but the thing to consider is to:

  • use black also for other things, but then we shoud describe which groups should it include (to have a clear rule for the future)
    or
  • move all black non-religious icons to man-made-grey

Actually black power generators and cranes fits for me. What about including all default-tall man-made objects in black category? It would include towers, power generators and cranes. I think it would be reasonable as we moved/ added many new things to man-made-grey recently. What do you think?

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Nov 9, 2018 via email

@cepesko
Copy link

cepesko commented Nov 9, 2018

In general it's a good idea to try to categorize different types of POIs depending on their tagging as man-made, place of worship (...) with one same colour.
However it's well-known that these tagging schemes developed over time and POIs often don't fit in their categories (e.g. wayside_cross = historic vs. place of_worship vs. man_made).
Therefore trying to strongly keep a consistency with tagging categories sometimes doesn't represent real categories.
Example 1: The "amenity" hunting_stand is an amenity for a very limited number of persons, mostly just one, its owner. Aditionally it's not a landmark like the bell_tower of a church. I would therefore give it a light grey.
Example 2: A lighthouse is a big solitary landmark and would get a stronger man_made_grey since more people use it for orientation.
Example 3: A wind_generator very often is part of a wind_farm and, although it is tall, shouldn't dominate the map and would get a lighter man_made_grey.
Importance should play the most important role and change saturation of color.

Category colors shouldn't depend on the tagging but the function of the item.
In issue #3483 there's the idea to change the color of shelters at bus stops to public-transport-blue, which I support as it's part of the transport infrastructure.

etc.

Yes, wind turbines, cranes and hunting stands to man-made-gray would be a

@Tomasz-W
Copy link

As sometimes some man-made-grey feature looks black (like religious), I think that going down with #666666 might be an improvement.

@Adamant36
Copy link
Contributor

Adamant36 commented Nov 16, 2018

I vote for #666666 for the reason @Tomasz-W stated.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Nov 16, 2018 via email

@geostonemarten
Copy link

geostonemarten commented Nov 22, 2018

why not add halo ? or specific color contrast on grey element same as railway???

This problem exist for all points and we need change color regulary in case of contrast with sub elements lines or polygones

@kocio-pl
Copy link
Collaborator

Resolved by #3516.

@jeisenbe jeisenbe added amenity-points and removed new features Requests to render new features labels Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants