Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake natural=spring as dot+icon #3461

Open
kocio-pl opened this issue Oct 19, 2018 · 25 comments
Open

Remake natural=spring as dot+icon #3461

kocio-pl opened this issue Oct 19, 2018 · 25 comments

Comments

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 19, 2018

Follow up to #3189, #3253 and #3274.
Proof of concept code is here (based on v4.10.0): master...kocio-pl:spring-dot

I'm not satisfied with our new spring rendering. It was based on a clever idea, but in practice it's not too good. My proposition is to get back to the original "s"-based design and follow the way we're rendering fountains. Here's why:

  • it's best not to use letters and stay with geometric shapes ("s" may be misleading in other languages than English)
  • on medium zoom levels we need just something to spot, and since we already have blue dot as a symbol of a fountain, it should be easier to get the meaning (man made or natural water source)
  • on higher levels there's enough space to show real icon depicting object, so it's clear that this is not a fountain
  • it fixes the problem of rendering on water areas
  • dot is smaller than ring

I also tried to make both dots and labels more visible, so I used the same darker blue color as fountain and made bigger halo.

Examples:

Named spring is better visible than currently

Before
hgkypdhd

After
ll8xgnpg

Spring in the middle of a water area

_mimirc
epsvrlfa

Lot of springs on the grass (even better than "s")

Long before
yei2krqw
After
_uohlkab

Lot of springs in the forest

wmkncwpn

Lots of springs on bare ground

lpnitxka

real icon on z18+ does not make clutter even on crowded places

ucejbs8i

mnvimnfy

@polarbearing
Copy link
Contributor

I'm a bit confused if you are proposing the 's' again or the fountain symbol, and which are the before/after examples?
Will that fix #1482 also?
Is there a test with a spring being a node on waterway=river (not only stream)?

@Tomasz-W
Copy link

My remarks:

  • proposed white outline is definetely too wide
  • proposed icon looks more like a fountain icon

I would go with a blue dot with thiner outline on all zoom levels.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Oct 20, 2018

Thanks for reactions. It looks like this solution makes sense in general, so we can look more into details.

@polarbearing Sorry for a confusion, I was sure that everyone knows how it looks today and I wanted to sketch a solution before anything more detailed. I have now added before/after when needed, all the other images are planned "after".

My proposition is to redesign it close to the initial "s" idea, but replace the letter with dot instead for medium zoom and show spring icon at high zoom.

I thought that it will be clear that it's not a fountain icon (because it's simple, not symmetrical and lacks the plate at the bottom). However if there is a problem with recognizing, we could use also another icon from Osmic (https://github.com/gmgeo/osmic/blob/master/nature/spring-14.svg): spring-14 I like it less, but it's still perfectly acceptable for me - and maybe @Tomasz-W could make some other design.

@Tomasz-W I was worried that thinner outline will make it harder to spot - similar to the way "s" on the grass looks like with smaller outline. I just made the outline to be a bit blue instead of pure white to make it less aggressive. This is natural feature, which is typically in the outdoor, so I assume that visibility is important and should be highlighted.

Further comments and ideas?

@kocio-pl
Copy link
Collaborator Author

It's worth to notice that @imagico in his fork has lately gone further with ring design:

http://blog.imagico.de/the-way-of-the-water/

In general what I like there is systematic approach and consistency on drawing board, but the downsides for me are very weak visibility in practice (I was surprised that all the example images were hardly visible, even as demo!) and trying to push everything into one universal shape, so it's mediocre at medium levels and mediocre at high levels (instead of small icon in medium levels + big icon in high levels).

I see more problems with that, but these are essential. Yet maybe there are some interesting ideas we could use or be inspired by.

@kocio-pl
Copy link
Collaborator Author

Making the outline 1,5 px instead of 2 px works worse for me in the forest and much worse on the grass:

beirneyr
v0cnz ik
qvya_mbw

@kocio-pl
Copy link
Collaborator Author

Using different icon on z18+:

q5c81be

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 20, 2018 via email

@jeisenbe
Copy link
Collaborator

@imagico has addressed the issue of water features having poor contrast on scrub and forest/wood backgrounds by darkening the color of streams and rivers, and his new spring icons match this color. I think this is a great idea, and it would also encourage mappers to correctly tag river water polygons with water=river (or natural=riverbank), not just natural=water alone.

I like how the spring icons are aligned to the waterway, and fit the size of the line. Hopefully this code would not be too difficult to implement?

The images also show similar stylized icons for water wells, water taps, hot springs, fountains and geysers:

z15 spring with stream

z16 spring only

z18 spring with stream

z14-z16

z18

@kocio-pl
Copy link
Collaborator Author

Changing water colors means solid changes in the style and AFAIK was important reason for making this fork in the first place. The idea was using 3 colors for different type of water, which I find not solving any problem we have with visibility, while creating big one with technical requirements. We have a ticket for this which is still not resolved.

I'm very surprised that you feel rendering from the forest are readable - for me they don't work at all in this respect. I can see the springs only because this is small image and I'm looking for them, yet it's not easy. Looking at full map I wouldn't be aware that there is any spring. And this is the easy case where the spring is properly attached to a stream, so I can follow the water to find if it begins with a spring. Alone spring node would be even harder to find, I guess.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 21, 2018 via email

@kocio-pl
Copy link
Collaborator Author

I don't know, but I don't think this would help.

@Tomasz-W
Copy link

Tomasz-W commented Oct 21, 2018

I like version with 1,5 px outline. Second icon is also not good for me and I don't have idea for a better one (anyway I think we should use simple geometrical shapes for natural objects), so I still suggest to use a dot on all zoom levels.

@kocio-pl
Copy link
Collaborator Author

Don't you have a problem recognizing them, especially on the grass?

@Tomasz-W
Copy link

@kocio-pl No, it's OK enough for me.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 21, 2018

I would definitely consider how we could render geysers and hot springs, which are both types of springs in a geological sense, but have quite different appearance and utility for people. Geysers and hot springs are often tourist attracts, but can also be dangerous, and they are not sources of drinking water like ordinary springs. Both tags, natural=geyser and natural=hot_spring, are used often enough to deserve an icon, I believe:
https://wiki.openstreetmap.org/wiki/Tag:natural%3Dgeyser
https://taginfo.openstreetmap.org/tags/natural=geyser

https://wiki.openstreetmap.org/wiki/Tag:natural%3Dhot_spring
https://taginfo.openstreetmap.org/tags/natural=hot_spring

Perhaps I should open a different issue for these two, but I think we should keep them in mind while working on the spring icon, especially because it would be nice if hot_spring was similar to the natural=spring icon, but sufficiently distinctive.

@kocio-pl
Copy link
Collaborator Author

That's what I really like in his proposition (bringing up some special types of springs) and I agree that it's good to remember, however their usage is too low now.

They will be more popular for sure, but the possible scenario might be that they will be just a subtag of spring, just like it happened with fjords (natural=fjord is discouraged and natural=bay + bay=fjord should be used instead). However if this is settled down on Tagging, I would be happy to render them too.

taghistory 15

@lakedistrictOSM
Copy link

How important is it for them to be rendered so early, given that they're small features? Even in rural areas they seem too prominent on the map. They can be found in urban areas too, where the current rendering really is too early: https://www.openstreetmap.org/#map=14/51.2446/-0.1911

image z14

image z15

@polarbearing
Copy link
Contributor

they're small features

They are not always small, there is a magnitude scale for them which I digged up in one of the earlier spring threads.

@kocio-pl
Copy link
Collaborator Author

I'm not aware of big springs other than being located inside some water area (@polarbearing could you give a link to something like this?). I'm rather thinking of springs as the outdoor object, and we try to exaggerate them, because in the outdoor there is much more free space. Even when they are located in the urban area, they tend to be in some park or other natural environment, as in your example, and they are not disturbing for me.

@dieterdreist
Copy link

dieterdreist commented Oct 28, 2018 via email

@polarbearing
Copy link
Contributor

One thing I was observing is Big Spring Missouri, https://www.openstreetmap.org/node/5442671644, which is mapped as a node a body of water and starting a river way, currently invisible.
When debugging the invisibility I also found cases of springs as middle nodes in rivers.
There are also some springs mapped as area, which overpass will show easily.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Nov 10, 2018

It would be possible to improve the rendering of springs by simply moving the icon back to the normal amenity-points layer, so that it layers over waterways, paths and other background objects:

Sink and Rise in Wyoming
Current z14
rise-z14-circle
Current z16
rise-z16-circle
New z14
rise-z14-over
New z16
rise-over-z16

@jeisenbe
Copy link
Collaborator

Temple in Japan
Lots of these Shinto temples seem to have wells and springs
Current z17
japan-temple-z17-circle
New z17
japan-springs-over-z17

Castle in Japan
Current (plus well pump) z18
japancastle-circle-z18
New z18
japan-castle-over-z18

It also might help to use a slightly more saturated color for the spring icon, such as that used for waterfalls; see the next comment.

@jeisenbe
Copy link
Collaborator

But I would prefer to use these icons. I believe it is helpful to have a smaller icon at z14 and z15, and larger at z16 to z17. If needed, we could also make a slightly larger icon for z18 and 19, but I find it big enough.

Sink and Rise, Wyoming
z14
sinkrise-z14
z16
sinkrise-z16
z18
sinkrise-z18

Forest temple in Japan
I recall there is concern about rendering on forest / dark backgrounds
z15
japanforest-z15
z16
japanforest-z16
z17
japanforest-z17

Hotsprings in the city
This is a very Japanese thing; I've not found urban hot springs anywhere else. Many of these are attached to public bath houses. (Note: no current rendering for hot springs to compare)
z15
japancity-z15
z16
japancity-z16
z17
japancity-z17
z18
japancity-z18

Scotland rural springs and caves
z14
scotland-z14
z15
scotland-z15
z16
scotland-z16
z17
scotland-z17

Red Butte, California
z14
redbutte-z14
z15
redbutte-z15
z16
kangaroo-z16
z17
redbutte-z17

Springs, Geysers and Hot Springs Oh my! (Old Faithful, Yellowstone)
z15
oldfaithful-z15
z16
oldfaithful-z16
z18
oldfaithful-z18

Italian hot springs - mapped as ways
z14
italy-z14
z17
italy-z17

Village in Japan - touristy place with named hot springs, lots of hotels and travel icons in blue
z16
japanvillage-z16
z17
japanvillage-z17

(If we want larger spring icons for higher zoom levels, I would suggest making the semicircle slightly larger, and adding very slight S-shaped curve to the line exiting the spring at the bottom. This would be more similar to USA topographic map icons. @Tomasz-W ?)

@HolgerJeromin
Copy link
Contributor

This is a very Japanese thing; I've not found urban hot springs anywhere else.

Aachen has springs in the city as well:
https://www.openstreetmap.org/#map=18/50.77686/6.08826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants