Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render highway=street_lamp at z=19 #3277

Open
dktue opened this issue Jun 25, 2018 · 56 comments
Open

render highway=street_lamp at z=19 #3277

dktue opened this issue Jun 25, 2018 · 56 comments

Comments

@dktue
Copy link

dktue commented Jun 25, 2018

Streetlamps don't show up on the map, yet but I think it would encourage mappers to add them to OSM if they could see that they are actually being rendered.

At zoomlevel 19 this should cause no harm.

@sommerluk
Copy link
Collaborator

What is the average distance between two street lamps

Consider this place at z19: https://www.openstreetmap.org/#map=19/5.32128/-4.02055 If you have a street lamp each 10 m, than this would clutter the map a lot. Even with 30 m distance this would still be a clutter. Maybe z21 would work… (However, while this style has some support for zoom levels higher than z19, at osm.org is rendered only up to z19)

@dktue
Copy link
Author

dktue commented Jun 25, 2018

I tried to find the most densely tagged area possible where street lamps are tagged:

http://overpass-turbo.eu/s/zOi

The link shows a map at level 17. I guess at level 19 there would be not harm.

@dktue
Copy link
Author

dktue commented Jun 25, 2018

I like your examples and I'd love to see a subtle streetlamp-icon in them like JOSM shows when editing data. :-)

@kocio-pl kocio-pl added this to the New features milestone Jun 25, 2018
@kocio-pl
Copy link
Collaborator

Maybe we should render them just like bollards, since in practice they are also the obstacle and sometimes the bollard in the row is omitted just because the lamp is there.

@kocio-pl
Copy link
Collaborator

Example of the street lamps being part of a bollard line - at z19 it makes perfect sense for me to show them the same:

https://www.openstreetmap.org/#map=19/52.23969/20.99598
screenshot-2018-6-28 overpass turbo

@pnorman
Copy link
Collaborator

pnorman commented Jun 29, 2018

What's the use-case for showing street lamps?

@dktue
Copy link
Author

dktue commented Jun 29, 2018

In some cities they are being used in emergency cases to locate the caller. To do this, the lamps are being marked with a big label containing a number.

On the other hand? Why show bollards that are not part of a highway=* ?

@dieterdreist
Copy link

dieterdreist commented Jun 29, 2018 via email

@Tomasz-W
Copy link

Tomasz-W commented Jun 30, 2018

I'm against. Of course, there are some places where rendering a lamp may be useful, but in 99% cases, it would be unnecessary map cluttering.

@dktue
Copy link
Author

dktue commented Jun 30, 2018

but in 99% cases, it would be unnecessary map cluttering.

But so are bollards

@Adamant36
Copy link
Contributor

Adamant36 commented Jun 30, 2018

So are individual trees really. I think street lamps would at least be more relevent to render due to OSM being based on road mapping. At least street lamps play some part in that, unlike trees.

@Tomasz-W
Copy link

Tomasz-W commented Aug 31, 2018

The only way that I see for rendering for strret lamps is to copy rendering of power poles, any stronger rendering of them would cause map clutter or mistaking with some kind of barrier on linear way

https://www.openstreetmap.org/node/3689285643

(generally I'm against rendering it, because I don't see any need for this feature on map)

@polarbearing
Copy link
Contributor

I agree with those that say there is no need to render them.
But if we do, please not like bollards. One idea would be the dot in the middle and a transparent halo around, like trees but half the size.

@SomeoneElseOSM
Copy link
Contributor

Here's another option if anyone wants to borrow it:

https://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=-25.00719&lon=135.176226
(as usual follow the links from the changelog to get to the respository)

@Adamant36
Copy link
Contributor

@SomeoneElseOSM, have you found anywhere on your map where rendering them clutters things up to much? Do you have any opinion on if it would be an issue or not?

@SomeoneElseOSM
Copy link
Contributor

I only show them from z19 and I don't think they cause a problem there. https://map.atownsend.org.uk/maps/map/map.html#zoom=19&lat=52.950124&lon=-1.162046 is probably the densest place I've found.

@Adamant36
Copy link
Contributor

Thanks. It doesn't seem that bad at all. I really like how it looks with the icon.

@Tomasz-W
Copy link

Tomasz-W commented Sep 1, 2018

Basing on comments and thumbs up/ down, there is 8 people against and 3 people supporting this idea. As I'm not a hard "Github democrat" , and I don't see anything bad in making some changes even if there is 1-2 more people against than a supporters, majority in this issue is too big to ignore.

To be fair with enthusiasts of adding rendering for street lamps, I propose you to show some test renderings with power pole-like rendering. Maybe miraculously opponents of the issue will change the mind. Then we will do a final discussion and decide what to do with it.

@polarbearing
Copy link
Contributor

lapm-halo quick png mockup what I meant

@Adamant36
Copy link
Contributor

Adamant36 commented Sep 1, 2018

@Tomasz-W, not that it matters, but I think its actually 4 in support, as I assume SomeoneElseOSM is cool with the idea. Since he has it on his style. I'm willing to do some test renderings with something resembling power pole if I can figure out the code. I'll even throw in a few tests of SomeoneElseOSM's icon for good measure. Maybe we can at least get enough new people in support of it for a tie. Then we can play rock, paper, scissors for it ;)

In the meantime, if anyone who is against it wants to find a place really dense with street lamps I can test that would be great.

@dieterdreist
Copy link

dieterdreist commented Sep 2, 2018 via email

@meased
Copy link
Contributor

meased commented Sep 2, 2018

I'm still not sold on this, but just to play along, but what id @polarbearing's idea was modified with a yellow halo to look like light? Something like:
lightpoles

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 2, 2018

The ideas are all quite nice and not obtrusive, however I need to see it on the test rendering to really know...

@dktue
Copy link
Author

dktue commented Sep 3, 2018

I like the right-most icon @meased and would love to see test-renderings (as colors might be difficult in general) ! :-)

But @SomeoneElseOSM 's icon is awesome, too and probably more robust.

@kolb-stefan
Copy link

I think the rendering of streetlamps is a good idea. With them it is much easier to see if a street, park or other region is lit.

@Adamant36
Copy link
Contributor

Adamant36 commented Sep 23, 2018

@jragusa, is there a way that you propose we could render roads tagged with lit=yes on them versus showing street lamps?

@HolgerJeromin
Copy link
Contributor

We could make a yellow border like the bridge. But with bridges this would be even wider and making clutter and complex code.

@Adamant36
Copy link
Contributor

I was thinking something like that myself. It might be worth trying at least even with the problems if street lamps don't work out. It looks like the numbers are way better for it and still increasing. Whereas, it looks highway=street_lamp is starting to even out.
taghistory

@polarbearing
Copy link
Contributor

a) why yellow?

b) would colour-coded borders not be too much in the streets, when we also consider access and surface?

I'd imagine a separate layer, where you can switch the lights on or off.

@HolgerJeromin
Copy link
Contributor

why yellow?

Because osmand does this when you want. :)
And red for =no

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 24, 2018 via email

@polarbearing
Copy link
Contributor

when you want

yeah, these are the keywords. And I certainly do not want red borders along every rural road all the time.

@jragusa
Copy link
Contributor

jragusa commented Oct 1, 2018

I tag street with the lit tag but I'm not convinced we should render this on openstreetmap-carto
style because 1/ it's not really necessary and 2/ it may create conflicts with other tags that we might be interested to render such as cycleways or sideways and I didn't even talk about parking lanes...

If you need to see the rendering of lit, I would propose to look at dedicated maps such as those provided by ITO Map (they have currently some problems to display maps)

@Adamant36
Copy link
Contributor

The more time passes and the more I think about it, the less I think street lamps are worth rendering. At least in this phase of things, as the map is. I agree with @polarbearing that it would work well later on as a separate layer though, that can be turned on and off though. But we shouldn't force everyone else to see little yellow dots all over the place when they might want to. I feel the same about individual trees. Even if they look cool. I wish I was around back then to vote that one down, but I'll have to do the right thing on this one instead, by being against it for the sake of everyone else. Even if I might have liked the idea of rendering street lamps at some point. So, I suggest we close it for now and reopen it when the technology is better for rendering it.

@dieterdreist
Copy link

dieterdreist commented Oct 2, 2018 via email

@Adamant36
Copy link
Contributor

@dieterdreist, I'm not against mapping individual trees that are significant some how to the landscape etc. Its something that gets way over done in some areas. Like at some universities in California or some places that should really be tagged as tree rows, but arent for some reason. If its to dense its almost the same problem rendering beehives would of had. I rarely just see a few important trees somewhere mapped though. Its always a bunch of them at a time, which makes them lose their significance, but that could just be California though. I thought I read somewhere that the tag was originally only meant for significant trees instead of every tree, but it quickly started getting miss used.

@polarbearing
Copy link
Contributor

itoworld has an overlay that renders the lit tag.

@jeisenbe
Copy link
Collaborator

Since the simple bollard-like rendering was not recommended and rendering streetlamps without rendering lit=yes would encourage mappers to tag the individual streetlamps rather than adding the more useful information to the highway way, I'm closing this issue. See #3635 about adding a new, unique icon. However, the issue can be reopened if there are new ideas about how this could be rendered in a sensible way, perhaps only at z20 and above.

@pnorman pnorman closed this as completed Sep 17, 2019
@jidanni
Copy link

jidanni commented Oct 8, 2019

https://www.openstreetmap.org/node/4734061770 is the only street light for miles around:
http://osmstreetlight.bplaced.net/#17/24.19792/120.87697 .
Yet it is not rendered, but instead just electric poles are. If you think about it taxpayers are paying for the streetlights, not the electric poles. And streetlights are the only thing you can see from miles away in the dark (night is half of one's mapping "day"): so fulfills "map what is on the ground" more. (In fact at night it is the only thing left (visible) on the ground here in the hills!) Don't get me wrong: 100% support for also showing electric poles (and telephone poles!)... Just please don't use a "city attitude" to important safety/landmark (night) features in the countryside! Thanks. (Sure, they cause light pollution, but are great for far-away azimuth checks, etc.)

@kresp0
Copy link

kresp0 commented Sep 10, 2022

I love seeing the individual trees on the map. But for the street lamps, I would only like to see those at zoom ≥ 20 or maybe ≥19. Not sure how useful could be, but I believe that rendering street lamps would make the map more complete at higher zoom levels, without adding much clutter.

Also check out the area that @SomeoneElseOSM mentioned with HDM-CartoCSS or any other area with many lamps.

Lastly, check out the attached screenshots: I downloaded all the "light points" (including street lamps) from my City Council and loaded the 231k points into JOSM. Checked at zooms 17, 19 and 20. Please ignore where there are too many "lamps" together, as those are not really street lamps.

We could use the HDM-CartoCSS icon (CC0). It is clear, monochromatic and neutral (not on nor off). street_lamp

z17
z19
z20
all

@dktue
Copy link
Author

dktue commented Sep 14, 2022

The last map example looks like z19 to me and it looks good, not cluttered (at least to me).

@kresp0
Copy link

kresp0 commented Oct 6, 2022

Added all those "light points" (including all the street lamps in Madrid) to a custom database that uses OSM for public ways and most of the rest of the features such as buildings and trees come from authoritative data sources. Tagged all "light points" with barrier=bollard, in order to check out how it looks with osm-carto. And to me, looks good. Check out the proof of concept.

Still think that the icon suggested above could work nicely too. But it would be more obvious, so not sure about that.

@HolgerJeromin
Copy link
Contributor

And to me, looks good. Check out the proof of concept.

Perhaps a problem with the data here, but dots at the walls looks strange:

rps20221007_084028_511

@kresp0
Copy link

kresp0 commented Oct 7, 2022

Perhaps a problem with the data here, but dots at the walls looks strange:
rps20221007_084028_511

Yes, there is a problem with the data ("light points") as it includes not only street lamps but also spotlight in monuments and other kinds of lights operated by the City Council. It has attributes to indicate what model of light point it is, but as there are hundreds of types I haven't bothered yet to try to separate the street lights.

Please ignore where there are many dots together as those are not really street lamps.

@HolgerJeromin
Copy link
Contributor

But wall mounted streetlamps would render exactly the same.
Rendering them not would be confusing

@kresp0
Copy link

kresp0 commented Oct 7, 2022

But wall mounted streetlamps would render exactly the same. Rendering them not would be confusing

That example you provided can give us an idea on how wall mounted streetlamps would render, but only if we look at the bottom left side of the building. The reason is that while there are quite a few wall mounted streetlamps on that particular building, there are even more than are not really streetlamps, as the purpose of those is to illuminate the building or monument itself, not the street.

BTW, that building was the City Hall from 1696 to 2007. No idea what are those "light points" inside the building.

Casa de La Villa

@sommerluk
Copy link
Collaborator

As said above, in general I would be in favour of rendering this starting with z20, with an appropriate icon. If you could come up with a PR?

@BubbaJuice
Copy link
Contributor

@sommerluk, I have a branch open with a rendering like that of natural=tree that is based off of meased's icon at zoom 19+ (although this could easily be changed to an svg, moved to 20+, or something else based on feedback). I can submit a pull request if you want.
You can find the branch here.
The comparison can be viewed here.

Here are some previews all at z19:

Tucson, United States:
4OTnUQY7
qIR_6x34

Edmonton, Canada:
nbBG1FsY
20rdRZiS

Paris, France:
yIe2A6f9
4WceeCGh

@imagico
Copy link
Collaborator

imagico commented Jul 2, 2024

Currently there is no consensus among the maintainers that rendering highway=street_lamp is desirable. The main arguments against it are:

  • lack of usefulness for the map user.
  • overcrowding the map and overloading an already stretched system of rendering POIs when rendered as part of the POI layers.
  • lack of space in many cases on z<=19.
  • competition with lit=yes on roads in mapping and selectively rendering just one variant, but not the other could be considered nudging the mappers.

Of course counter-arguments can be given against all of these:

  • usefulness is entirely subjective, with a complete mapping of street lamps in an area and suitable display on a map the map user can get a very good impression what areas are lit at night, much more detailed than with the more generalized lit=yes. Since we render bollards the display of (free standing) street lamps could also be considered useful simply as obstacles/orientation points (i.e. a tall bollard).
  • despite us not rendering highway=street_lamp and many mapping tools encouraging use of lit=yes mapping of highway=street_lamp remains popular without indications that it is becoming less so (https://taghistory.raifer.tech/?#***/highway/street_lamp&***/lit/yes)
  • a compact non-blocking design is feasible - as it has been demonstrated by the French style (https://imagico.de/map/styleinfo/#style=fr&section=tags&key=highway&value=street_lamp)
  • rendering highway=street_lamp does not rule out rendering lit=yes on roads (in a similar way as rendering of urban land uses and buildings is not mutually exclusive).

What @BubbaJuice has shown is an implementation of the non-blocking rendering similar to the french style. This is done above the POI and label layers - hence the light symbols cover these in some cases, which is not a good idea. Non-blocking symbols would have to be rendered before the symbol and label layers.

Also the dark yellow color is not very intuitive - as previous comments have already mentioned. It has very low lightness contrast with urban landuses and pedestrian roads - making the lighting aspect fairly non-obvious. The french style coloring works much better in that regard.

I have some time ago further compacted the french design in my style and use that starting at z19 - which IMO works reasonably even at dense low latitude settings:

ac-street_lamp

This would match our approach to rendering trees where we also start early (z16) with a very subtle design and move to a more distinctive symbols as you zoom in.

See also a real world example at z19.

I am re-opening this to encourage renewed discussion but note that does not mean we have consensus among maintainers that this is desirable to render. So opening a PR at this time might be premature, further tuning the design concept shown and seeing if that convinces the maintainers this is a viable approach might be the more prudent approach.

@imagico imagico reopened this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests