Tower baseline alignment

[georgek]

There are a few icons representing tall objects now shown on the map. For example, wind turbines and communications towers. But the icons are aligned such that the centre of the icon is over the actual node position which leads to them looking misplaces, especially at lower zoom levels.

An example can be seen here with the wind turbine in the middle: https://www.openstreetmap.org/#map=16/52.5975/1.2626 It looks like it's in the water but it's not.

Can the alignment be changed so that the bottom of the icon is at the node position?

[geozeisig]

The icon is a symbol and not a small reflection of reality. This can lead to small inaccuracies in the placement.

[dieterdreist]

sent from a phone

…

On 15. Apr 2018, at 08:23, geozeisig ***@***.***> wrote: The icon is a symbol and not a small reflection of reality. This can lead to small inaccuracies in the placement.

-1, the icons should be placed in a way that it is intuitive to understand to which spot they refer to. In case of e.g. a tower, pole, chimney or mast, this is the base.

[matkoniecz]

The icons should be placed in a way that it is intuitive to understand to which spot they refer to. In case of e.g. a tower, pole, chimney or mast, this is the base.

@dieterdreist I reposted your comment as I agree with it and Github mail-to-cmment transform hides it (maybe it expects to post reply above quoted text? or to delete text of an original message?)

[matthijsmelissen]

I agree this should be solved.

[jeisenbe]

This looks fixable with
marker-transform: 'translate(0,-6)';
This code will move the marker icon up by 6 pixels, which should work for most 14 pixel icons.

Here's an initial test in Honolulu, Hawaii
z14 Communications towers Original

Up 6 pixels

z18 Lighting towers original

Up 6

z15 Lighthouse, Original

Up 6

EDIT: It looks like we would need to decrease the text-dy by the same amount as well, looking at the name label for the lighthouse

[jeisenbe]

List of icons to be modified:

man_made communications_tower
man_made mast
man_made tower & man_made water_tower
man_made chimney
man_made lighthouse
man_made windmill
man_made obelisk & historic monument
power generator wind turbine
EDIT: man_made crane

Any others?

I thought about radio telescopes, but I don't think it's necessary

[jeisenbe]

Cranes examples:
Big Willi centered z17:

Big Willi up 6 pixels z17:

Singapore centered z17:

Singapore up 6 pixels z14:

[jeisenbe]

Monuments in Beirut, before
http://openstreetmap.org/#map=17/33.89653/35.50498

Monuments up 6 - this is too much in my opinion, because the base of the monument is so thick

Monuments up 4 - better

Mast in Lebanon, before

Up 6 pixels

Watertower before (Note that these are mapped as circular ways and tagged building=yes)

Watertower up 5 pixels

Windmill in rural Lebanon before

Windmill up 6p

Wind Turbines Hawaii
Before z15

z15 up 6

Before z17

After z17

[jeisenbe]

Adjusted Lighthouse up 4 pixels rather than 6; better I think:
z15 original

z15 up 4 pixels

Man_made Obelisk, Washington DC:
z15 original

z15 up 6 pixels (thin base, tall icon)

Man_made Chimney
Before z16

Up 6 pixels z16

[georgek]

A definite improvement IMO. Great work!

[kocio-pl]

On thing that still bugs me (sorry if that's stupid and you have put a detailed explanation - I just have no too much time currently): what if Obelisk, Washington DC had no label, would it be centered then?

[jeisenbe]

The text label does not change the placement of the icon, it renders in the same place (centered on the node or polygon centroid) whether or not there is a name

…

On Fri, Nov 16, 2018 at 11:54 PM kocio-pl ***@***.***> wrote: On thing that still bugs me (sorry if that's stupid and you have put a detailed explanation - I just have no too much time currently): what if Obelisk, Washington DC had no label, would it be centered then? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3176 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshCuEbGNssUoZNU3cYWZ80ftYJItMks5uvtHAgaJpZM4TVJ7j> .

[kocio-pl]

So it will be displaced off the center? I didn't have the time to review this yet, but I don't like this effect.

[Adamant36]

My only thing is if this is done on points and the icon is moved up a few inches on the map, does that then translate to it moving a few feet in real life and how would affect other POI's mapped extremely close to it. I know the position of the icon isn't a "coordinate accurate" position in the first place, but the original position was chosen as a default for a reason and its something I think about.

[meased]

Where is this idea going? Everything that "stands up" gets an offset icon? embassy? fuel? cafe? camping? golf? picnic? waste_basket?

What is the problem that this idea solves?

This is a 2D map, not a 3D map. Icons represent an object, they don't have to look like a vectorized aerial image of the object.

[jeisenbe]

While the original PR showed changes for all tower-like features, the current version only changes icons that have 2 parts: 1) Towers and 2) masts with “communication waves” coming out of the top 3) Chimneys with “smoke” at the top. The last icon is the most confusing, because the position of the chimney is in the lower left corner of the 14x14 pixel icon. As shown in the most recent images, this leads to the chimney appearing about 4 pixels left of its real position. The center of the chimney also appears below the node. By shifting the icon up and right by 4 pixels, the PR now makes the icon appear to be centered over the node. I agree that it would be silly to shift every icon. I would only like to shift icons that are made of 2 parts like this. I’ve looked through all of the SVGs, and most are fine. Only 1 or 2 others have this problem due to being composed of 2 parts, for example drinking water. But only the towers, may and chimney are rendered on low enough zoom levels for it to be a real problem.

…

On Sat, Nov 17, 2018 at 4:39 AM meased ***@***.***> wrote: Where is this idea going? Everything that "stands up" gets an offset icon? embassy? fuel? cafe? camping? golf? picnic? waste_basket? What is the problem that this idea solves? This is a 2D map, not a 3D map. Icons represent an object, they don't have to look like a vectorized aerial image of the object. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3176 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshLyAOUbUl-BV3snmUatiXz74z15mks5uvxRWgaJpZM4TVJ7j> .

[jeisenbe]

Re: “the original position was chosen as a default for a reason” I don’t think this issue was considered before. The default of centering the SVG is usually fine, because most icons are symmetrical or at least square-shaped. On Sat, Nov 17, 2018 at 8:08 AM Joseph Eisenberg <[email protected]> wrote:

…

While the original PR showed changes for all tower-like features, the current version only changes icons that have 2 parts: 1) Towers and 2) masts with “communication waves” coming out of the top 3) Chimneys with “smoke” at the top. The last icon is the most confusing, because the position of the chimney is in the lower left corner of the 14x14 pixel icon. As shown in the most recent images, this leads to the chimney appearing about 4 pixels left of its real position. The center of the chimney also appears below the node. By shifting the icon up and right by 4 pixels, the PR now makes the icon appear to be centered over the node. I agree that it would be silly to shift every icon. I would only like to shift icons that are made of 2 parts like this. I’ve looked through all of the SVGs, and most are fine. Only 1 or 2 others have this problem due to being composed of 2 parts, for example drinking water. But only the towers, may and chimney are rendered on low enough zoom levels for it to be a real problem. On Sat, Nov 17, 2018 at 4:39 AM meased ***@***.***> wrote: > Where is this idea going? Everything that "stands up" gets an offset > icon? embassy? fuel? cafe? camping? golf? picnic? waste_basket? > > What is the problem that this idea solves? > > This is a 2D map, not a 3D map. Icons represent an object, they don't > have to look like a vectorized aerial image of the object. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#3176 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AoxshLyAOUbUl-BV3snmUatiXz74z15mks5uvxRWgaJpZM4TVJ7j> > . >

[jeisenbe]

I believe this issue is going to closed as wontfix, correct?

[matthijsmelissen]

Yes, thanks.