Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipolygon relations: All borders should be labeled #3152

Closed
gpsvisualizer opened this issue Mar 29, 2018 · 12 comments · Fixed by #3652
Closed

Multipolygon relations: All borders should be labeled #3152

gpsvisualizer opened this issue Mar 29, 2018 · 12 comments · Fixed by #3652

Comments

@gpsvisualizer
Copy link

If a multipolygon relation includes multiple discrete parcels of land, the name of the relation is ONLY drawn around the borders of the largest parcel. This is confusing in situations where some of the land might be far out of view of the biggest chunk.

I supposed I can understand why only one "area label" is drawn per relation; it might look weird if there were fifty parcels visible, all with the same label... but I think the borders, which only appear when zoomed in, should be labeled on every parcel.

multipolygon rendering annotated

Attached file comes from here: https://www.openstreetmap.org/#map=15/45.7934/-121.6350

@gpsvisualizer gpsvisualizer changed the title Multipolygon relations: not all borders are labeled Multipolygon relations: All borders should be labeled Mar 29, 2018
@kocio-pl kocio-pl added the text label Mar 29, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Mar 29, 2018
@matkoniecz
Copy link
Contributor

matkoniecz commented Apr 8, 2018

From what I see it is partially opposite to #59 (see #59 (comment) )

@gpsvisualizer
Copy link
Author

Not exactly. #59 is about whether or not to label each AREA that is part of a multipolygon; I agree that only one area label is best.

Here, I'm asking for the BORDERS to be labeled on all of the areas. This is something that only happens at high zoom levels, and there's no reason it should be restricted to one area per relation.

@chazanov
Copy link

chazanov commented Jun 20, 2018

What about making the rendering size-dependent? Some US national forest have of dozens of separate areas.

@gpsvisualizer
Copy link
Author

Again, I'm not talking about the area labels, I'm talking about the small text that flows along the borders -- text which is ONLY visible at high zoom levels. Even if a forest has dozens or separate areas, all of those areas should have their borders labeled when zoomed in.

@chazanov
Copy link

It begins to show up at z=15. So let's just try it!

@gpsvisualizer
Copy link
Author

This is still a problem. Any hope of a solution?

@jeisenbe
Copy link
Collaborator

text-largest-bbox-only: false; tells Mapnik to render a text label in all of the polygons that are part of a multipolygon. I've tested it:

z13 Before:
national-park-multipolygon-test-before

z13 After:
z13-national-parks-multipolygon-test-after

@jeisenbe
Copy link
Collaborator

It looks like this same problem happens with administrative boundaries too, at least in my test environment.

Are there any other types of multipolygons that have text labels on their borders, besides administrative, nature_reserve, national_park and protected_area?

Before
province-multipolygon-test-before

After
province-multipolygon-test-after

@gpsvisualizer
Copy link
Author

Does your quick-'n'-easy solution cause an AREA label to appear in all of the sub-polygons too? Because I think that issue was more up for debate than just the edge labels... I think it'd be best to stick with labeling just the edges for now.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jan 18, 2019 via email

@gpsvisualizer
Copy link
Author

So can you make it happen for real?

@gpsvisualizer
Copy link
Author

Hallelujah. Looks like you solved multiple problems. I look forward to it going live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants