Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"waterway=stream" with "tunnel=yes" nearly invisible #282

Closed
mozzbozz opened this issue Dec 12, 2013 · 1 comment · Fixed by #722
Closed

"waterway=stream" with "tunnel=yes" nearly invisible #282

mozzbozz opened this issue Dec 12, 2013 · 1 comment · Fixed by #722
Assignees
@matthijsmelissen
Labels
bug cartography water

Comments

@mozzbozz
Copy link

As you can see below the marker at http://www.openstreetmap.org/?mlat=53.04788&mlon=8.62900#map=19/53.04788/8.62900 , a "waterway=stream" is nearly invisible (and on some screens due to wrong settings probably not at all):
tile
(on the real map it looks even worse) I would suggest using slightly darker blue for them.

Also I noticed, that the tunnel isn't rendered ontop the market place. Though the name label of the stream is. I think that a consistent behaviour should be used (I prefer seeing the tunneled stream "shining through the marketplace" over making it invisible completely):
http://www.openstreetmap.org/?mlat=53.04803&mlon=8.62870#map=19/53.04803/8.62870
@matkoniecz
Copy link
Contributor

Or at least stop displaying name of invisible feature.

@matthijsmelissen matthijsmelissen mentioned this issue Mar 6, 2014
Closed
@matthijsmelissen matthijsmelissen mentioned this issue May 26, 2014
Closed
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jun 10, 2014
@matthijsmelissen
Clean up waterways
70e70bf 
* Merge definitions of canal and river (canals are now as wide as rivers
  instead or wider on some and narrower on other zoomlevels).
* Merge definitions of stream, drain, and ditch.
* Render river/canal in tunnel like stream/drain/ditch in tunnel.
* Render river/canal in tunnel in tunnel-style on z12 and z13.
* Render tunnel=culvert like tunnel=yes.

This solves the following issues:
* Fixes 3590 (trac): Canals wider than rivers at z12, disappear at z11
* Fixes 4656 (trac): waterway=canal too wide compared with highways at z14
* Fixes 4507 (trac): Waterways in a tunnel may be confused for roads
* Fixes 4227 (trac): canals as tunnels render differently at low zooms
* Fixes gravitystorm#198: Add rendering of tunnel=culvert for waterway
* Fixes gravitystorm#222: Inconsistent water-lines-casing tunnel check
* Fixes gravitystorm#282: "waterway=stream" with "tunnel=yes" nearly invisible

With thanks to @yarl for the work on gravitystorm#198.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jun 10, 2014
@matthijsmelissen
Clean up waterways
e998e45 
* Merge definitions of canal and river (canals are now as wide as rivers
  instead or wider on some and narrower on other zoomlevels).
* Merge definitions of stream, drain, and ditch.
* Render river/canal in tunnel like stream/drain/ditch in tunnel.
* Render river/canal in tunnel in tunnel-style on z12 and z13.
* Render tunnel=culvert like tunnel=yes.

This solves the following issues:
* Fixes 3590 (trac): Canals wider than rivers at z12, disappear at z11
* Fixes 4227 (trac): canals as tunnels render differently at low zooms
* Fixes 4507 (trac): Waterways in a tunnel may be confused for roads
* Fixes 4656 (trac): waterway=canal too wide compared with highways at z14
* Fixes gravitystorm#198: Add rendering of tunnel=culvert for waterway
* Fixes gravitystorm#222: Inconsistent water-lines-casing tunnel check
* Fixes gravitystorm#282: "waterway=stream" with "tunnel=yes" nearly invisible

With thanks to @yarl for the work on gravitystorm#198.
@matthijsmelissen matthijsmelissen mentioned this issue Jun 10, 2014
Closed
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jun 10, 2014
@matthijsmelissen
Clean up waterways
75953ae 
* Merge definitions of canal and river (canals are now as wide as rivers
  instead or wider on some and narrower on other zoomlevels).
* Merge definitions of stream, drain, and ditch.
* Render river/canal in tunnel like stream/drain/ditch in tunnel.
* Render river/canal in tunnel in tunnel-style on z12 and z13.
* Render tunnel=culvert like tunnel=yes.

This solves the following issues:
* Fixes 3590 (trac): Canals wider than rivers at z12, disappear at z11
* Fixes 4227 (trac): canals as tunnels render differently at low zooms
* Fixes 4507 (trac): Waterways in a tunnel may be confused for roads
* Fixes 4656 (trac): waterway=canal too wide compared with highways at z14
* Fixes gravitystorm#198: Add rendering of tunnel=culvert for waterway
* Fixes gravitystorm#222: Inconsistent water-lines-casing tunnel check
* Fixes gravitystorm#282: "waterway=stream" with "tunnel=yes" nearly invisible

With thanks to @yarl for the work on gravitystorm#198.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jul 10, 2014
@matthijsmelissen
Clean up waterways
07f5357 
* Merge definitions of canal and river (canals are now as wide as rivers
  instead or wider on some and narrower on other zoomlevels).
* Merge definitions of stream, drain, and ditch.
* Render river/canal in tunnel like stream/drain/ditch in tunnel.
* Render river/canal in tunnel in tunnel-style on z12 and z13.
* Render tunnel=culvert like tunnel=yes.

This solves the following issues:
* Fixes 3590 (trac): Canals wider than rivers at z12, disappear at z11
* Fixes 4227 (trac): canals as tunnels render differently at low zooms
* Fixes 4507 (trac): Waterways in a tunnel may be confused for roads
* Fixes 4656 (trac): waterway=canal too wide compared with highways at z14
* Fixes gravitystorm#198: Add rendering of tunnel=culvert for waterway
* Fixes gravitystorm#222: Inconsistent water-lines-casing tunnel check
* Fixes gravitystorm#282: "waterway=stream" with "tunnel=yes" nearly invisible

With thanks to @yarl for the work on gravitystorm#198.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jul 10, 2014
@matthijsmelissen
Clean up waterways
289c962 
* Merge definitions of canal and river (canals are now as wide as rivers
  instead or wider on some and narrower on other zoomlevels).
* Merge definitions of stream, drain, and ditch.
* Render river/canal in tunnel like stream/drain/ditch in tunnel.
* Render river/canal in tunnel in tunnel-style on z12 and z13.
* Render tunnel=culvert like tunnel=yes.

This solves the following issues:
* Fixes 3590 (trac): Canals wider than rivers at z12, disappear at z11
* Fixes 4227 (trac): canals as tunnels render differently at low zooms
* Fixes 4507 (trac): Waterways in a tunnel may be confused for roads
* Fixes 4656 (trac): waterway=canal too wide compared with highways at z14
* Fixes gravitystorm#198: Add rendering of tunnel=culvert for waterway
* Fixes gravitystorm#222: Inconsistent water-lines-casing tunnel check
* Fixes gravitystorm#282: "waterway=stream" with "tunnel=yes" nearly invisible

With thanks to @yarl for the work on gravitystorm#198.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jul 10, 2014
@matthijsmelissen
Clean up waterways
fc894bb 
* Merge definitions of canal and river (canals are now as wide as rivers
  instead or wider on some and narrower on other zoomlevels).
* Merge definitions of stream, drain, and ditch.
* Render river/canal in tunnel like stream/drain/ditch in tunnel.
* Render river/canal in tunnel in tunnel-style on z12 and z13.
* Render tunnel=culvert like tunnel=yes.

This solves the following issues:
* Fixes 3590 (trac): Canals wider than rivers at z12, disappear at z11
* Fixes 4227 (trac): canals as tunnels render differently at low zooms
* Fixes 4507 (trac): Waterways in a tunnel may be confused for roads
* Fixes 4656 (trac): waterway=canal too wide compared with highways at z14
* Fixes gravitystorm#198: Add rendering of tunnel=culvert for waterway
* Fixes gravitystorm#222: Inconsistent water-lines-casing tunnel check
* Fixes gravitystorm#282: "waterway=stream" with "tunnel=yes" nearly invisible

With thanks to @yarl for the work on gravitystorm#198.
@matthijsmelissen matthijsmelissen mentioned this issue Jul 10, 2014
Merged
@matthijsmelissen matthijsmelissen self-assigned this Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthijsmelissen matthijsmelissen

Labels
bug cartography water
Projects
None yet
Milestone
No milestone
3 participants
@matkoniecz @mozzbozz @matthijsmelissen