-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should landcover be ordered by osm_id in addition to way_area? #2782
Comments
Funny bug. Your proposal makes sense. |
👍 I personally think we should be making decisions ourself on ordering order more often, but we should always have an osm_id in the sorts where rendering order makes a visual difference |
Should not it be one way with additional landuse tag? |
While I understand the issue in general, in the specific example the landuse way makes no sense to me. The use of the land on which the airport sits is not 'grass'. Some of its part may be covered with grass, but probably not the runway. |
sent from a phone
On 9. May 2018, at 00:24, polarbearing ***@***.***> wrote:
While I understand the issue in general, in the specific example the landuse way makes no sense to me. The use of the land on which the airport sits is not 'grass'. Some of its part may be covered with grass, but probably not the runway.
completely agree, in this example the grass area should be reduced to the actual grass area.
As a sidenote I would question in general the semantic sense of „grass“ as a landuse value, and would propose to drop rendering it.
|
This would be quite a big move to drop |
Let's keep this confined to the issue at hand, which is fully defined ordering of the landuse layer. Random rendering results based on a lack of ordering is a bug leading to errors at metatile edges, regardless of if the tagging in this case makes sense or not. |
This resolves gravitystorm#2782
This resolves gravitystorm#2782
Recently i saw a landcover area where the color varied arbitrarily depending on zoom level because there are two different areas with different tags but identical geometry and therefore identical way_area:
https://www.openstreetmap.org/way/346109314
https://www.openstreetmap.org/way/49188959
I think cases like this should get a consistent drawing order, probably best by ordering by osm_id in addition.
The text was updated successfully, but these errors were encountered: