Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should landcover be ordered by osm_id in addition to way_area? #2782

Closed
imagico opened this issue Aug 29, 2017 · 7 comments · Fixed by #3441
Closed

Should landcover be ordered by osm_id in addition to way_area? #2782

imagico opened this issue Aug 29, 2017 · 7 comments · Fixed by #3441

Comments

@imagico
Copy link
Collaborator

imagico commented Aug 29, 2017

Recently i saw a landcover area where the color varied arbitrarily depending on zoom level because there are two different areas with different tags but identical geometry and therefore identical way_area:

https://www.openstreetmap.org/way/346109314
https://www.openstreetmap.org/way/49188959

I think cases like this should get a consistent drawing order, probably best by ordering by osm_id in addition.

@imagico imagico added this to the Bugs and improvements milestone Aug 29, 2017
@matthijsmelissen
Copy link
Collaborator

Funny bug. Your proposal makes sense.

@pnorman
Copy link
Collaborator

pnorman commented Aug 29, 2017

👍

I personally think we should be making decisions ourself on ordering order more often, but we should always have an osm_id in the sorts where rendering order makes a visual difference

@andreynovikov
Copy link

Should not it be one way with additional landuse tag?

matthijsmelissen pushed a commit that referenced this issue May 8, 2018
@polarbearing
Copy link
Contributor

While I understand the issue in general, in the specific example the landuse way makes no sense to me. The use of the land on which the airport sits is not 'grass'. Some of its part may be covered with grass, but probably not the runway.

@dieterdreist
Copy link

dieterdreist commented May 9, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 9, 2018

This would be quite a big move to drop landuse=grass. I don't exclude possibility of such action, however we should implement landcover=grass from #2548 then to help make transition, because I can't imagine generic style not showing grass areas.

@pnorman
Copy link
Collaborator

pnorman commented May 28, 2018

Let's keep this confined to the issue at hand, which is fully defined ordering of the landuse layer. Random rendering results based on a lack of ordering is a bug leading to errors at metatile edges, regardless of if the tagging in this case makes sense or not.

matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Oct 7, 2018
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants