Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render amenity=studio #2518

Closed
abdeldjalil09 opened this issue Dec 20, 2016 · 42 comments
Closed

Render amenity=studio #2518

abdeldjalil09 opened this issue Dec 20, 2016 · 42 comments

Comments

@abdeldjalil09
Copy link

amenity=studio should be rendered with and icon and his name
http://taginfo.openstreetmap.org/tags/amenity=studio

@jojo4u
Copy link

jojo4u commented Dec 20, 2016

A studio used for creating radio or television programmes and broadcasting them. It can also be used to mark a music recording studio.
Accepted proposal from 2008 (that's why the amenity key), documented wiki page, 4000 instances, no open problems in Talk page.

@kocio-pl
Copy link
Collaborator

Standard questions for a start:

  1. Do we want to have this icon?
  2. How should it look like (real 14px examples are preferred, but not required)?

@kocio-pl kocio-pl added amenity-points new features Requests to render new features labels Dec 20, 2016
@kocio-pl kocio-pl added this to the New features milestone Dec 20, 2016
@HolgerJeromin
Copy link
Contributor

The feature is IMO only useful to have its name rendered.
Most people does not want to go to a amenity=studio (if this is not a leisure=themepark)
An icon (microphone, TV/movie screen) will let me think about a night club or cinema.

@kocio-pl
Copy link
Collaborator

What about generic brown dot?

@dieterdreist
Copy link

dieterdreist commented Dec 20, 2016 via email

@jojo4u
Copy link

jojo4u commented Dec 21, 2016

the tag is weakly defined

You say as if there is something wrong with the tag. If somebody wants to differentiate between radio/tv/music (and film) the subtag studio=* exists and is documented.

@dieterdreist
Copy link

dieterdreist commented Dec 21, 2016 via email

@abdeldjalil09
Copy link
Author

abdeldjalil09 commented Dec 21, 2016

In humanitarian style , amenity=studio is rendered with microphone icon.

@d1g
Copy link

d1g commented Jan 8, 2017

@dieterdreist my understanding that only few cities have recording studios without broadcasting equipment. Your 8oradz91jpg.jpg example was about amenity=studio + studio=audio see osmwiki for details about studio=* sub tag

I would change "and broadcasting them" to "and usually broadcasting them"

@Tomasz-W
Copy link

This tag is very diversified, and it would be hard to make an universal generic icon matching all studio types. Another option is to project separate icon for each studio=* tag, but - as someone said here earlier - this information wouldn't be useful for average map user. IMO rendering just studio's name, or it's name with simple dot (rendering amenities without icon as a dots is considered -> #108 ) would be enough.

@dieterdreist
Copy link

dieterdreist commented Jan 10, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Mar 26, 2018

I think microphone is a common element for all kinds of the studios and we could render it. The one used in HOT is just great:

https://github.com/hotosm/HDM-CartoCSS/blob/master/icons/poi/studio.svg

@Tomasz-W
Copy link

I like this icon.
Another option is to use office-blue generic dot for this feature, because is not an amenity for common-use.

@jragusa
Copy link
Contributor

jragusa commented Apr 10, 2018

https://www.openstreetmap.org/way/209429260 (radio station)

brown amenity colour:
studio

steeblue (#4863A0) office colour:
studio_office

@Tomasz-W
Copy link

I vote for office-blue

@dieterdreist
Copy link

dieterdreist commented Apr 11, 2018 via email

@Tomasz-W
Copy link

Tomasz-W commented Apr 11, 2018

I stand by my previous comments and would not render this feature because it is badly defined

I wouldn't say it is badly defined, it's just quite "wide" tag. A common part of all subtypes is audio recording, so studio microphone shape fit here very well.

@dieterdreist
Copy link

dieterdreist commented Apr 11, 2018 via email

@matkoniecz
Copy link
Contributor

matkoniecz commented Apr 19, 2018

I think that given this tag is supposed to be used for features that are unlikely to be orientation points, not used by general public and tag itself is problematic for reasons mentioned in #2518 (comment)

yes, IMHO there is something wrong with this tag. There's really no hint in the key/value that this is a tag for tv and radio and music recording studios (quite different, these) but not for film studios, dance studios, art studios, kitchen studios, photo studios, and what ever studio else there might exist. http://taginfo.osm.org/keys/amenity#values

I propose to decline rendering.

@Tomasz-W
Copy link

Tomasz-W commented Aug 3, 2018

@kocio-pl Can we re-open this issue and try with office-blue generic dot for this feature? It has 5,8k uses, but it's not rendered in any way.

@HolgerJeromin
Copy link
Contributor

Can we re-open this issue and try with office-blue generic dot for this feature?

Nothing has changed IMO since the closing.
Having (the possiblity to add) a dot should not result in having a dot for all "other" stuff.

@matkoniecz
Copy link
Contributor

I am strongly against reopening as this tag is fortunately not clearly accepted by community and as described in #2518 (comment) this tag is really poorly describing reality.

If it is office then replacing it with/additionally tagging it with office=* is desirable.

@Tomasz-W
Copy link

Tomasz-W commented Aug 3, 2018

this tag is fortunately not clearly accepted by community

Actually only you and @dieterdreist have some problems with tagging scheme of this feature. See https://wiki.openstreetmap.org/wiki/Talk:Tag:amenity%3Dstudio

Reading discussion here and on the Wiki, for other users everything seems to be ok and understandable. There are more people that want this feature rendered, than people against, but you have closed this issue due to your opinion. It's ridiculous.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 3, 2018

Closing discussion is not the technical problem, you can still discuss it, as it is done now. However the discussion does not seem to be settled yet, so I'm reopening it to show the real state.

@kocio-pl kocio-pl reopened this Aug 3, 2018
@dieterdreist
Copy link

dieterdreist commented Aug 5, 2018 via email

@matkoniecz
Copy link
Contributor

Looking at it again it still seems hopelessly broad

A studio used for creating radio or television programmes and broadcasting them. It can also be used to mark a music recording studio.

vague tag name is not helping

@matkoniecz
Copy link
Contributor

I will not close it for now, but I am still strongly against rendering this tag.

@Adamant36
Copy link
Contributor

Adamant36 commented Sep 22, 2018

@matkoniecz, what if it was only rendered with studio=type? There's currently 438 uses of studio=audio, 276 uses of studio=video, 587 uses of studio=television, and 957 uses of studio=radio. The numbers are low, but its about how many studios there are overall. Maybe it be an incentive for people to add the tags to amenity=studio, or at least give us a way to revisit it later when the numbers are higher. Because as you say, amenity=studio alone is a little to vague as it is, but maybe not with studio= values added to it.

@kocio-pl kocio-pl removed the new features Requests to render new features label Oct 19, 2018
@jeisenbe
Copy link
Collaborator

@dieterdreist, @matkoniecz, others:
What are your thoughts on rendering amenity=studio only when studio=audio, studio=video, studio=television, or studio=radio?

@matkoniecz
Copy link
Contributor

It makes more sense to me, but I have little knowledge about this type of tagging. Is there some discussion on tagging mailing list or documentation on OSM wiki reviewed by people with more knowledge on this topic?

@dieterdreist
Copy link

dieterdreist commented Oct 25, 2018 via email

@jragusa
Copy link
Contributor

jragusa commented Nov 19, 2019

Any improvement about this issue ? amenity=radio_studio|tanning_studio as suggested by @dieterdreist are only used twice and have no wiki page and amenity=video_studio is not used while there is 7137 amenity=studio. Moreover, studio=radio is used 1316 times, studio=audio 581 times and studio=video 368 times.

I think that rendering the icon for amenity=studio + studio=radio|audio would satisfy everyone regarding the discussion and it's easy to implement. If necessary, different colour can be used to distinguish radio (blue) from audio (brown).

All that remains is to develop an icon for studio=video @Tomasz-W if you have time.

@Adamant36
Copy link
Contributor

Adamant36 commented Nov 20, 2019

@jragusa, you should create a Wiki page for studio=*. Also if studio=video is going to be rendering it would be useful to render studio=television along with it so there isn't miss-tagging to get it to render. Plus, it would just be useful to have. Although, there's only 870 uses :(. Seems like a lot studios serve multiple purposes, or there would probably be more.

@geozeisig
Copy link

@jragusa I have created wiki pages for studio. So far, there are 4 values: audio, radio, video, television. Please look at it and add or correct it.
The problem with this key is that there are many values that should reject.
In the 2008 proposal, it was suggested that the type (audio or video) of the study should be specified with type = *. This collided with the tags of the multipolygon, which also uses type = *. As a result, the use of studio = * or studio: type = * was suggested on the English discussion page 2014. It was agreed on studio = *. At the beginning of 2016, the preset was adjusted accordingly in the editor JOSM.
An overview of the values can be seen in taginfo.

@dieterdreist
Copy link

dieterdreist commented Nov 22, 2019 via email

@jragusa
Copy link
Contributor

jragusa commented Dec 5, 2019

@dieterdreist I agree with you about the broad definition of amenity=studio and the subtag studiohave to resolve this uncertainty. The taginfo link provided by @geozeisig shows that we can distinguish a television studio from a video (generic value) or a cinema studio. Likewise, we can separate a radio studio from a recording studio (audio). Even photography, dance and graphic are already used.

Here I propose to only render radio studio (amenity=studio + studio=radio) and audio studio (amenity=studio + studio=audio) because they are well populated and the icon fits with them. The difference lies on different colour rendering: office blue for the studio=radio and amenity brown for studio=audio. amenity=studio alone won't be showed and will need the additional studio tag to be considered.

@dieterdreist
Copy link

dieterdreist commented Dec 5, 2019 via email

@wmisener
Copy link

wmisener commented Feb 9, 2021

I don't really understand the opposition to rendering this, at least as equivalent to a non-specific office with a blue dot. This tag is documented, used almost 10k times all around the world, an iD preset, and there are no moderately-used or even formally proposed alternative tagging schemes even though this issue has been open for over 4 years. Even if some mappers have personal issues with the tag, shouldn't the existing predominant use be rendered rather than trying to somehow guide the community to come up with an alternative that may or may not gain traction and hasn't happened so far?

@dieterdreist
Copy link

dieterdreist commented Feb 9, 2021 via email

@ghost
Copy link

ghost commented Feb 9, 2021

This might be enough of a tangent that it needs a new issue, but why not just consider the 'secondary tag' being discussed here a primary tag -- that is, consider it even in the absence of the amenity-based tag?

I'm not sure I buy that offices generally are the same thing as each other, but I agree that it's important that if someone believes a building or room to be an office that they be able to tag it as such with a specific value for that key and have it render at least in a basic fashion. The same could be said for a studio. Indeed, looking at https://en.wiktionary.org/wiki/studio#Etymology it seems directly comparable to the usage of the word 'office' or 'workshop' (https://wiki.openstreetmap.org/wiki/Key:workshop, as another point of reference) as a place outfitted for an intended labour. And it's a digression anyway, since it has been brought up that a tag that specifies the type of studio is possible, either under the amenity or studio key, and (I'd like to assert) either considered primarily or secondarily in a rendering context. Since there seems to be widespread agreement that the specific tags are suitable, why not establish specific rendering at least for now?

Discussion about whether a particular tagging is suitable for consideration as a destination seems to be about the amenity key more generally (and I agree with the sentiments expressed), but not really about whether these kinds of places should receive rendering support. This isn't an issue ticket for a routing software, so whether a POI is a destination or not does not seem relevant.

I also think this thread needs a lot less repetition so the issues at the root can actually start getting addressed and progress made, either by closing it permanently or establishing some kind of rendering.

@Adamant36
Copy link
Contributor

Adamant36 commented Feb 9, 2021

IMO, someone should put the effort into tagging the 9,000 or so uses of this with the appropriate studio=* tags. Then revisit this once that happens so specific ones with high enough usage can be rendering instead of treating things like this can be rendered as a general catch icon that people will somehow magically understand when that's clearly not the case. If not, then I say close it. Or really, close it in the meantime anyway. Its not like it can't be reopened when someone actually does something to make it maybe renderable instead of just complaining.

(P.S. Obviously don't do it through an "automated" edit. Whatever that means)

@imagico
Copy link
Collaborator

imagico commented Feb 9, 2021

@ArloJamesBarnes - you make some very good points here. We don't want to render tags because they are widely used, we render them because they are used consistently for something well defined and meaningful. amenity=studio as has been pointed out by several people does not qualify as such (at least not on its own without more specific tags in addition). Furthermore we have several tag groups (like craft=, office= and workshop=*) that overlap and compete with it and there is no clear consensus among mappers about the delineation of these groups.

Rendering specific values of studio=* with well defined meaning, broad acceptance and consistent use - either as standalone tag or when in combination with amenity=studio - is a different matter but that would be a matter for separate issues.

Closing this again as there does not seem to be a chance for support for this in rendering as suggested.

@imagico imagico closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests