Tobacco icon mangled with theater icon

[meased]

The shop=tobacco icon:

https://github.com/gravitystorm/openstreetmap-carto/blob/master/symbols/shop/tobacco.svg

Now has both the cigarette icon and the theater icon overlayed in one SVG file.

[kocio-pl]

Could you post the link to this location so that we could test it?

[meased]

It's here:

http://www.openstreetmap.org/?mlat=45.62165&mlon=-122.55384#map=19/45.62165/-122.55384

[nebulon42]

It's a copy and paste mistake of me. The theater icon is really in the tobacco icon now. Should be easily fixed.

[kocio-pl]

@nebulon42 Do you plan to do that? I would like to merge it soon and issue v2.45.1 (probably also with SVG lint).

[matthijsmelissen]

Sorry, missed that.

We should try to avoid bug releases. Every release means high latency on the server for a day or two (many old tiles being served), which is quite troublesome for mappers. The fewer releases, the better from this perspective.

Not saying whether or not we should release a .1 version for this particular bug.

[kocio-pl]

I'm aware of a burden it causes. I don't like big code changes and prefer smaller steps. I made a general preview of this change, but unfortunately there was no tobacco shop on this area.

[HolgerJeromin]

Svg lint found no XML problems. So has only benefits for future PRs to find early problems.
It has no real value to include it in a release.
Despite this tobacco fix produces an invalid svg :)