Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highway refs don't properly fit the shield #2478

Closed
naoliv opened this issue Nov 30, 2016 · 6 comments
Closed

Highway refs don't properly fit the shield #2478

naoliv opened this issue Nov 30, 2016 · 6 comments

Comments

@naoliv
Copy link

naoliv commented Nov 30, 2016

Using this example (from https://www.openstreetmap.org/#map=18/-21.81209/-48.18708):

See how SP-310 and BR-364 are touching the upper and lower shield borders.
Actually, if we zoom, we can see that BR-364 is surpassing the box:

Isn't it possible to add some pixels on top and on bottom of the shield, to avoid this?
Or maybe reduce the vertical spacing between the values.

@nebulon42
Copy link
Contributor

nebulon42 commented Nov 30, 2016

I suspect that this is a consequence of the recent font change.

@jojo4u
Copy link

jojo4u commented Dec 1, 2016

Yes, it's Noto font metrics. I think the spacing should be reduced. The question is: Are tall glyphs to be expected on road refs? Or should only "X" and "g" taken into account? If the latter, the line height can be reduced up to 30% (as measured with the actual font metrics of Noto UI). Related to #2470.

@pnorman
Copy link
Collaborator

pnorman commented Dec 1, 2016

Yes, it's Noto font metrics. I think the spacing should be reduced.

We need to recompute all the shield sizes, even if we reduce the spacing.

@kocio-pl kocio-pl added the text label Dec 3, 2016
@jojo4u
Copy link

jojo4u commented Dec 3, 2016

generate_shields.py has no comment how config['base'] was derived.

@nebulon42
Copy link
Contributor

That are values I came up with by trying.

@nebulon42 nebulon42 self-assigned this Mar 22, 2017
nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Mar 23, 2017
nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants