-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highway refs don't properly fit the shield #2478
Comments
I suspect that this is a consequence of the recent font change. |
Yes, it's Noto font metrics. I think the spacing should be reduced. The question is: Are tall glyphs to be expected on road refs? Or should only "X" and "g" taken into account? If the latter, the line height can be reduced up to 30% (as measured with the actual font metrics of Noto UI). Related to #2470. |
Some examples with tall glyphs: |
We need to recompute all the shield sizes, even if we reduce the spacing. |
generate_shields.py has no comment how config['base'] was derived. |
That are values I came up with by trying. |
Using this example (from https://www.openstreetmap.org/#map=18/-21.81209/-48.18708):
See how
SP-310
andBR-364
are touching the upper and lower shield borders.Actually, if we zoom, we can see that
BR-364
is surpassing the box:Isn't it possible to add some pixels on top and on bottom of the shield, to avoid this?
Or maybe reduce the vertical spacing between the values.
The text was updated successfully, but these errors were encountered: