Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering of waterway=ditch/drain incentivizes bad mapping #2346

Open
imagico opened this issue Sep 14, 2016 · 9 comments
Open

rendering of waterway=ditch/drain incentivizes bad mapping #2346

imagico opened this issue Sep 14, 2016 · 9 comments

Comments

@imagico
Copy link
Collaborator

imagico commented Sep 14, 2016

Currently this style renders waterway=ditch/drain thinner than waterway=stream at z15+ (2 vs. 3 pixels) but otherwise identical leading to widespread abuse for tagging small streams - there are literally thousands of cases of this in mountainous parts of southern Germany and Switzerland.

I have no solution for this at the moment, rendering them the same would reduce the incentive but ideally rendering should clearly indicate the difference between natural and artificial waterways.

Related to #1101

@ray66
Copy link

ray66 commented Sep 20, 2016

The width and zoom level visibility should reflect the appearance of natural and artificial waterways in the real world. According the waterway wiki page the major difference between streams and ditches is that the latter are artificial. The pictures illustrating both values are very similar. According to the same wiki page, the width of a ditch is similar to that of a small river. Therefore, my proposal is

  • render ditches with the same width as streams
  • render ditches and streams less thick than currently and only from zoom level 15 or 16 on
  • render drains thicker than ditches, slightly less or equal to rivers

@kocio-pl
Copy link
Collaborator

render drains thicker than drains

What did you mean here?

@imagico
Copy link
Collaborator Author

imagico commented Sep 20, 2016

The width and zoom level visibility should reflect the appearance of natural and artificial waterways in the real world.

No, a map is always a more or less abstract depiction. Nearly all maps that display rivers and other waterways display the important ones earlier and more prominently than they would appear in reality. The ability of this style to do the same is primarily limited by the difficulty to determine a reasonable and consistent measure of importance in real time from local properties.

Practically waterway=ditch and waterway=drain are used almost interchangeably, in particular since ditch is defined through the purpose of drainage. There is not really a basis in the data for rendering these two in different ways.

But it would make sense to make a clear difference between artificial and natural waterways in rendering, i am just not sure what would be a good way to do this.

@ray66
Copy link

ray66 commented Sep 20, 2016

@kocio-pl : Sorry, it should read "drains thicker than ditches". I corrected my original post.

@jeisenbe
Copy link
Collaborator

FYI, @imagico wrote a blog post showing a possible option for fixing this issue:

http://blog.imagico.de/water-under-the-bridge/

Complete code available here: https://github.com/imagico/osm-carto-alternative-colors/blob/master/water.mss

[waterway = 'ditch'],
      [waterway = 'drain'] {
        [zoom >= 15][intermittent != 'yes'][seasonal != 'yes'] {
          water/line-color: darken(@river-color, 6%);
          artificial/line-color: lighten(@river-color, 6%);
          artificial/line-width: @stream-width-z15 * 0.5;
          [zoom >= 16] { artificial/line-width: @stream-width-z16 * 0.5; }
          [zoom >= 17] { artificial/line-width: @stream-width-z17 * 0.5; }
          [zoom >= 18] { artificial/line-width: @stream-width-z18 * 0.5; }
          artificial/line-cap: butt;
          artificial/line-join: round;
        }
      }

This seems like a nice solution: ditches and drains are rendered the same width at streams (3 pixels at z16, 4 pixels at z18) but a lighter centerline is used to distinguish the artificial waterways: ditches, drains (and canals)

@Adamant36
Copy link
Contributor

@jeisenbe, you should test it out.

@imagico
Copy link
Collaborator Author

imagico commented May 28, 2019

Note the fix i had in mind as a good first issue was simple rendering ditches/drains identical to streams. Adding a subtle difference to stream that does not imply a size difference would be a bonus.

The ac-style approach is obviously connected to the three color scheme for waterbodies - not sure if and how it can be ported here.

@jeisenbe
Copy link
Collaborator

jeisenbe commented May 28, 2019 via email

@imagico
Copy link
Collaborator Author

imagico commented May 28, 2019

The idea of the 6% darker/lighter was that the overall visual weight of the line is the same as for a natural waterway. If this also works and is recognizable with a different, lighter color would need to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants