-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rendering of waterway=ditch/drain incentivizes bad mapping #2346
Comments
The width and zoom level visibility should reflect the appearance of natural and artificial waterways in the real world. According the waterway wiki page the major difference between streams and ditches is that the latter are artificial. The pictures illustrating both values are very similar. According to the same wiki page, the width of a ditch is similar to that of a small river. Therefore, my proposal is
|
What did you mean here? |
No, a map is always a more or less abstract depiction. Nearly all maps that display rivers and other waterways display the important ones earlier and more prominently than they would appear in reality. The ability of this style to do the same is primarily limited by the difficulty to determine a reasonable and consistent measure of importance in real time from local properties. Practically But it would make sense to make a clear difference between artificial and natural waterways in rendering, i am just not sure what would be a good way to do this. |
@kocio-pl : Sorry, it should read "drains thicker than ditches". I corrected my original post. |
FYI, @imagico wrote a blog post showing a possible option for fixing this issue: http://blog.imagico.de/water-under-the-bridge/ Complete code available here: https://github.com/imagico/osm-carto-alternative-colors/blob/master/water.mss
This seems like a nice solution: ditches and drains are rendered the same width at streams (3 pixels at z16, 4 pixels at z18) but a lighter centerline is used to distinguish the artificial waterways: ditches, drains (and canals) |
@jeisenbe, you should test it out. |
Note the fix i had in mind as a good first issue was simple rendering ditches/drains identical to streams. Adding a subtle difference to stream that does not imply a size difference would be a bonus. The ac-style approach is obviously connected to the three color scheme for waterbodies - not sure if and how it can be ported here. |
I'm planning to submit a PR with the darker river color, since this is
needed to get the better low zoom rendering and for better contrast of
rivers on woodlands.
But I think that something like a 12% lighter centerline color (As in
the AC style) would work even if the current ditch/drain color was not
changed.
…On 5/28/19, Christoph Hormann ***@***.***> wrote:
Note the fix i had in mind as a good first issue was simple rendering
ditches/drains identical to streams. Adding a subtle difference to stream
that does not imply a size difference would be a bonus.
The ac-style approach is obviously connected to the three color scheme for
waterbodies - not sure if and how it can be ported here.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2346 (comment)
|
The idea of the 6% darker/lighter was that the overall visual weight of the line is the same as for a natural waterway. If this also works and is recognizable with a different, lighter color would need to be tested. |
Currently this style renders waterway=ditch/drain thinner than waterway=stream at z15+ (2 vs. 3 pixels) but otherwise identical leading to widespread abuse for tagging small streams - there are literally thousands of cases of this in mountainous parts of southern Germany and Switzerland.
I have no solution for this at the moment, rendering them the same would reduce the incentive but ideally rendering should clearly indicate the difference between natural and artificial waterways.
Related to #1101
The text was updated successfully, but these errors were encountered: